starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #5106] [MERGED] Fixes zero byte nfo files. #10402

New Issue
Closed
opened 2026-02-07 06:19:41 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:19:41 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/5106
Author: @BaronGreenback
Created: 1/25/2021
Status: ✅ Merged
Merged: 2/3/2021
Merged by: @Bond-009

Base: master ← Head: FileShareTest2

📝 Commits (2)

📊 Changes

1 file changed (+3 additions, -2 deletions)

View changed files

📝 MediaBrowser.XbmcMetadata/Savers/BaseNfoSaver.cs (+3 -2)

📄 Description

Fixes #4826 and bypasses dotnet bug. (https://github.com/dotnet/runtime/issues/42790)

May be other occurrences of this bug in JF.

From Dotnet Documentation
Filemode.Create - Specifies that the operating system should create a new file.

If the file already exists, it will be overwritten. This requires Write permission.

FileMode.Create is equivalent to requesting that if the file does not exist, use CreateNew;
otherwise, use Truncate. (0 byte file)
If the file already exists but is a hidden file, an UnauthorizedAccessException exception is thrown.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/5106 **Author:** [@BaronGreenback](https://github.com/BaronGreenback) **Created:** 1/25/2021 **Status:** ✅ Merged **Merged:** 2/3/2021 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `FileShareTest2` --- ### 📝 Commits (2) - [`21d1598`](https://github.com/jellyfin/jellyfin/commit/21d15989f5abe6d50529207df4df047c0e3f06ea) 1 attempted fix - [`8d12e6d`](https://github.com/jellyfin/jellyfin/commit/8d12e6d6eb98ee5f14a0ca30cb8ca824aa051155) Update BaseNfoSaver.cs ### 📊 Changes **1 file changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.XbmcMetadata/Savers/BaseNfoSaver.cs` (+3 -2) </details> ### 📄 Description Fixes #4826 and bypasses dotnet bug. (https://github.com/dotnet/runtime/issues/42790) May be other occurrences of this bug in JF. From Dotnet Documentation Filemode.Create - Specifies that the operating system should create a new file. If the file already exists, it will be overwritten. This requires Write permission. FileMode.Create is equivalent to requesting that if the file does not exist, use CreateNew; otherwise, use Truncate. (0 byte file) If the file already exists but is a hidden file, an UnauthorizedAccessException exception is thrown. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:19:41 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10402
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?