starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #5025] [MERGED] Fix DLNA PlayTo encoding issue #10368

New Issue
Closed
opened 2026-02-07 06:19:04 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:19:04 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/5025
Author: @BaronGreenback
Created: 1/15/2021
Status: ✅ Merged
Merged: 1/18/2021
Merged by: @cvium

Base: master ← Head: DlnaFix

📝 Commits (5)

📊 Changes

2 files changed (+4 additions, -3 deletions)

View changed files

📝 Emby.Dlna/Didl/DidlBuilder.cs (+1 -0)
📝 Emby.Dlna/PlayTo/PlayToController.cs (+3 -3)

📄 Description

Fix 1: Didl metadata wasn't being populated (all the time???) as flush was absent.

Fix 2: Exception caused by non-string GUID being parsed.
(Raised by the DLNA eventing when the TV was already playing alternative content that contained the word "audios" in the url)

Additional errors still exist in metadata parsing around url encoding, which results in xml parsing errors. This is addressed in the plugin.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/5025 **Author:** [@BaronGreenback](https://github.com/BaronGreenback) **Created:** 1/15/2021 **Status:** ✅ Merged **Merged:** 1/18/2021 **Merged by:** [@cvium](https://github.com/cvium) **Base:** `master` ← **Head:** `DlnaFix` --- ### 📝 Commits (5) - [`16d092a`](https://github.com/jellyfin/jellyfin/commit/16d092a8a715463f7884f53341c064accd4da952) Fixed encoding issue - [`620648f`](https://github.com/jellyfin/jellyfin/commit/620648fe81cd924c906326ea7afa236f937ff844) Fixed for no data. - [`13012bf`](https://github.com/jellyfin/jellyfin/commit/13012bfa273a98d06771bc11aeca1d62f9f23307) Fix bug in GetItemId - [`828a9b7`](https://github.com/jellyfin/jellyfin/commit/828a9b7c75bbe79c8591c785745851e824589d11) rollback - [`e81b7c8`](https://github.com/jellyfin/jellyfin/commit/e81b7c8f4f054aaf5c1f25ea9c9d6986fbd501c3) reverted ### 📊 Changes **2 files changed** (+4 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Dlna/Didl/DidlBuilder.cs` (+1 -0) 📝 `Emby.Dlna/PlayTo/PlayToController.cs` (+3 -3) </details> ### 📄 Description **Fix 1:** Didl metadata wasn't being populated (all the time???) as flush was absent. **Fix 2:** Exception caused by non-string GUID being parsed. (Raised by the DLNA eventing when the TV was already playing alternative content that contained the word "audios" in the url) Additional errors still exist in metadata parsing around url encoding, which results in xml parsing errors. This is addressed in the plugin. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:19:04 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10368
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?