starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #4906] [MERGED] Ignore inaccessible files & folders during library scans #10327

New Issue
Closed
opened 2026-02-07 06:18:17 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:18:17 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4906
Author: @Spacetech
Created: 1/1/2021
Status: ✅ Merged
Merged: 1/8/2021
Merged by: @Bond-009

Base: master ← Head: library_scan_ignore_inaccessible

📝 Commits (1)

  • 1fdeac0 Ignore inaccessible files during library scans

📊 Changes

2 files changed (+22 additions, -17 deletions)

View changed files

📝 Emby.Server.Implementations/IO/ManagedFileSystem.cs (+21 -16)
📝 Emby.Server.Implementations/Library/Resolvers/PlaylistResolver.cs (+1 -1)

📄 Description

Ignore inaccessible files & folders during library scans.

Changes
Library scans enumerate many files and folders. If a single file or folder is inaccessible due to permission issues during one of those enumeration calls, the whole enumeration call would fail. For example if you have a single TV show or movie folder that is inaccessible, the library scan would fail to enumerate any other shows / movies within that same parent folder.

Examples of those errors:

[2020-12-31 17:40:25.260 -08:00] [ERR] [13] Emby.Server.Implementations.Library.LibraryManager: Error resolving path "M:\Anime\A_Secret_Folder"
System.UnauthorizedAccessException: Access to the path 'M:\Anime\A_Secret_Folder' is denied.
   at System.IO.Enumeration.FileSystemEnumerator`1.CreateDirectoryHandle(String path, Boolean ignoreNotFound)
   at System.IO.Enumeration.FileSystemEnumerator`1.Init()
   at System.IO.Enumeration.FileSystemEnumerable`1..ctor(String directory, FindTransform transform, EnumerationOptions options, Boolean isNormalized)
   at System.IO.Enumeration.FileSystemEnumerableFactory.DirectoryInfos(String directory, String expression, EnumerationOptions options, Boolean isNormalized)
   at System.IO.DirectoryInfo.InternalEnumerateInfos(String path, String searchPattern, SearchTarget searchTarget, EnumerationOptions options)
   at System.IO.DirectoryInfo.EnumerateDirectories(String searchPattern, SearchOption searchOption)
   at Emby.Server.Implementations.IO.ManagedFileSystem.GetFileSystemEntries(String path, Boolean recursive) in C:\Programming\jellyfin\Emby.Server.Implementations\IO\ManagedFileSystem.cs:line 630
   at MediaBrowser.Controller.Providers.DirectoryService.<GetFileSystemEntries>b__5_0(String p) in C:\Programming\jellyfin\MediaBrowser.Controller\Providers\DirectoryService.cs:line 28
   at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd(TKey key, Func`2 valueFactory)
   at MediaBrowser.Controller.Providers.DirectoryService.GetFileSystemEntries(String path) in C:\Programming\jellyfin\MediaBrowser.Controller\Providers\DirectoryService.cs:line 28
   at MediaBrowser.Controller.IO.FileData.GetFilteredFileSystemEntries(IDirectoryService directoryService, String path, IFileSystem fileSystem, IServerApplicationHost appHost, ILogger logger, ItemResolveArgs args, Int32 flattenFolderDepth, Boolean resolveShortcuts) in C:\Programming\jellyfin\MediaBrowser.Controller\IO\FileData.cs:line 48
   at Emby.Server.Implementations.Library.LibraryManager.ResolvePath(FileSystemMetadata fileInfo, IDirectoryService directoryService, IItemResolver[] resolvers, Folder parent, String collectionType, LibraryOptions libraryOptions) in C:\Programming\jellyfin\Emby.Server.Implementations\Library\LibraryManager.cs:line 586
   at Emby.Server.Implementations.Library.LibraryManager.<>c__DisplayClass88_0.<ResolveFileList>b__0(FileSystemMetadata f) in C:\Programming\jellyfin\Emby.Server.Implementations\Library\LibraryManager.cs:line 711

[2020-12-31 17:55:06.117 -08:00] [ERR] [8] Emby.Server.Implementations.Library.LibraryManager: Error in "PlaylistResolver" resolving "M:\Anime\A_Secret_Folder"
   System.UnauthorizedAccessException: Access to the path 'M:\Anime\A_Secret_Folder' is denied.
   at System.IO.Enumeration.FileSystemEnumerator`1.CreateDirectoryHandle(String path, Boolean ignoreNotFound)
   at System.IO.Enumeration.FileSystemEnumerator`1.Init()
   at System.IO.Enumeration.FileSystemEnumerable`1..ctor(String directory, FindTransform transform, EnumerationOptions options, Boolean isNormalized)
   at System.IO.Enumeration.FileSystemEnumerableFactory.UserFiles(String directory, String expression, EnumerationOptions options)
   at System.IO.Directory.InternalEnumeratePaths(String path, String searchPattern, SearchTarget searchTarget, EnumerationOptions options)
   at System.IO.Directory.EnumerateFiles(String path)
   at Emby.Server.Implementations.Library.Resolvers.PlaylistResolver.Resolve(ItemResolveArgs args) in C:\Programming\jellyfin\Emby.Server.Implementations\Library\Resolvers\PlaylistResolver.cs:line 44
   at Emby.Server.Implementations.Library.Resolvers.ItemResolver`1.MediaBrowser.Controller.Resolvers.IItemResolver.ResolvePath(ItemResolveArgs args) in C:\Programming\jellyfin\Emby.Server.Implementations\Library\Resolvers\ItemResolver.cs:line 46
   at Emby.Server.Implementations.Library.LibraryManager.Resolve(ItemResolveArgs args, IItemResolver resolver) in C:\Programming\jellyfin\Emby.Server.Implementations\Library\LibraryManager.cs:line 490

.NET 5 introduces a new EnumerationOptions class with an IgnoreInaccessible property that allows us to choose how an enumeration should handle files & folders that are inaccessible. Now the library scan will ignore them.

Note: IgnoreInaccessible defaults to true so we don't really need to specify it. But I think including it in the code is good practice to ensure future contributors know this behavior is occurring.

Issues

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4906 **Author:** [@Spacetech](https://github.com/Spacetech) **Created:** 1/1/2021 **Status:** ✅ Merged **Merged:** 1/8/2021 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `library_scan_ignore_inaccessible` --- ### 📝 Commits (1) - [`1fdeac0`](https://github.com/jellyfin/jellyfin/commit/1fdeac0a7d7a502e92352db8feaf0208270d1b6e) Ignore inaccessible files during library scans ### 📊 Changes **2 files changed** (+22 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/IO/ManagedFileSystem.cs` (+21 -16) 📝 `Emby.Server.Implementations/Library/Resolvers/PlaylistResolver.cs` (+1 -1) </details> ### 📄 Description Ignore inaccessible files & folders during library scans. **Changes** Library scans enumerate many files and folders. If a single file or folder is inaccessible due to permission issues during one of those enumeration calls, the whole enumeration call would fail. For example if you have a single TV show or movie folder that is inaccessible, the library scan would fail to enumerate any other shows / movies within that same parent folder. Examples of those errors: ``` [2020-12-31 17:40:25.260 -08:00] [ERR] [13] Emby.Server.Implementations.Library.LibraryManager: Error resolving path "M:\Anime\A_Secret_Folder" System.UnauthorizedAccessException: Access to the path 'M:\Anime\A_Secret_Folder' is denied. at System.IO.Enumeration.FileSystemEnumerator`1.CreateDirectoryHandle(String path, Boolean ignoreNotFound) at System.IO.Enumeration.FileSystemEnumerator`1.Init() at System.IO.Enumeration.FileSystemEnumerable`1..ctor(String directory, FindTransform transform, EnumerationOptions options, Boolean isNormalized) at System.IO.Enumeration.FileSystemEnumerableFactory.DirectoryInfos(String directory, String expression, EnumerationOptions options, Boolean isNormalized) at System.IO.DirectoryInfo.InternalEnumerateInfos(String path, String searchPattern, SearchTarget searchTarget, EnumerationOptions options) at System.IO.DirectoryInfo.EnumerateDirectories(String searchPattern, SearchOption searchOption) at Emby.Server.Implementations.IO.ManagedFileSystem.GetFileSystemEntries(String path, Boolean recursive) in C:\Programming\jellyfin\Emby.Server.Implementations\IO\ManagedFileSystem.cs:line 630 at MediaBrowser.Controller.Providers.DirectoryService.<GetFileSystemEntries>b__5_0(String p) in C:\Programming\jellyfin\MediaBrowser.Controller\Providers\DirectoryService.cs:line 28 at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd(TKey key, Func`2 valueFactory) at MediaBrowser.Controller.Providers.DirectoryService.GetFileSystemEntries(String path) in C:\Programming\jellyfin\MediaBrowser.Controller\Providers\DirectoryService.cs:line 28 at MediaBrowser.Controller.IO.FileData.GetFilteredFileSystemEntries(IDirectoryService directoryService, String path, IFileSystem fileSystem, IServerApplicationHost appHost, ILogger logger, ItemResolveArgs args, Int32 flattenFolderDepth, Boolean resolveShortcuts) in C:\Programming\jellyfin\MediaBrowser.Controller\IO\FileData.cs:line 48 at Emby.Server.Implementations.Library.LibraryManager.ResolvePath(FileSystemMetadata fileInfo, IDirectoryService directoryService, IItemResolver[] resolvers, Folder parent, String collectionType, LibraryOptions libraryOptions) in C:\Programming\jellyfin\Emby.Server.Implementations\Library\LibraryManager.cs:line 586 at Emby.Server.Implementations.Library.LibraryManager.<>c__DisplayClass88_0.<ResolveFileList>b__0(FileSystemMetadata f) in C:\Programming\jellyfin\Emby.Server.Implementations\Library\LibraryManager.cs:line 711 ``` ``` [2020-12-31 17:55:06.117 -08:00] [ERR] [8] Emby.Server.Implementations.Library.LibraryManager: Error in "PlaylistResolver" resolving "M:\Anime\A_Secret_Folder" System.UnauthorizedAccessException: Access to the path 'M:\Anime\A_Secret_Folder' is denied. at System.IO.Enumeration.FileSystemEnumerator`1.CreateDirectoryHandle(String path, Boolean ignoreNotFound) at System.IO.Enumeration.FileSystemEnumerator`1.Init() at System.IO.Enumeration.FileSystemEnumerable`1..ctor(String directory, FindTransform transform, EnumerationOptions options, Boolean isNormalized) at System.IO.Enumeration.FileSystemEnumerableFactory.UserFiles(String directory, String expression, EnumerationOptions options) at System.IO.Directory.InternalEnumeratePaths(String path, String searchPattern, SearchTarget searchTarget, EnumerationOptions options) at System.IO.Directory.EnumerateFiles(String path) at Emby.Server.Implementations.Library.Resolvers.PlaylistResolver.Resolve(ItemResolveArgs args) in C:\Programming\jellyfin\Emby.Server.Implementations\Library\Resolvers\PlaylistResolver.cs:line 44 at Emby.Server.Implementations.Library.Resolvers.ItemResolver`1.MediaBrowser.Controller.Resolvers.IItemResolver.ResolvePath(ItemResolveArgs args) in C:\Programming\jellyfin\Emby.Server.Implementations\Library\Resolvers\ItemResolver.cs:line 46 at Emby.Server.Implementations.Library.LibraryManager.Resolve(ItemResolveArgs args, IItemResolver resolver) in C:\Programming\jellyfin\Emby.Server.Implementations\Library\LibraryManager.cs:line 490 ``` .NET 5 introduces a new [EnumerationOptions class](https://docs.microsoft.com/en-us/dotnet/api/system.io.enumerationoptions?view=net-5.0) with an `IgnoreInaccessible` property that allows us to choose how an enumeration should handle files & folders that are inaccessible. Now the library scan will ignore them. Note: `IgnoreInaccessible` defaults to `true` so we don't really need to specify it. But I think including it in the code is good practice to ensure future contributors know this behavior is occurring. **Issues** - Fixes #4882 & #2402 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:18:17 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10327
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?