starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #4901] [CLOSED] Enable nullable for DvdLib project #10326

New Issue
Closed
opened 2026-02-07 06:18:14 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:18:14 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4901
Author: @martinek-stepan
Created: 12/31/2020
Status: ❌ Closed

Base: master ← Head: nullable-dvdlib

📝 Commits (3)

  • 2a1e79c Enable nullable for DvdLib project & simplify Cell parsing (instead of parsing twice and skipping parsed position bytes, parse in order once.
  • 9c559f5 Create ProgramChainBuilder to safely allow late-initialization of several ProgramChain properties.
  • 84ea148 Make EntryProgramChain optional (nullable) as it is only assigned if dvd enables it.

📊 Changes

6 files changed (+47 additions, -29 deletions)

View changed files

📝 DvdLib/DvdLib.csproj (+1 -0)
📝 DvdLib/Ifo/Cell.cs (+5 -9)
📝 DvdLib/Ifo/CellPlaybackInfo.cs (+0 -1)
📝 DvdLib/Ifo/ProgramChain.cs (+15 -16)
➕ DvdLib/Ifo/ProgramChainBuilder.cs (+24 -0)
📝 DvdLib/Ifo/Title.cs (+2 -3)

📄 Description

Changes

Enable nullable on the project level and reflect changes in code.
Created ProgramChainBuilder to allow make sure non-nullable late initialized properties are valid.

Issues

Part of issue #2768

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4901 **Author:** [@martinek-stepan](https://github.com/martinek-stepan) **Created:** 12/31/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `nullable-dvdlib` --- ### 📝 Commits (3) - [`2a1e79c`](https://github.com/jellyfin/jellyfin/commit/2a1e79c4850b67846babf9287f78605ab30a344a) Enable nullable for DvdLib project & simplify Cell parsing (instead of parsing twice and skipping parsed position bytes, parse in order once. - [`9c559f5`](https://github.com/jellyfin/jellyfin/commit/9c559f596bf755b2e3d1dbdcc7c8293b8df88c3f) Create ProgramChainBuilder to safely allow late-initialization of several ProgramChain properties. - [`84ea148`](https://github.com/jellyfin/jellyfin/commit/84ea14855e4aa95b8796d484d6607e49af2ec91f) Make EntryProgramChain optional (nullable) as it is only assigned if dvd enables it. ### 📊 Changes **6 files changed** (+47 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `DvdLib/DvdLib.csproj` (+1 -0) 📝 `DvdLib/Ifo/Cell.cs` (+5 -9) 📝 `DvdLib/Ifo/CellPlaybackInfo.cs` (+0 -1) 📝 `DvdLib/Ifo/ProgramChain.cs` (+15 -16) ➕ `DvdLib/Ifo/ProgramChainBuilder.cs` (+24 -0) 📝 `DvdLib/Ifo/Title.cs` (+2 -3) </details> ### 📄 Description <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** <!-- Describe your changes here in 1-5 sentences. --> Enable nullable on the project level and reflect changes in code. Created ProgramChainBuilder to allow make sure non-nullable late initialized properties are valid. **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> Part of issue #2768 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:18:14 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10326
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?