starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #4881] [CLOSED] Return 404 if a named config is not found. #10317

New Issue
Closed
opened 2026-02-07 06:18:05 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:18:05 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4881
Author: @BaronGreenback
Created: 12/29/2020
Status: ❌ Closed

Base: master ← Head: NoConfigError

📝 Commits (1)

  • dd41e3d Return not found if named config not found

📊 Changes

1 file changed (+15 additions, -1 deletions)

View changed files

📝 Jellyfin.Api/Controllers/ConfigurationController.cs (+15 -1)

📄 Description

Currently an exception is created if a named config is not found.

If the web client wants include functionality only available in plugins (eg cinemamode), do we want errors logged when the config is missing, or should we return 404. (see #4867 - don't think this issue is the sole cause)

This PR returns 404 not found instead of logging the exception.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4881 **Author:** [@BaronGreenback](https://github.com/BaronGreenback) **Created:** 12/29/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `NoConfigError` --- ### 📝 Commits (1) - [`dd41e3d`](https://github.com/jellyfin/jellyfin/commit/dd41e3dde0ce92b0e67168f8c8aae915f78fdce8) Return not found if named config not found ### 📊 Changes **1 file changed** (+15 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Api/Controllers/ConfigurationController.cs` (+15 -1) </details> ### 📄 Description Currently an exception is created if a named config is not found. If the web client wants include functionality only available in plugins (eg cinemamode), do we want errors logged when the config is missing, or should we return 404. (see #4867 - don't think this issue is the sole cause) This PR returns **404 not found** instead of logging the exception. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:18:05 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10317
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?