starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #4870] [CLOSED] Providers Cleanup: Removed warnings and messages #10311

New Issue
Closed
opened 2026-02-07 06:17:56 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:17:56 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4870
Author: @BaronGreenback
Created: 12/26/2020
Status: ❌ Closed

Base: master ← Head: WarningsCleanup

📝 Commits (5)

📊 Changes

39 files changed (+2626 additions, -2172 deletions)

View changed files

📝 MediaBrowser.Providers/Manager/ItemImageProvider.cs (+177 -152)
📝 MediaBrowser.Providers/Manager/MetadataService.cs (+361 -283)
📝 MediaBrowser.Providers/Manager/ProviderManager.cs (+534 -439)
📝 MediaBrowser.Providers/MediaInfo/FFProbeVideoInfo.cs (+100 -83)
📝 MediaBrowser.Providers/Plugins/AudioDb/AudioDbAlbumImageProvider.cs (+17 -17)
📝 MediaBrowser.Providers/Plugins/AudioDb/AudioDbAlbumProvider.cs (+131 -123)
📝 MediaBrowser.Providers/Plugins/AudioDb/AudioDbArtistImageProvider.cs (+24 -24)
📝 MediaBrowser.Providers/Plugins/AudioDb/AudioDbArtistProvider.cs (+107 -99)
➖ MediaBrowser.Providers/Plugins/MusicBrainz/ExternalIds.cs (+0 -119)
➕ MediaBrowser.Providers/Plugins/MusicBrainz/MusicBrainzAlbumArtistExternalId.cs (+28 -0)
➕ MediaBrowser.Providers/Plugins/MusicBrainz/MusicBrainzAlbumExternalId.cs (+28 -0)
📝 MediaBrowser.Providers/Plugins/MusicBrainz/MusicBrainzAlbumProvider.cs (+410 -392)
➕ MediaBrowser.Providers/Plugins/MusicBrainz/MusicBrainzArtistExternalId.cs (+28 -0)
📝 MediaBrowser.Providers/Plugins/MusicBrainz/MusicBrainzArtistProvider.cs (+111 -114)
➕ MediaBrowser.Providers/Plugins/MusicBrainz/MusicBrainzOtherArtistExternalId.cs (+28 -0)
➕ MediaBrowser.Providers/Plugins/MusicBrainz/MusicBrainzReleaseGroupExternalId.cs (+28 -0)
➕ MediaBrowser.Providers/Plugins/MusicBrainz/MusicBrainzTrackId.cs (+28 -0)
📝 MediaBrowser.Providers/Plugins/MusicBrainz/Plugin.cs (+11 -11)
📝 MediaBrowser.Providers/Plugins/Omdb/OmdbEpisodeProvider.cs (+8 -5)
📝 MediaBrowser.Providers/Plugins/Omdb/OmdbImageProvider.cs (+5 -6)

...and 19 more files

📄 Description

Added null checks as recommended by VS.
Re-ordered methods as recommended by VS.
Renamed variables as recommended by VS.
Split multi-class files into separate files as recommended by VS.
Renamed files to match classes as recommended by VS.
Implemented optimizations as recommended by VS.

Didn't Nullify
Didn't add/change any comments.
Didn't add/change any code

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4870 **Author:** [@BaronGreenback](https://github.com/BaronGreenback) **Created:** 12/26/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `WarningsCleanup` --- ### 📝 Commits (5) - [`97ff464`](https://github.com/jellyfin/jellyfin/commit/97ff46427229fa21620e23345607010e12d0b820) Initial batch of message fixes. - [`800fa87`](https://github.com/jellyfin/jellyfin/commit/800fa875f1f7248aa6fb9eadd1ee72cce5cb1ecb) First batch finished. - [`3a9b2b9`](https://github.com/jellyfin/jellyfin/commit/3a9b2b9b55b11f2a96d31d2dd39937ec3a952631) Fixed name violations - [`f29ad30`](https://github.com/jellyfin/jellyfin/commit/f29ad30337dfa0d1b01be2c2768b95b4d4b8be6c) Final set. - [`42e9df5`](https://github.com/jellyfin/jellyfin/commit/42e9df527872742c92e1c3de43694e6a6fce6d40) Three blank lines removed. ### 📊 Changes **39 files changed** (+2626 additions, -2172 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.Providers/Manager/ItemImageProvider.cs` (+177 -152) 📝 `MediaBrowser.Providers/Manager/MetadataService.cs` (+361 -283) 📝 `MediaBrowser.Providers/Manager/ProviderManager.cs` (+534 -439) 📝 `MediaBrowser.Providers/MediaInfo/FFProbeVideoInfo.cs` (+100 -83) 📝 `MediaBrowser.Providers/Plugins/AudioDb/AudioDbAlbumImageProvider.cs` (+17 -17) 📝 `MediaBrowser.Providers/Plugins/AudioDb/AudioDbAlbumProvider.cs` (+131 -123) 📝 `MediaBrowser.Providers/Plugins/AudioDb/AudioDbArtistImageProvider.cs` (+24 -24) 📝 `MediaBrowser.Providers/Plugins/AudioDb/AudioDbArtistProvider.cs` (+107 -99) ➖ `MediaBrowser.Providers/Plugins/MusicBrainz/ExternalIds.cs` (+0 -119) ➕ `MediaBrowser.Providers/Plugins/MusicBrainz/MusicBrainzAlbumArtistExternalId.cs` (+28 -0) ➕ `MediaBrowser.Providers/Plugins/MusicBrainz/MusicBrainzAlbumExternalId.cs` (+28 -0) 📝 `MediaBrowser.Providers/Plugins/MusicBrainz/MusicBrainzAlbumProvider.cs` (+410 -392) ➕ `MediaBrowser.Providers/Plugins/MusicBrainz/MusicBrainzArtistExternalId.cs` (+28 -0) 📝 `MediaBrowser.Providers/Plugins/MusicBrainz/MusicBrainzArtistProvider.cs` (+111 -114) ➕ `MediaBrowser.Providers/Plugins/MusicBrainz/MusicBrainzOtherArtistExternalId.cs` (+28 -0) ➕ `MediaBrowser.Providers/Plugins/MusicBrainz/MusicBrainzReleaseGroupExternalId.cs` (+28 -0) ➕ `MediaBrowser.Providers/Plugins/MusicBrainz/MusicBrainzTrackId.cs` (+28 -0) 📝 `MediaBrowser.Providers/Plugins/MusicBrainz/Plugin.cs` (+11 -11) 📝 `MediaBrowser.Providers/Plugins/Omdb/OmdbEpisodeProvider.cs` (+8 -5) 📝 `MediaBrowser.Providers/Plugins/Omdb/OmdbImageProvider.cs` (+5 -6) _...and 19 more files_ </details> ### 📄 Description Added null checks as recommended by VS. Re-ordered methods as recommended by VS. Renamed variables as recommended by VS. Split multi-class files into separate files as recommended by VS. Renamed files to match classes as recommended by VS. Implemented optimizations as recommended by VS. **Didn't Nullify Didn't add/change any comments. Didn't add/change any code** --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:17:56 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10311
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?