[PR #4803] [MERGED] Fix Live TV Recording Scheduling #10286

Closed
opened 2026-02-07 06:17:26 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4803
Author: @ryanpetris
Created: 12/16/2020
Status: Merged
Merged: 12/20/2020
Merged by: @cvium

Base: masterHead: fix-getuser


📝 Commits (2)

  • 1b3fcab If requestContext is HttpRequest, get the context from it properly.
  • 875562e This is only used in one place and therefore will always be HttpRequest.

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 Emby.Server.Implementations/HttpServer/Security/SessionContext.cs (+1 -1)

📄 Description

Currently (in master) it is impossible to schedule a recording, either for a series or an individual showing, due to an invalid cast.

I'm not sure if this changed with .NET 5.0, however this used to work and there doesn't appear to be a code change that would have caused this to break.

Changes
Modify SessionContext.GetUser(object) to cast requestContext to HttpRequest, then use the HttpContext property. This is in lieu of casting directly to an HttpContext.

Issues
I was unable to find an issue related to this. This likely exists only in the master branch.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4803 **Author:** [@ryanpetris](https://github.com/ryanpetris) **Created:** 12/16/2020 **Status:** ✅ Merged **Merged:** 12/20/2020 **Merged by:** [@cvium](https://github.com/cvium) **Base:** `master` ← **Head:** `fix-getuser` --- ### 📝 Commits (2) - [`1b3fcab`](https://github.com/jellyfin/jellyfin/commit/1b3fcab6a400a9370b54287f4371638530a00e19) If requestContext is HttpRequest, get the context from it properly. - [`875562e`](https://github.com/jellyfin/jellyfin/commit/875562e580a1f36d0364c04af22bfd9c7234ef95) This is only used in one place and therefore will always be HttpRequest. ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/HttpServer/Security/SessionContext.cs` (+1 -1) </details> ### 📄 Description Currently (in master) it is impossible to schedule a recording, either for a series or an individual showing, due to an invalid cast. I'm not sure if this changed with .NET 5.0, however this used to work and there doesn't appear to be a code change that would have caused this to break. **Changes** Modify SessionContext.GetUser(object) to cast requestContext to HttpRequest, then use the HttpContext property. This is in lieu of casting directly to an HttpContext. **Issues** I was unable to find an issue related to this. This likely exists only in the master branch. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:17:26 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10286