mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-07-16 05:43:54 +03:00
[PR #4803] [MERGED] Fix Live TV Recording Scheduling #10286
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/jellyfin/jellyfin/pull/4803
Author: @ryanpetris
Created: 12/16/2020
Status: ✅ Merged
Merged: 12/20/2020
Merged by: @cvium
Base:
master← Head:fix-getuser📝 Commits (2)
1b3fcabIf requestContext is HttpRequest, get the context from it properly.875562eThis is only used in one place and therefore will always be HttpRequest.📊 Changes
1 file changed (+1 additions, -1 deletions)
View changed files
📝
Emby.Server.Implementations/HttpServer/Security/SessionContext.cs(+1 -1)📄 Description
Currently (in master) it is impossible to schedule a recording, either for a series or an individual showing, due to an invalid cast.
I'm not sure if this changed with .NET 5.0, however this used to work and there doesn't appear to be a code change that would have caused this to break.
Changes
Modify SessionContext.GetUser(object) to cast requestContext to HttpRequest, then use the HttpContext property. This is in lieu of casting directly to an HttpContext.
Issues
I was unable to find an issue related to this. This likely exists only in the master branch.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.