starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #4799] [MERGED] Authorization header parsing #10282

New Issue
Closed
opened 2026-02-07 06:17:25 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:17:25 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4799
Author: @tommasodotNET
Created: 12/15/2020
Status: ✅ Merged
Merged: 9/4/2021
Merged by: @cvium

Base: master ← Head: bug/authorization-header-issue

📝 Commits (10+)

  • 064a9ce No htlml encoding on server side
  • 13bc57e No need to double check param length
  • 305e5eb Allow commas in auth values when wappred in a double quote
  • b611a10 -fix split on comma and double quotes
  • 6e2cfc6 Url decode for auth value
  • c6eefaa Added function to split the authorization header parts
  • 7c7f231 Added comments
  • a03880b Improve get auth header parts using substring
  • 452af30 Added UrlDecode for authorization parts
  • 414e918 Optimized and added test

📊 Changes

2 files changed (+99 additions, -15 deletions)

View changed files

📝 Jellyfin.Server.Implementations/Security/AuthorizationContext.cs (+42 -15)
📝 tests/Jellyfin.Api.Tests/Auth/DefaultAuthorizationPolicy/DefaultAuthorizationHandlerTests.cs (+57 -0)

📄 Description

Changes

Issues
Adresses #4739

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4799 **Author:** [@tommasodotNET](https://github.com/tommasodotNET) **Created:** 12/15/2020 **Status:** ✅ Merged **Merged:** 9/4/2021 **Merged by:** [@cvium](https://github.com/cvium) **Base:** `master` ← **Head:** `bug/authorization-header-issue` --- ### 📝 Commits (10+) - [`064a9ce`](https://github.com/jellyfin/jellyfin/commit/064a9cedbd205594fa529ff996b2cd359c5be07c) No htlml encoding on server side - [`13bc57e`](https://github.com/jellyfin/jellyfin/commit/13bc57ecc39ebd485634f64f90ed526b134a521c) No need to double check param length - [`305e5eb`](https://github.com/jellyfin/jellyfin/commit/305e5ebaf40d02f15664c49c26391531a548608d) Allow commas in auth values when wappred in a double quote - [`b611a10`](https://github.com/jellyfin/jellyfin/commit/b611a108f89ab77b219aecc6d6155540f772cf32) -fix split on comma and double quotes - [`6e2cfc6`](https://github.com/jellyfin/jellyfin/commit/6e2cfc6569044251a7968fdeb16f245cecc46fe6) Url decode for auth value - [`c6eefaa`](https://github.com/jellyfin/jellyfin/commit/c6eefaac0975c351cfb20ace1c67d837dc0b7393) Added function to split the authorization header parts - [`7c7f231`](https://github.com/jellyfin/jellyfin/commit/7c7f2316faa36fbdd6044ae27e05823e317d167f) Added comments - [`a03880b`](https://github.com/jellyfin/jellyfin/commit/a03880b687cf1b69c25bd8d207b2ebfb0c420571) Improve get auth header parts using substring - [`452af30`](https://github.com/jellyfin/jellyfin/commit/452af30511a80e99e22794fc8009d7a6a9b9c904) Added UrlDecode for authorization parts - [`414e918`](https://github.com/jellyfin/jellyfin/commit/414e918c01a2458aa28c654332a8bad4f79cfa90) Optimized and added test ### 📊 Changes **2 files changed** (+99 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Server.Implementations/Security/AuthorizationContext.cs` (+42 -15) 📝 `tests/Jellyfin.Api.Tests/Auth/DefaultAuthorizationPolicy/DefaultAuthorizationHandlerTests.cs` (+57 -0) </details> ### 📄 Description <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** <!-- Describe your changes here in 1-5 sentences. --> **Issues** Adresses #4739 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:17:25 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10282
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?