starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #4729] [MERGED] Disable DLNA when HTTPS is required #10249

New Issue
Closed
opened 2026-02-07 06:16:46 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:16:46 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4729
Author: @BaronGreenback
Created: 12/8/2020
Status: ✅ Merged
Merged: 12/31/2020
Merged by: @joshuaboniface

Base: master ← Head: 19.0RC---Fix-networkInterfaceFix

📝 Commits (4)

  • d69f2d7 DNLA over HTTP only
  • 57cb3a6 Update ApplicationHost.cs
  • e34adc1 reverted change.
  • acc45b7 Update Jellyfin.Networking/Configuration/NetworkConfiguration.cs

📊 Changes

2 files changed (+22 additions, -3 deletions)

View changed files

📝 Emby.Dlna/Main/DlnaEntryPoint.cs (+21 -2)
📝 Jellyfin.Networking/Manager/NetworkManager.cs (+1 -1)

📄 Description

Section 4.5 of the DLNA specs.

Media transport defines how content travels across the home network. DLNA devices that source or receive media content across the home network must support HTTP as the baseline transport mechanism for the transfer of content. In addition, the RTP transport can optionally be used as a media transport; but the mandatory requirements for HTTP must always be supported.

10.7 supports DLNA over HTTPS, however, the spec doesn't! DLNA does not support HTTPS.

This PR restores this functionality.
DNLA only ever uses HTTP regardless of the system settings.

If RequireHttps is true, and a cert is successfully loading, and error is logged and the initialisation of the DLNA server is purposefully stopped, to save resources.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4729 **Author:** [@BaronGreenback](https://github.com/BaronGreenback) **Created:** 12/8/2020 **Status:** ✅ Merged **Merged:** 12/31/2020 **Merged by:** [@joshuaboniface](https://github.com/joshuaboniface) **Base:** `master` ← **Head:** `19.0RC---Fix-networkInterfaceFix` --- ### 📝 Commits (4) - [`d69f2d7`](https://github.com/jellyfin/jellyfin/commit/d69f2d7d7fd4209652878d84f811051e69fb45b2) DNLA over HTTP only - [`57cb3a6`](https://github.com/jellyfin/jellyfin/commit/57cb3a67bc12d6a7aa38e5a8b4df68bf631b5ffe) Update ApplicationHost.cs - [`e34adc1`](https://github.com/jellyfin/jellyfin/commit/e34adc12d9ab15fa5126e0c0e3a625cea7940e7f) reverted change. - [`acc45b7`](https://github.com/jellyfin/jellyfin/commit/acc45b7307d9b01a152ebc05e84f81e3672f2169) Update Jellyfin.Networking/Configuration/NetworkConfiguration.cs ### 📊 Changes **2 files changed** (+22 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Dlna/Main/DlnaEntryPoint.cs` (+21 -2) 📝 `Jellyfin.Networking/Manager/NetworkManager.cs` (+1 -1) </details> ### 📄 Description **Section 4.5 of the DLNA specs.** Media transport defines how content travels across the home network. DLNA devices that source or receive media content across the home network must support HTTP as the baseline transport mechanism for the transfer of content. In addition, the RTP transport can optionally be used as a media transport; but the mandatory requirements for **HTTP** must always be supported. 10.7 supports DLNA over HTTPS, however, the spec doesn't! DLNA does not support HTTPS. This PR restores this functionality. DNLA only ever uses HTTP regardless of the system settings. If RequireHttps is true, and a cert is successfully loading, and error is logged and the initialisation of the DLNA server is purposefully stopped, to save resources. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:16:46 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10249
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?