starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-05-04 18:09:12 +03:00
Code Issues 822 Packages Projects Releases 10 Wiki Activity

[PR #4721] [CLOSED] Remote sessions support for SyncPlay #10246

New Issue
Closed
opened 2026-02-07 06:16:42 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:16:42 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4721
Author: @OancaAndrei
Created: 12/7/2020
Status: ❌ Closed

Base: master ← Head: syncplay-remote-sessions

📝 Commits (6)

  • 4a823a1 Allow remote session to join and leave SyncPlay group
  • 9dc1faa Make property nullable for backwards compatibility
  • 851cb65 Reject sessions that don't support SyncPlay
  • 13c83fc Add missing response types to endpoints
  • aa7f3d5 Update Emby.Server.Implementations/Session/SessionManager.cs
  • c030e6f Merge branch 'master' into syncplay-remote-sessions

📊 Changes

8 files changed (+89 additions, -21 deletions)

View changed files

📝 Emby.Server.Implementations/Session/SessionManager.cs (+2 -11)
📝 Jellyfin.Api/Controllers/SessionController.cs (+5 -2)
📝 Jellyfin.Api/Controllers/SyncPlayController.cs (+40 -7)
📝 Jellyfin.Api/Models/SessionDtos/ClientCapabilitiesDto.cs (+7 -1)
📝 Jellyfin.Api/Models/SyncPlayDtos/JoinGroupRequestDto.cs (+6 -0)
➕ Jellyfin.Api/Models/SyncPlayDtos/LeaveGroupRequestDto.cs (+14 -0)
📝 MediaBrowser.Controller/Session/ISessionManager.cs (+13 -0)
📝 MediaBrowser.Model/Session/ClientCapabilities.cs (+2 -0)

📄 Description

Changes
Allows a session to enable SyncPlay on another session (only if the feature is supported).

jellyfin-web PR here.
jellyfin-apiclient-javascript PR here.

Issues
Related to #3855.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4721 **Author:** [@OancaAndrei](https://github.com/OancaAndrei) **Created:** 12/7/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `syncplay-remote-sessions` --- ### 📝 Commits (6) - [`4a823a1`](https://github.com/jellyfin/jellyfin/commit/4a823a1bada010336c68709560bd355a5b646a61) Allow remote session to join and leave SyncPlay group - [`9dc1faa`](https://github.com/jellyfin/jellyfin/commit/9dc1faad7c02fadde9fce8721cf81bd9ef396ac9) Make property nullable for backwards compatibility - [`851cb65`](https://github.com/jellyfin/jellyfin/commit/851cb650850bb85404f602b038ac9d83a55c2466) Reject sessions that don't support SyncPlay - [`13c83fc`](https://github.com/jellyfin/jellyfin/commit/13c83fc5ea0cb6a7fbc748f6340fd5edc5854789) Add missing response types to endpoints - [`aa7f3d5`](https://github.com/jellyfin/jellyfin/commit/aa7f3d58b65fd077e59ca72dc51682117488e0fa) Update Emby.Server.Implementations/Session/SessionManager.cs - [`c030e6f`](https://github.com/jellyfin/jellyfin/commit/c030e6f099f3891c0f5aed4814bed8a4027a5c38) Merge branch 'master' into syncplay-remote-sessions ### 📊 Changes **8 files changed** (+89 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Session/SessionManager.cs` (+2 -11) 📝 `Jellyfin.Api/Controllers/SessionController.cs` (+5 -2) 📝 `Jellyfin.Api/Controllers/SyncPlayController.cs` (+40 -7) 📝 `Jellyfin.Api/Models/SessionDtos/ClientCapabilitiesDto.cs` (+7 -1) 📝 `Jellyfin.Api/Models/SyncPlayDtos/JoinGroupRequestDto.cs` (+6 -0) ➕ `Jellyfin.Api/Models/SyncPlayDtos/LeaveGroupRequestDto.cs` (+14 -0) 📝 `MediaBrowser.Controller/Session/ISessionManager.cs` (+13 -0) 📝 `MediaBrowser.Model/Session/ClientCapabilities.cs` (+2 -0) </details> ### 📄 Description <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** Allows a session to enable SyncPlay on another session (only if the feature is supported). `jellyfin-web` PR [here](https://github.com/jellyfin/jellyfin-web/pull/2203). `jellyfin-apiclient-javascript` PR [here](https://github.com/jellyfin/jellyfin-apiclient-javascript/pull/94). **Issues** Related to #3855. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:16:42 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10246
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?