starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #4693] [CLOSED] Safer startup. #10227

New Issue
Closed
opened 2026-02-07 06:16:22 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:16:22 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4693
Author: @BaronGreenback
Created: 12/6/2020
Status: ❌ Closed

Base: master ← Head: startupFix

📝 Commits (3)

  • 02ca75f Update ApplicationHost.cs
  • 3652e95 Made it compile.
  • e959a89 Update Emby.Server.Implementations/ApplicationHost.cs

📊 Changes

1 file changed (+21 additions, -2 deletions)

View changed files

📝 Emby.Server.Implementations/ApplicationHost.cs (+21 -2)

📄 Description

It looks like it would be possible for a plugin to crash the system by generating an exception in their IServerEntryPoint implementation.

All methods are executed by a Task.WhenAll. According to the docs, this only reports the last error generated, and if i'm reading the code right, would crash.

This PR introduces another exception catching layer between the two. This should enable failed plugins to log exceptions without a crashing occurring.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4693 **Author:** [@BaronGreenback](https://github.com/BaronGreenback) **Created:** 12/6/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `startupFix` --- ### 📝 Commits (3) - [`02ca75f`](https://github.com/jellyfin/jellyfin/commit/02ca75f19c928f8dde162b055568748eac6f84d7) Update ApplicationHost.cs - [`3652e95`](https://github.com/jellyfin/jellyfin/commit/3652e9553016cfefe09c66b9f9eebce7aa28fc89) Made it compile. - [`e959a89`](https://github.com/jellyfin/jellyfin/commit/e959a89390204b5b28a75072e4c81c1fa5513984) Update Emby.Server.Implementations/ApplicationHost.cs ### 📊 Changes **1 file changed** (+21 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/ApplicationHost.cs` (+21 -2) </details> ### 📄 Description It looks like it would be possible for a plugin to crash the system by generating an exception in their IServerEntryPoint implementation. All methods are executed by a Task.WhenAll. According to the docs, this only reports the last error generated, and if i'm reading the code right, would crash. This PR introduces another exception catching layer between the two. This should enable failed plugins to log exceptions without a crashing occurring. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:16:22 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10227
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?