starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #4633] [MERGED] Use Guid as API parameter type where possible #10206

New Issue
Closed
opened 2026-02-07 06:15:57 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:15:57 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4633
Author: @crobibero
Created: 12/1/2020
Status: ✅ Merged
Merged: 12/3/2020
Merged by: @cvium

Base: master ← Head: guid-params

📝 Commits (6)

  • c083b29 Use Guid as API parameter type where possible
  • 821ad79 fix spacing
  • 2055d49 fix inverted condition
  • f48e47b Split nested conditional
  • b5a7a74 Use GetParentItem where applicable
  • 09b1e57 Apply suggestions from review

📊 Changes

23 files changed (+92 additions, -112 deletions)

View changed files

📝 Emby.Server.Implementations/Channels/ChannelManager.cs (+4 -4)
📝 Emby.Server.Implementations/Library/LibraryManager.cs (+12 -2)
📝 Emby.Server.Implementations/Library/SearchEngine.cs (+2 -2)
📝 Emby.Server.Implementations/TV/TVSeriesManager.cs (+2 -4)
📝 Jellyfin.Api/Controllers/ArtistsController.cs (+10 -21)
📝 Jellyfin.Api/Controllers/ChannelsController.cs (+1 -1)
📝 Jellyfin.Api/Controllers/FilterController.cs (+14 -22)
📝 Jellyfin.Api/Controllers/GenresController.cs (+4 -4)
📝 Jellyfin.Api/Controllers/ItemsController.cs (+6 -12)
📝 Jellyfin.Api/Controllers/LibraryController.cs (+1 -1)
📝 Jellyfin.Api/Controllers/MoviesController.cs (+2 -2)
📝 Jellyfin.Api/Controllers/MusicGenresController.cs (+4 -4)
📝 Jellyfin.Api/Controllers/PackageController.cs (+4 -4)
📝 Jellyfin.Api/Controllers/PersonsController.cs (+2 -2)
📝 Jellyfin.Api/Controllers/SearchController.cs (+1 -1)
📝 Jellyfin.Api/Controllers/StudiosController.cs (+4 -4)
📝 Jellyfin.Api/Controllers/TrailersController.cs (+1 -1)
📝 Jellyfin.Api/Controllers/TvShowsController.cs (+11 -11)
📝 Jellyfin.Api/Controllers/YearsController.cs (+2 -7)
📝 MediaBrowser.Controller/Channels/IChannelManager.cs (+1 -1)

...and 3 more files

📄 Description

No description provided

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4633 **Author:** [@crobibero](https://github.com/crobibero) **Created:** 12/1/2020 **Status:** ✅ Merged **Merged:** 12/3/2020 **Merged by:** [@cvium](https://github.com/cvium) **Base:** `master` ← **Head:** `guid-params` --- ### 📝 Commits (6) - [`c083b29`](https://github.com/jellyfin/jellyfin/commit/c083b29e292c72b65929ea05639e3b5a8a401037) Use Guid as API parameter type where possible - [`821ad79`](https://github.com/jellyfin/jellyfin/commit/821ad7999207faf273204500c8c1dcb73f9c3c83) fix spacing - [`2055d49`](https://github.com/jellyfin/jellyfin/commit/2055d49701a641726a8574460a3e1db6958d693b) fix inverted condition - [`f48e47b`](https://github.com/jellyfin/jellyfin/commit/f48e47be5fcd5d51a4001caa05f429cf92b4a8ed) Split nested conditional - [`b5a7a74`](https://github.com/jellyfin/jellyfin/commit/b5a7a74e897539a4f5389faca93bdfe5bfd5b4d5) Use GetParentItem where applicable - [`09b1e57`](https://github.com/jellyfin/jellyfin/commit/09b1e571f4e4dad19495e8873a5bc712a3bf9b7c) Apply suggestions from review ### 📊 Changes **23 files changed** (+92 additions, -112 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Channels/ChannelManager.cs` (+4 -4) 📝 `Emby.Server.Implementations/Library/LibraryManager.cs` (+12 -2) 📝 `Emby.Server.Implementations/Library/SearchEngine.cs` (+2 -2) 📝 `Emby.Server.Implementations/TV/TVSeriesManager.cs` (+2 -4) 📝 `Jellyfin.Api/Controllers/ArtistsController.cs` (+10 -21) 📝 `Jellyfin.Api/Controllers/ChannelsController.cs` (+1 -1) 📝 `Jellyfin.Api/Controllers/FilterController.cs` (+14 -22) 📝 `Jellyfin.Api/Controllers/GenresController.cs` (+4 -4) 📝 `Jellyfin.Api/Controllers/ItemsController.cs` (+6 -12) 📝 `Jellyfin.Api/Controllers/LibraryController.cs` (+1 -1) 📝 `Jellyfin.Api/Controllers/MoviesController.cs` (+2 -2) 📝 `Jellyfin.Api/Controllers/MusicGenresController.cs` (+4 -4) 📝 `Jellyfin.Api/Controllers/PackageController.cs` (+4 -4) 📝 `Jellyfin.Api/Controllers/PersonsController.cs` (+2 -2) 📝 `Jellyfin.Api/Controllers/SearchController.cs` (+1 -1) 📝 `Jellyfin.Api/Controllers/StudiosController.cs` (+4 -4) 📝 `Jellyfin.Api/Controllers/TrailersController.cs` (+1 -1) 📝 `Jellyfin.Api/Controllers/TvShowsController.cs` (+11 -11) 📝 `Jellyfin.Api/Controllers/YearsController.cs` (+2 -7) 📝 `MediaBrowser.Controller/Channels/IChannelManager.cs` (+1 -1) _...and 3 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:15:57 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10206
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?