starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #4611] [CLOSED] Enable Nullable for Jellyfin #10187

New Issue
Closed
opened 2026-02-07 06:15:39 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:15:39 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4611
Author: @martinek-stepan
Created: 11/28/2020
Status: ❌ Closed

Base: master ← Head: nullable

📝 Commits (10+)

  • d5b37c4 Enable nullable for MediaBrowser.XbmcMetadata project
  • 411c997 Enable nullable for DvdLib project & simplify Cell parsing (instead of parsing twice and skipping parsed position bytes, parse in order once.
  • bcf6278 Create ProgramChainBuilder to safely allow late-initialization of several ProgramChain properties.
  • da8d20f Make EntryProgramChain optional (nullable) as it is only assigned if dvd enables it.
  • 3e6cb15 Enable nullable for RSSDP project
  • f8c589d Enable nullable for MediaBrowser.Providers project
  • 257596d Enable nullable in MediaBrowser.Controller project.
  • 1569b81 Enable nullable from MediaBrowser.Common project.
  • 6f8fe26 Enable nullable for Jellyfin.Server.Implementations project. (Nullable disabled for DbSet in JellyfinDb)
  • faebcc6 Enable nullable from Jellyfin.Data project.

📊 Changes

282 files changed (+1820 additions, -1294 deletions)

View changed files

📝 DvdLib/DvdLib.csproj (+1 -0)
📝 DvdLib/Ifo/Cell.cs (+5 -9)
📝 DvdLib/Ifo/CellPlaybackInfo.cs (+0 -1)
📝 DvdLib/Ifo/ProgramChain.cs (+15 -16)
➕ DvdLib/Ifo/ProgramChainBuilder.cs (+24 -0)
📝 DvdLib/Ifo/Title.cs (+2 -3)
📝 Emby.Dlna/Configuration/DlnaOptions.cs (+1 -1)
📝 Emby.Dlna/ConfigurationExtension.cs (+0 -1)
📝 Emby.Dlna/ContentDirectory/ContentDirectoryService.cs (+7 -1)
📝 Emby.Dlna/ContentDirectory/ControlHandler.cs (+17 -9)
📝 Emby.Dlna/ControlRequest.cs (+4 -1)
📝 Emby.Dlna/ControlResponse.cs (+3 -1)
📝 Emby.Dlna/Didl/DidlBuilder.cs (+30 -25)
📝 Emby.Dlna/Didl/StringWriterWithEncoding.cs (+1 -1)
📝 Emby.Dlna/DlnaConfigurationFactory.cs (+1 -6)
📝 Emby.Dlna/DlnaManager.cs (+17 -14)
📝 Emby.Dlna/Emby.Dlna.csproj (+1 -0)
📝 Emby.Dlna/EventSubscriptionResponse.cs (+3 -1)
📝 Emby.Dlna/Eventing/DlnaEventManager.cs (+7 -25)
📝 Emby.Dlna/Eventing/EventSubscription.cs (+10 -1)

...and 80 more files

📄 Description

Changes

Enables nullable for remaining projects and reflected syntax for the change. Most of the behaviour is unchanged.

Issues

Closes #2768

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4611 **Author:** [@martinek-stepan](https://github.com/martinek-stepan) **Created:** 11/28/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `nullable` --- ### 📝 Commits (10+) - [`d5b37c4`](https://github.com/jellyfin/jellyfin/commit/d5b37c4d9da2e2426402c39393af41b77a6af2f6) Enable nullable for MediaBrowser.XbmcMetadata project - [`411c997`](https://github.com/jellyfin/jellyfin/commit/411c997737a3e96d5387f9b036db39cb809801c3) Enable nullable for DvdLib project & simplify Cell parsing (instead of parsing twice and skipping parsed position bytes, parse in order once. - [`bcf6278`](https://github.com/jellyfin/jellyfin/commit/bcf62787f67c99d3ecb20a69be045bfc390f36a2) Create ProgramChainBuilder to safely allow late-initialization of several ProgramChain properties. - [`da8d20f`](https://github.com/jellyfin/jellyfin/commit/da8d20f3d83f51dd663a60ee8a8082df627549de) Make EntryProgramChain optional (nullable) as it is only assigned if dvd enables it. - [`3e6cb15`](https://github.com/jellyfin/jellyfin/commit/3e6cb15a25c21db1c79719f1f9ad2716ce74f053) Enable nullable for RSSDP project - [`f8c589d`](https://github.com/jellyfin/jellyfin/commit/f8c589dba6474260999ba814b2b36fd6257b5fe2) Enable nullable for MediaBrowser.Providers project - [`257596d`](https://github.com/jellyfin/jellyfin/commit/257596dee266f099ea22d1c3eb0f48b72a02f038) Enable nullable in MediaBrowser.Controller project. - [`1569b81`](https://github.com/jellyfin/jellyfin/commit/1569b81698367208a0ccc6bf9ff482b97c2c1725) Enable nullable from MediaBrowser.Common project. - [`6f8fe26`](https://github.com/jellyfin/jellyfin/commit/6f8fe26b16258474f60f40c08055c7ffc4d08b8c) Enable nullable for Jellyfin.Server.Implementations project. (Nullable disabled for DbSet<T> in JellyfinDb) - [`faebcc6`](https://github.com/jellyfin/jellyfin/commit/faebcc6e1fc50e524a3261847774e64ea6f3d6bb) Enable nullable from Jellyfin.Data project. ### 📊 Changes **282 files changed** (+1820 additions, -1294 deletions) <details> <summary>View changed files</summary> 📝 `DvdLib/DvdLib.csproj` (+1 -0) 📝 `DvdLib/Ifo/Cell.cs` (+5 -9) 📝 `DvdLib/Ifo/CellPlaybackInfo.cs` (+0 -1) 📝 `DvdLib/Ifo/ProgramChain.cs` (+15 -16) ➕ `DvdLib/Ifo/ProgramChainBuilder.cs` (+24 -0) 📝 `DvdLib/Ifo/Title.cs` (+2 -3) 📝 `Emby.Dlna/Configuration/DlnaOptions.cs` (+1 -1) 📝 `Emby.Dlna/ConfigurationExtension.cs` (+0 -1) 📝 `Emby.Dlna/ContentDirectory/ContentDirectoryService.cs` (+7 -1) 📝 `Emby.Dlna/ContentDirectory/ControlHandler.cs` (+17 -9) 📝 `Emby.Dlna/ControlRequest.cs` (+4 -1) 📝 `Emby.Dlna/ControlResponse.cs` (+3 -1) 📝 `Emby.Dlna/Didl/DidlBuilder.cs` (+30 -25) 📝 `Emby.Dlna/Didl/StringWriterWithEncoding.cs` (+1 -1) 📝 `Emby.Dlna/DlnaConfigurationFactory.cs` (+1 -6) 📝 `Emby.Dlna/DlnaManager.cs` (+17 -14) 📝 `Emby.Dlna/Emby.Dlna.csproj` (+1 -0) 📝 `Emby.Dlna/EventSubscriptionResponse.cs` (+3 -1) 📝 `Emby.Dlna/Eventing/DlnaEventManager.cs` (+7 -25) 📝 `Emby.Dlna/Eventing/EventSubscription.cs` (+10 -1) _...and 80 more files_ </details> ### 📄 Description <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** <!-- Describe your changes here in 1-5 sentences. --> Enables nullable for remaining projects and reflected syntax for the change. Most of the behaviour is unchanged. **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> Closes #2768 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:15:39 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10187
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?