starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #4607] [MERGED] Fix the I-frame image extraction filter string #10182

New Issue
Closed
opened 2026-02-07 06:15:34 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:15:34 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4607
Author: @nyanmisaka
Created: 11/28/2020
Status: ✅ Merged
Merged: 11/30/2020
Merged by: @Bond-009

Base: master ← Head: fix-image-extraction

📝 Commits (6)

  • d19edef fix image extraction
  • 53c91c2 Apply suggestions from code review
  • d72f349 fix ci
  • 0c6efe6 Apply suggestions from code review
  • bb16174 increase the default image extraction timeout
  • 92118c2 allow to extract music bitrate info from formatInfo

📊 Changes

2 files changed (+19 additions, -6 deletions)

View changed files

📝 MediaBrowser.MediaEncoding/Encoder/MediaEncoder.cs (+14 -5)
📝 MediaBrowser.MediaEncoding/Probing/ProbeResultNormalizer.cs (+5 -1)

📄 Description

Changes

  • Fix the wrong I-frame image extraction filter string introduced in #4501
  • Increase DefaultImageExtractionTimeout since the default scale width 600 have been removed.
    Otherwise the ffmpeg process will be stopped prematurely when extracting image for high resolution videos.
  • Allow to extract music bitrate info from formatInfo.

Issues

-f mov,mp4,m4a,3gp,3g2,mj2 -ss 00:00:30.025 -i file:"h264High10.mp4" -threads 0 -v quiet -vframes 1 ,thumbnail=24 -f image2 "69b6b099-dad0-4e98-b043-9c92a23fe2e8.jpg"

Fixes https://github.com/jellyfin/jellyfin/issues/4617

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4607 **Author:** [@nyanmisaka](https://github.com/nyanmisaka) **Created:** 11/28/2020 **Status:** ✅ Merged **Merged:** 11/30/2020 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `fix-image-extraction` --- ### 📝 Commits (6) - [`d19edef`](https://github.com/jellyfin/jellyfin/commit/d19edefbcd020e58031c8bf1101bf20328257303) fix image extraction - [`53c91c2`](https://github.com/jellyfin/jellyfin/commit/53c91c2c145535f40f391f1b8d986078f10e3428) Apply suggestions from code review - [`d72f349`](https://github.com/jellyfin/jellyfin/commit/d72f3498bf2c53be0dfb900feba58d84efbffde0) fix ci - [`0c6efe6`](https://github.com/jellyfin/jellyfin/commit/0c6efe6317d1682ba71b751686360124eda41de9) Apply suggestions from code review - [`bb16174`](https://github.com/jellyfin/jellyfin/commit/bb16174936dca01812d3dc92e6728847bf994b20) increase the default image extraction timeout - [`92118c2`](https://github.com/jellyfin/jellyfin/commit/92118c2129ec8175665e65dcd78c1400fbe60c80) allow to extract music bitrate info from formatInfo ### 📊 Changes **2 files changed** (+19 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.MediaEncoding/Encoder/MediaEncoder.cs` (+14 -5) 📝 `MediaBrowser.MediaEncoding/Probing/ProbeResultNormalizer.cs` (+5 -1) </details> ### 📄 Description **Changes** - Fix the wrong I-frame image extraction filter string introduced in #4501 - Increase `DefaultImageExtractionTimeout` since the default scale width 600 have been removed. Otherwise the ffmpeg process will be stopped prematurely when extracting image for high resolution videos. - Allow to extract music bitrate info from formatInfo. **Issues** ``` -f mov,mp4,m4a,3gp,3g2,mj2 -ss 00:00:30.025 -i file:"h264High10.mp4" -threads 0 -v quiet -vframes 1 ,thumbnail=24 -f image2 "69b6b099-dad0-4e98-b043-9c92a23fe2e8.jpg" ``` Fixes https://github.com/jellyfin/jellyfin/issues/4617 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:15:34 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10182
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?