starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #4580] [MERGED] Specify default DateTimeKind from EFCore #10170

New Issue
Closed
opened 2026-02-07 06:15:18 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:15:18 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4580
Author: @crobibero
Created: 11/25/2020
Status: ✅ Merged
Merged: 12/2/2020
Merged by: @cvium

Base: master ← Head: efcore-datetime

📝 Commits (1)

  • 6c0188c Fix efcore not returning a UTC DateTime

📊 Changes

5 files changed (+71 additions, -25 deletions)

View changed files

📝 Jellyfin.Server.Implementations/JellyfinDb.cs (+2 -0)
➕ Jellyfin.Server.Implementations/ModelBuilderExtensions.cs (+48 -0)
➕ Jellyfin.Server.Implementations/ValueConverters/DateTimeKindValueConverter.cs (+21 -0)
➖ MediaBrowser.Common/Json/Converters/JsonDateTimeIso8601Converter.cs (+0 -24)
📝 MediaBrowser.Common/Json/JsonDefaults.cs (+0 -1)

📄 Description

Upon further investigation the DateTime wasn't being specified as UTC when coming from efcore, and ASP.NET already returns DateTime in ISO8601 format.
Current workaround from https://github.com/dotnet/efcore/issues/10784

Fixes https://github.com/jellyfin/jellyfin/issues/4577

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4580 **Author:** [@crobibero](https://github.com/crobibero) **Created:** 11/25/2020 **Status:** ✅ Merged **Merged:** 12/2/2020 **Merged by:** [@cvium](https://github.com/cvium) **Base:** `master` ← **Head:** `efcore-datetime` --- ### 📝 Commits (1) - [`6c0188c`](https://github.com/jellyfin/jellyfin/commit/6c0188c42be9bcb5581b0e18d8230c91928c0e41) Fix efcore not returning a UTC DateTime ### 📊 Changes **5 files changed** (+71 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Server.Implementations/JellyfinDb.cs` (+2 -0) ➕ `Jellyfin.Server.Implementations/ModelBuilderExtensions.cs` (+48 -0) ➕ `Jellyfin.Server.Implementations/ValueConverters/DateTimeKindValueConverter.cs` (+21 -0) ➖ `MediaBrowser.Common/Json/Converters/JsonDateTimeIso8601Converter.cs` (+0 -24) 📝 `MediaBrowser.Common/Json/JsonDefaults.cs` (+0 -1) </details> ### 📄 Description Upon further investigation the DateTime wasn't being specified as UTC when coming from efcore, and ASP.NET already returns DateTime in ISO8601 format. Current workaround from https://github.com/dotnet/efcore/issues/10784 Fixes https://github.com/jellyfin/jellyfin/issues/4577 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:15:18 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10170
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?