[PR #4572] [CLOSED] Networking Phase 2: Code commenting and optimization and a fix #10164

New Issue

OVERLORD · 2026-02-07T06:15:13+03:00

OVERLORD commented

2026-02-07 06:15:13 +03:00

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4572
Author: @BaronGreenback
Created: 11/24/2020
Status: ❌ Closed

Base: master ← Head: NetworkPhase2_DidlComments

📝 Commits (4)

5f61171 Add comments to didl & small optimization.
7aa869d Update DidlBuilder.cs
720b9f5 Update Utf8StringWriter.cs
869158a Commented.

📊 Changes

7 files changed (+365 additions, -73 deletions)

View changed files

📝 Emby.Dlna/Configuration/DlnaOptions.cs (+16 -6)
📝 Emby.Dlna/ContentDirectory/ControlHandler.cs (+2 -1)
📝 Emby.Dlna/Didl/DidlBuilder.cs (+312 -62)
📝 Emby.Dlna/Didl/Filter.cs (+15 -2)
➕ Emby.Dlna/Didl/Utf8StringWriter.cs (+16 -0)
📝 Emby.Dlna/PlayTo/PlayToController.cs (+2 -1)
📝 Emby.Dlna/Service/BaseControlHandler.cs (+2 -1)

📄 Description

No new functionality.

Fixed: DLNA Debug output is now unescaped and html decoded, making it actually useful!

Added comments to dlna didl class.
Some static methods as recommended.
Added Utf8StringWriter to replace StringWriterWithEncoding.cs.
Got rid of a TODO.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4572 **Author:** [@BaronGreenback](https://github.com/BaronGreenback) **Created:** 11/24/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `NetworkPhase2_DidlComments` --- ### 📝 Commits (4) - [`5f61171`](https://github.com/jellyfin/jellyfin/commit/5f61171d6ab046569881cfe4c92eb543fd23045e) Add comments to didl & small optimization. - [`7aa869d`](https://github.com/jellyfin/jellyfin/commit/7aa869dd89088c146bd01354215da091425dc6fe) Update DidlBuilder.cs - [`720b9f5`](https://github.com/jellyfin/jellyfin/commit/720b9f54f7dca2e3f7d4f8b1e86d5860994e41bf) Update Utf8StringWriter.cs - [`869158a`](https://github.com/jellyfin/jellyfin/commit/869158af41670c92752f87e319807075afd9293f) Commented. ### 📊 Changes **7 files changed** (+365 additions, -73 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Dlna/Configuration/DlnaOptions.cs` (+16 -6) 📝 `Emby.Dlna/ContentDirectory/ControlHandler.cs` (+2 -1) 📝 `Emby.Dlna/Didl/DidlBuilder.cs` (+312 -62) 📝 `Emby.Dlna/Didl/Filter.cs` (+15 -2) ➕ `Emby.Dlna/Didl/Utf8StringWriter.cs` (+16 -0) 📝 `Emby.Dlna/PlayTo/PlayToController.cs` (+2 -1) 📝 `Emby.Dlna/Service/BaseControlHandler.cs` (+2 -1) </details> ### 📄 Description No new functionality. Fixed: DLNA Debug output is now unescaped and html decoded, making it actually useful! Added comments to dlna didl class. Some static methods as recommended. Added Utf8StringWriter to replace StringWriterWithEncoding.cs. Got rid of a TODO. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-07 06:15:13 +03:00

OVERLORD closed this issue

2026-02-07 06:15:14 +03:00

Sign in to join this conversation.

Branches Tags

master

renovate/major-skiasharp-monorepo

renovate/sharpcompress-0.x

renovate/svg.skia-5.x

renovate/ghcr.io-devcontainers-features-docker-in-docker-4.x

release-10.11.z

standards-fix

release-10.9.z

openapi-cache

release-10.10.z

explicit-load

explicit-load-v2

feature/entity-framework

only-count-folder-item

fix/ci-workflow-refactor

release-10.8.z

release-10.7.z

EraYaN-add-management-interface

release-10.6.z

release-10.5.z

release-10.4.z

release-10.3.z

release-10.2.z

release-10.1.0

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#10164