mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-07-16 05:43:54 +03:00
[PR #4548] [MERGED] Revert "Fix frame rate probing for interlaced MKV files" #10154
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/jellyfin/jellyfin/pull/4548
Author: @orryverducci
Created: 11/22/2020
Status: ✅ Merged
Merged: 11/22/2020
Merged by: @joshuaboniface
Base:
master← Head:mkv-interlaced-fix📝 Commits (1)
812300aRevert "Fix frame rate probing for interlaced MKV files"📊 Changes
1 file changed (+0 additions, -10 deletions)
View changed files
📝
MediaBrowser.MediaEncoding/Probing/ProbeResultNormalizer.cs(+0 -10)📄 Description
Changes
This reverts the change I made in #4369.
On further testing I've descovered that while the fix corrected the displayed frame rate for some interlaced MKV files (mainly recorded from broadcast TV), it also incorrectly halfed the displayed frame rate for some others (mainly encoded by FFmpeg/x264).
I also discovered that for the "fixed" files, with double rate deinterlacing enabled FFmpeg is really dumb and will double the rate based on the it's incorrectly reported frame rate. So for example a 50i file is deinterlaced to 100fps, not 50fps as intended. Reverting this fix prevents that and results in a deinterlaced file at a sensible/correct frame rate, just with double rate disabled.
As the first fix creates more bugs than it fixes, I feel it's best to revert it for now until there's a better fix (which may have to be in FFmpeg, not Jellyfin). #4314 should also be reopened.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.