starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #4526] [MERGED] Fix marking item as played #10132

New Issue
Closed
opened 2026-02-07 06:14:40 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:14:40 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4526
Author: @crobibero
Created: 11/20/2020
Status: ✅ Merged
Merged: 11/22/2020
Merged by: @joshuaboniface

Base: master ← Head: mark-played

📝 Commits (1)

  • 2f75f84 Fix marking item as played

📊 Changes

4 files changed (+51 additions, -51 deletions)

View changed files

📝 Jellyfin.Api/Controllers/PlaystateController.cs (+2 -1)
➕ Jellyfin.Api/ModelBinders/LegacyDateTimeModelBinder.cs (+49 -0)
➖ Jellyfin.Api/TypeConverters/DateTimeTypeConverter.cs (+0 -44)
📝 Jellyfin.Server/Startup.cs (+0 -6)

📄 Description

The TypeConverter stopped working when we migrated to .net5. Thankfully there was only 1 endpoint that sends a DateTime in this format.

Fixes https://github.com/jellyfin/jellyfin-web/issues/2087

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4526 **Author:** [@crobibero](https://github.com/crobibero) **Created:** 11/20/2020 **Status:** ✅ Merged **Merged:** 11/22/2020 **Merged by:** [@joshuaboniface](https://github.com/joshuaboniface) **Base:** `master` ← **Head:** `mark-played` --- ### 📝 Commits (1) - [`2f75f84`](https://github.com/jellyfin/jellyfin/commit/2f75f84b6f7d21e9337ee597f8367266a13a27a6) Fix marking item as played ### 📊 Changes **4 files changed** (+51 additions, -51 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Api/Controllers/PlaystateController.cs` (+2 -1) ➕ `Jellyfin.Api/ModelBinders/LegacyDateTimeModelBinder.cs` (+49 -0) ➖ `Jellyfin.Api/TypeConverters/DateTimeTypeConverter.cs` (+0 -44) 📝 `Jellyfin.Server/Startup.cs` (+0 -6) </details> ### 📄 Description The `TypeConverter` stopped working when we migrated to .net5. Thankfully there was only 1 endpoint that sends a `DateTime` in this format. Fixes https://github.com/jellyfin/jellyfin-web/issues/2087 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:14:40 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10132
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?