starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #4516] [MERGED] Fix plugin old version cleanup #10131

New Issue
Closed
opened 2026-02-07 06:14:36 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:14:36 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4516
Author: @oddstr13
Created: 11/19/2020
Status: ✅ Merged
Merged: 11/19/2020
Merged by: @cvium

Base: master ← Head: fix-plugin-cleanup

📝 Commits (1)

  • f8dd50f Fix plugin old version cleanup

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 Emby.Server.Implementations/ApplicationHost.cs (+2 -1)

📄 Description

Not repeatedly deleting the version we want is a good start 😄

Nov 19 15:07:41 1070L jellyfin[11185]: [15:07:41] [INF] Loading assemblies
Nov 19 15:07:41 1070L jellyfin[11185]: [15:07:41] [DBG] Anime 11.2020.1119.1145 /var/lib/jellyfin/plugins/Anime_11.2020.1119.1145
Nov 19 15:07:41 1070L jellyfin[11185]: [15:07:41] [DBG] Anime 11.2020.1119.1152 /var/lib/jellyfin/plugins/Anime_11.2020.1119.1152
Nov 19 15:07:41 1070L jellyfin[11185]: [15:07:41] [DBG] Anime 11.2020.1119.1246 /var/lib/jellyfin/plugins/Anime_11.2020.1119.1246
Nov 19 15:07:41 1070L jellyfin[11185]: [15:07:41] [DBG] Anime 11.2020.1119.1306 /var/lib/jellyfin/plugins/Anime_11.2020.1119.1306
Nov 19 15:07:41 1070L jellyfin[11185]: [15:07:41] [DBG] Playback Reporting 9.2020.1119.705 /var/lib/jellyfin/plugins/Playback Reporting_9.2020.1119.705
Nov 19 15:07:41 1070L jellyfin[11185]: [15:07:41] [DBG] Deleting /var/lib/jellyfin/plugins/Anime_11.2020.1119.1306
Nov 19 15:07:41 1070L jellyfin[11185]: [15:07:41] [DBG] Deleting /var/lib/jellyfin/plugins/Anime_11.2020.1119.1306
Nov 19 15:07:41 1070L jellyfin[11185]: [15:07:41] [WRN] Unable to delete /var/lib/jellyfin/plugins/Anime_11.2020.1119.1306
Nov 19 15:07:41 1070L jellyfin[11185]: System.IO.DirectoryNotFoundException: Could not find a part of the path '/var/lib/jellyfin/plugins/Anime_11.2020.1119.1306'.
Nov 19 15:07:41 1070L jellyfin[11185]:    at System.IO.FileSystem.RemoveDirectory(String fullPath, Boolean recursive)
Nov 19 15:07:41 1070L jellyfin[11185]:    at Emby.Server.Implementations.ApplicationHost.GetLocalPlugins(String path, Boolean cleanup)
Nov 19 15:07:41 1070L jellyfin[11185]: [15:07:41] [DBG] Deleting /var/lib/jellyfin/plugins/Anime_11.2020.1119.1306
Nov 19 15:07:41 1070L jellyfin[11185]: [15:07:41] [WRN] Unable to delete /var/lib/jellyfin/plugins/Anime_11.2020.1119.1306
Nov 19 15:07:41 1070L jellyfin[11185]: System.IO.DirectoryNotFoundException: Could not find a part of the path '/var/lib/jellyfin/plugins/Anime_11.2020.1119.1306'.
Nov 19 15:07:41 1070L jellyfin[11185]:    at System.IO.FileSystem.RemoveDirectory(String fullPath, Boolean recursive)
Nov 19 15:07:41 1070L jellyfin[11185]:    at Emby.Server.Implementations.ApplicationHost.GetLocalPlugins(String path, Boolean cleanup)
Nov 19 15:07:41 1070L jellyfin[11185]: [15:07:41] [FTL] Error while starting server.
Nov 19 15:07:41 1070L jellyfin[11185]: System.IO.FileNotFoundException: Could not load file or assembly '/var/lib/jellyfin/plugins/Anime_11.2020.1119.1306/Jellyfin.Plugin.Anime.dll'. The system cannot find the file specified.
Nov 19 15:07:41 1070L jellyfin[11185]: File name: '/var/lib/jellyfin/plugins/Anime_11.2020.1119.1306/Jellyfin.Plugin.Anime.dll'
Nov 19 15:07:41 1070L jellyfin[11185]:    at System.Runtime.Loader.AssemblyLoadContext.LoadFromPath(IntPtr ptrNativeAssemblyLoadContext, String ilPath, String niPath, ObjectHandleOnStack retAssembly)
Nov 19 15:07:41 1070L jellyfin[11185]:    at System.Runtime.Loader.AssemblyLoadContext.LoadFromAssemblyPath(String assemblyPath)
Nov 19 15:07:41 1070L jellyfin[11185]:    at System.Reflection.Assembly.LoadFrom(String assemblyFile)
Nov 19 15:07:41 1070L jellyfin[11185]:    at Emby.Server.Implementations.ApplicationHost.GetComposablePartAssemblies()+MoveNext()
Nov 19 15:07:41 1070L jellyfin[11185]:    at Emby.Server.Implementations.ApplicationHost.GetTypes(IEnumerable`1 assemblies)+MoveNext()
Nov 19 15:07:41 1070L jellyfin[11185]:    at System.Collections.Generic.LargeArrayBuilder`1.AddRange(IEnumerable`1 items)
Nov 19 15:07:41 1070L jellyfin[11185]:    at System.Collections.Generic.EnumerableHelpers.ToArray[T](IEnumerable`1 source)
Nov 19 15:07:41 1070L jellyfin[11185]:    at System.Linq.Enumerable.ToArray[TSource](IEnumerable`1 source)
Nov 19 15:07:41 1070L jellyfin[11185]:    at Emby.Server.Implementations.ApplicationHost.DiscoverTypes()
Nov 19 15:07:41 1070L jellyfin[11185]:    at Emby.Server.Implementations.ApplicationHost.Init()
Nov 19 15:07:41 1070L jellyfin[11185]:    at Jellyfin.Server.Program.StartApp(StartupOptions options)
Nov 19 15:07:41 1070L jellyfin[11185]: [15:07:41] [INF] Disposing CoreAppHost
Nov 19 15:07:41 1070L jellyfin[11185]: [15:07:41] [INF] Received a SIGTERM signal, shutting down

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4516 **Author:** [@oddstr13](https://github.com/oddstr13) **Created:** 11/19/2020 **Status:** ✅ Merged **Merged:** 11/19/2020 **Merged by:** [@cvium](https://github.com/cvium) **Base:** `master` ← **Head:** `fix-plugin-cleanup` --- ### 📝 Commits (1) - [`f8dd50f`](https://github.com/jellyfin/jellyfin/commit/f8dd50fc1ae434be61f0ffb9519a40d5d6448df1) Fix plugin old version cleanup ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/ApplicationHost.cs` (+2 -1) </details> ### 📄 Description Not repeatedly deleting the version we want is a good start :smile: ```csharp Nov 19 15:07:41 1070L jellyfin[11185]: [15:07:41] [INF] Loading assemblies Nov 19 15:07:41 1070L jellyfin[11185]: [15:07:41] [DBG] Anime 11.2020.1119.1145 /var/lib/jellyfin/plugins/Anime_11.2020.1119.1145 Nov 19 15:07:41 1070L jellyfin[11185]: [15:07:41] [DBG] Anime 11.2020.1119.1152 /var/lib/jellyfin/plugins/Anime_11.2020.1119.1152 Nov 19 15:07:41 1070L jellyfin[11185]: [15:07:41] [DBG] Anime 11.2020.1119.1246 /var/lib/jellyfin/plugins/Anime_11.2020.1119.1246 Nov 19 15:07:41 1070L jellyfin[11185]: [15:07:41] [DBG] Anime 11.2020.1119.1306 /var/lib/jellyfin/plugins/Anime_11.2020.1119.1306 Nov 19 15:07:41 1070L jellyfin[11185]: [15:07:41] [DBG] Playback Reporting 9.2020.1119.705 /var/lib/jellyfin/plugins/Playback Reporting_9.2020.1119.705 Nov 19 15:07:41 1070L jellyfin[11185]: [15:07:41] [DBG] Deleting /var/lib/jellyfin/plugins/Anime_11.2020.1119.1306 Nov 19 15:07:41 1070L jellyfin[11185]: [15:07:41] [DBG] Deleting /var/lib/jellyfin/plugins/Anime_11.2020.1119.1306 Nov 19 15:07:41 1070L jellyfin[11185]: [15:07:41] [WRN] Unable to delete /var/lib/jellyfin/plugins/Anime_11.2020.1119.1306 Nov 19 15:07:41 1070L jellyfin[11185]: System.IO.DirectoryNotFoundException: Could not find a part of the path '/var/lib/jellyfin/plugins/Anime_11.2020.1119.1306'. Nov 19 15:07:41 1070L jellyfin[11185]: at System.IO.FileSystem.RemoveDirectory(String fullPath, Boolean recursive) Nov 19 15:07:41 1070L jellyfin[11185]: at Emby.Server.Implementations.ApplicationHost.GetLocalPlugins(String path, Boolean cleanup) Nov 19 15:07:41 1070L jellyfin[11185]: [15:07:41] [DBG] Deleting /var/lib/jellyfin/plugins/Anime_11.2020.1119.1306 Nov 19 15:07:41 1070L jellyfin[11185]: [15:07:41] [WRN] Unable to delete /var/lib/jellyfin/plugins/Anime_11.2020.1119.1306 Nov 19 15:07:41 1070L jellyfin[11185]: System.IO.DirectoryNotFoundException: Could not find a part of the path '/var/lib/jellyfin/plugins/Anime_11.2020.1119.1306'. Nov 19 15:07:41 1070L jellyfin[11185]: at System.IO.FileSystem.RemoveDirectory(String fullPath, Boolean recursive) Nov 19 15:07:41 1070L jellyfin[11185]: at Emby.Server.Implementations.ApplicationHost.GetLocalPlugins(String path, Boolean cleanup) Nov 19 15:07:41 1070L jellyfin[11185]: [15:07:41] [FTL] Error while starting server. Nov 19 15:07:41 1070L jellyfin[11185]: System.IO.FileNotFoundException: Could not load file or assembly '/var/lib/jellyfin/plugins/Anime_11.2020.1119.1306/Jellyfin.Plugin.Anime.dll'. The system cannot find the file specified. Nov 19 15:07:41 1070L jellyfin[11185]: File name: '/var/lib/jellyfin/plugins/Anime_11.2020.1119.1306/Jellyfin.Plugin.Anime.dll' Nov 19 15:07:41 1070L jellyfin[11185]: at System.Runtime.Loader.AssemblyLoadContext.LoadFromPath(IntPtr ptrNativeAssemblyLoadContext, String ilPath, String niPath, ObjectHandleOnStack retAssembly) Nov 19 15:07:41 1070L jellyfin[11185]: at System.Runtime.Loader.AssemblyLoadContext.LoadFromAssemblyPath(String assemblyPath) Nov 19 15:07:41 1070L jellyfin[11185]: at System.Reflection.Assembly.LoadFrom(String assemblyFile) Nov 19 15:07:41 1070L jellyfin[11185]: at Emby.Server.Implementations.ApplicationHost.GetComposablePartAssemblies()+MoveNext() Nov 19 15:07:41 1070L jellyfin[11185]: at Emby.Server.Implementations.ApplicationHost.GetTypes(IEnumerable`1 assemblies)+MoveNext() Nov 19 15:07:41 1070L jellyfin[11185]: at System.Collections.Generic.LargeArrayBuilder`1.AddRange(IEnumerable`1 items) Nov 19 15:07:41 1070L jellyfin[11185]: at System.Collections.Generic.EnumerableHelpers.ToArray[T](IEnumerable`1 source) Nov 19 15:07:41 1070L jellyfin[11185]: at System.Linq.Enumerable.ToArray[TSource](IEnumerable`1 source) Nov 19 15:07:41 1070L jellyfin[11185]: at Emby.Server.Implementations.ApplicationHost.DiscoverTypes() Nov 19 15:07:41 1070L jellyfin[11185]: at Emby.Server.Implementations.ApplicationHost.Init() Nov 19 15:07:41 1070L jellyfin[11185]: at Jellyfin.Server.Program.StartApp(StartupOptions options) Nov 19 15:07:41 1070L jellyfin[11185]: [15:07:41] [INF] Disposing CoreAppHost Nov 19 15:07:41 1070L jellyfin[11185]: [15:07:41] [INF] Received a SIGTERM signal, shutting down ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:14:36 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10131
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?