[PR #4477] [MERGED] Fix return type for GetAttachment #10101

Closed
opened 2026-02-07 06:14:07 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4477
Author: @nyanmisaka
Created: 11/14/2020
Status: Merged
Merged: 11/14/2020
Merged by: @cvium

Base: masterHead: attachment-return-type


📝 Commits (1)

  • e367250 fix return type for GetAttachment

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 Jellyfin.Api/Controllers/VideoAttachmentsController.cs (+1 -1)

📄 Description

Changes

  • fix return type for GetAttachment

Issues
It throws a type error that make SubtitlesOctopus to fail when fetching embedded subtitles or fonts.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4477 **Author:** [@nyanmisaka](https://github.com/nyanmisaka) **Created:** 11/14/2020 **Status:** ✅ Merged **Merged:** 11/14/2020 **Merged by:** [@cvium](https://github.com/cvium) **Base:** `master` ← **Head:** `attachment-return-type` --- ### 📝 Commits (1) - [`e367250`](https://github.com/jellyfin/jellyfin/commit/e36725096afd0287c6aa8b19e6612649836f3e1e) fix return type for GetAttachment ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Api/Controllers/VideoAttachmentsController.cs` (+1 -1) </details> ### 📄 Description **Changes** * fix return type for GetAttachment **Issues** It throws a type error that make SubtitlesOctopus to fail when fetching embedded subtitles or fonts. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:14:08 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10101