starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #4443] [MERGED] Remove OriginalAuthenticationInfo and add IsAuthenticated property #10077

New Issue
Closed
opened 2026-02-07 06:13:42 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:13:42 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4443
Author: @cvium
Created: 11/8/2020
Status: ✅ Merged
Merged: 11/8/2020
Merged by: @Bond-009

Base: master ← Head: fix_auth_again_again_again

📝 Commits (1)

  • e78c63c Remove OriginalAuthenticationInfo and add IsAuthenticated property

📊 Changes

5 files changed (+24 additions, -18 deletions)

View changed files

📝 Emby.Server.Implementations/HttpServer/Security/AuthService.cs (+3 -2)
📝 Emby.Server.Implementations/HttpServer/Security/AuthorizationContext.cs (+12 -13)
📝 Jellyfin.Api/Auth/CustomAuthenticationHandler.cs (+1 -1)
📝 MediaBrowser.Controller/Net/AuthorizationInfo.cs (+5 -0)
📝 tests/Jellyfin.Api.Tests/Auth/CustomAuthenticationHandlerTests.cs (+3 -2)

📄 Description

OriginalAuthenticationInfo was unused as far as I can tell. Using token or user to check if the token is authenticated is rubbish, so I added IsAuthenticated to the auth info class.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4443 **Author:** [@cvium](https://github.com/cvium) **Created:** 11/8/2020 **Status:** ✅ Merged **Merged:** 11/8/2020 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `fix_auth_again_again_again` --- ### 📝 Commits (1) - [`e78c63c`](https://github.com/jellyfin/jellyfin/commit/e78c63c4dc819867acddc5a15a7d7c02f7aa9b30) Remove OriginalAuthenticationInfo and add IsAuthenticated property ### 📊 Changes **5 files changed** (+24 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/HttpServer/Security/AuthService.cs` (+3 -2) 📝 `Emby.Server.Implementations/HttpServer/Security/AuthorizationContext.cs` (+12 -13) 📝 `Jellyfin.Api/Auth/CustomAuthenticationHandler.cs` (+1 -1) 📝 `MediaBrowser.Controller/Net/AuthorizationInfo.cs` (+5 -0) 📝 `tests/Jellyfin.Api.Tests/Auth/CustomAuthenticationHandlerTests.cs` (+3 -2) </details> ### 📄 Description OriginalAuthenticationInfo was unused as far as I can tell. Using token or user to check if the token is authenticated is rubbish, so I added IsAuthenticated to the auth info class. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:13:42 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10077
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?