starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #4409] [MERGED] Fix API separators #10064

New Issue
Closed
opened 2026-02-07 06:13:26 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:13:26 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4409
Author: @crobibero
Created: 11/2/2020
Status: ✅ Merged
Merged: 11/3/2020
Merged by: @Bond-009

Base: master ← Head: fix-separators

📝 Commits (3)

📊 Changes

3 files changed (+11 additions, -11 deletions)

View changed files

📝 Jellyfin.Api/Controllers/ArtistsController.cs (+6 -6)
📝 Jellyfin.Api/Controllers/LiveTvController.cs (+2 -2)
📝 Jellyfin.Api/Controllers/StudiosController.cs (+3 -3)

📄 Description

Sometimes items are split by |, instead of ,.
Compared against v10.6.4 branch.
Container split is fixed by #4405

Targets
    Occurrences of '|' in Project 'MediaBrowser.Api' with mask '*.cs'
Found usages  (9 usages found)
    <MediaBrowser.Api>  (9 usages found)
        Playback  (1 usage found)
            UniversalAudioService.cs  (1 usage found)
                168 var parts = container.Split(new[] { '|' }, StringSplitOptions.RemoveEmptyEntries);
        UserLibrary  (8 usages found)
            BaseItemsByNameService.cs  (1 usage found)
                156 query.StudioIds = request.Studios.Split('|').Select(i =>
            BaseItemsRequest.cs  (4 usages found)
                357 return (Genres ?? string.Empty).Split(new[] { '|' }, StringSplitOptions.RemoveEmptyEntries);
                362 return (Tags ?? string.Empty).Split(new[] { '|' }, StringSplitOptions.RemoveEmptyEntries);
                367 return (OfficialRatings ?? string.Empty).Split(new[] { '|' }, StringSplitOptions.RemoveEmptyEntries);
                392 return (Studios ?? string.Empty).Split(new[] { '|' }, StringSplitOptions.RemoveEmptyEntries);
            ItemsService.cs  (3 usages found)
                428 query.ArtistIds = request.Artists.Split('|').Select(i =>
                455 query.AlbumIds = request.Albums.Split('|').SelectMany(i =>
                469 query.StudioIds = request.Studios.Split('|').Select(i =>

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4409 **Author:** [@crobibero](https://github.com/crobibero) **Created:** 11/2/2020 **Status:** ✅ Merged **Merged:** 11/3/2020 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `fix-separators` --- ### 📝 Commits (3) - [`826c241`](https://github.com/jellyfin/jellyfin/commit/826c24142e43550bd8de114ae19e3789677cfdc3) Fix Genres separator - [`c1ec46e`](https://github.com/jellyfin/jellyfin/commit/c1ec46e92b2f5184ea0c7c1f84c19fc154fb15ad) Fix Tags separator - [`dd3507b`](https://github.com/jellyfin/jellyfin/commit/dd3507bbbfd656a4138ac9428bebaa67e11cb076) Fix OfficialRatings separator ### 📊 Changes **3 files changed** (+11 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Api/Controllers/ArtistsController.cs` (+6 -6) 📝 `Jellyfin.Api/Controllers/LiveTvController.cs` (+2 -2) 📝 `Jellyfin.Api/Controllers/StudiosController.cs` (+3 -3) </details> ### 📄 Description Sometimes items are split by `|`, instead of `,`. Compared against v10.6.4 branch. Container split is fixed by #4405 ``` Targets Occurrences of '|' in Project 'MediaBrowser.Api' with mask '*.cs' Found usages (9 usages found) <MediaBrowser.Api> (9 usages found) Playback (1 usage found) UniversalAudioService.cs (1 usage found) 168 var parts = container.Split(new[] { '|' }, StringSplitOptions.RemoveEmptyEntries); UserLibrary (8 usages found) BaseItemsByNameService.cs (1 usage found) 156 query.StudioIds = request.Studios.Split('|').Select(i => BaseItemsRequest.cs (4 usages found) 357 return (Genres ?? string.Empty).Split(new[] { '|' }, StringSplitOptions.RemoveEmptyEntries); 362 return (Tags ?? string.Empty).Split(new[] { '|' }, StringSplitOptions.RemoveEmptyEntries); 367 return (OfficialRatings ?? string.Empty).Split(new[] { '|' }, StringSplitOptions.RemoveEmptyEntries); 392 return (Studios ?? string.Empty).Split(new[] { '|' }, StringSplitOptions.RemoveEmptyEntries); ItemsService.cs (3 usages found) 428 query.ArtistIds = request.Artists.Split('|').Select(i => 455 query.AlbumIds = request.Albums.Split('|').SelectMany(i => 469 query.StudioIds = request.Studios.Split('|').Select(i => ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:13:26 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10064
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?