starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #4404] [CLOSED] Networking 3 #10057

New Issue
Closed
opened 2026-02-07 06:13:20 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:13:20 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4404
Author: @BaronGreenback
Created: 10/31/2020
Status: ❌ Closed

Base: master ← Head: NetworkPR3

📝 Commits (10+)

  • 1449f2c Code upload
  • 5ae0d71 Removed duplicate function.
  • d4dfecf Moved into correct namespace
  • 8b82fe0 Fix setting duplicate keys from auth header
  • 9d19c9d Remove jellyfin-ffmpeg dep from server package
  • f3f430e Dependency catch up
  • 97de3eb Rename itemIds to ids
  • 688b193 Remove CommaDelimitedArrayModelBinderProvider
  • e00f60b Automatically clean activity log database
  • 2c540eb Allow configuration of ActivityLogRetention

📊 Changes

15 files changed (+2380 additions, -854 deletions)

View changed files

➕ Emby.Dlna/Ssdp/DiscoveredSsdpDevice.cs (+110 -0)
➕ Emby.Dlna/Ssdp/ISsdpServer.cs (+79 -0)
➕ Emby.Dlna/Ssdp/SsdpDeviceInfo.cs (+47 -0)
➕ Emby.Dlna/Ssdp/SsdpEventArgs.cs (+61 -0)
➕ Emby.Dlna/Ssdp/SsdpLocator.cs (+435 -0)
➕ Emby.Dlna/Ssdp/SsdpServer.cs (+624 -0)
➖ Emby.Server.Implementations/Networking/NetworkManager.cs (+0 -566)
➖ Jellyfin.Networking/Manager/INetworkManager.cs (+0 -234)
📝 MediaBrowser.Common/Net/INetworkManager.cs (+185 -49)
➕ MediaBrowser.Common/Udp/StringExtensions.cs (+67 -0)
➕ MediaBrowser.Common/Udp/UdpHelper.cs (+620 -0)
➕ MediaBrowser.Common/Udp/UdpProcess.cs (+145 -0)
📝 MediaBrowser.sln (+1 -1)
📝 RSSDP/SsdpCommunicationsServer.cs (+2 -2)
📝 RSSDP/SsdpDevicePublisher.cs (+4 -2)

📄 Description

This will compile once PR2 is submitted

This PR does not integrated this functionality into JF. This will occur in the next PR.

This PR is a set of new IPv6/Ipv4 UDP helper routines, based upon .NET call-back functionality, rather than using thread waiting techniques.

Advantages:

  • The result is a much more responsive system, (i.e. network device detection is substantially faster than the current).
  • Code complexity is reduced.
  • Code quantity is reduced. These three helper classes provide UDP functionality and replace the current SocketFactory, UDPSocket, UDPServer classes (and more!), as well as enabling network listener objects to be created with a few lines of code.
  • Low level tracing functionality.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4404 **Author:** [@BaronGreenback](https://github.com/BaronGreenback) **Created:** 10/31/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `NetworkPR3` --- ### 📝 Commits (10+) - [`1449f2c`](https://github.com/jellyfin/jellyfin/commit/1449f2c12f00a18cfd9c4876ed37bc5b8b9cd83c) Code upload - [`5ae0d71`](https://github.com/jellyfin/jellyfin/commit/5ae0d714ae654c99890d322624da74e4b786c8c3) Removed duplicate function. - [`d4dfecf`](https://github.com/jellyfin/jellyfin/commit/d4dfecfcc4504dff5462deb6ee18fa7d5c27298f) Moved into correct namespace - [`8b82fe0`](https://github.com/jellyfin/jellyfin/commit/8b82fe02b1ad66003a41721bac81405d68894f7f) Fix setting duplicate keys from auth header - [`9d19c9d`](https://github.com/jellyfin/jellyfin/commit/9d19c9d2aaf33c3ea7930928f8f59fb9ca7c011f) Remove jellyfin-ffmpeg dep from server package - [`f3f430e`](https://github.com/jellyfin/jellyfin/commit/f3f430ea3c794e5b619566317c9408d31c532f44) Dependency catch up - [`97de3eb`](https://github.com/jellyfin/jellyfin/commit/97de3eb7250cd9e578473c449120a110ca2b63c8) Rename itemIds to ids - [`688b193`](https://github.com/jellyfin/jellyfin/commit/688b1934a0204329e6d512e79980533146b42578) Remove CommaDelimitedArrayModelBinderProvider - [`e00f60b`](https://github.com/jellyfin/jellyfin/commit/e00f60b756e2b030d2d866a57a28e61e18c290b6) Automatically clean activity log database - [`2c540eb`](https://github.com/jellyfin/jellyfin/commit/2c540eb803310fc19c8d8b8ec74617232a84f2af) Allow configuration of ActivityLogRetention ### 📊 Changes **15 files changed** (+2380 additions, -854 deletions) <details> <summary>View changed files</summary> ➕ `Emby.Dlna/Ssdp/DiscoveredSsdpDevice.cs` (+110 -0) ➕ `Emby.Dlna/Ssdp/ISsdpServer.cs` (+79 -0) ➕ `Emby.Dlna/Ssdp/SsdpDeviceInfo.cs` (+47 -0) ➕ `Emby.Dlna/Ssdp/SsdpEventArgs.cs` (+61 -0) ➕ `Emby.Dlna/Ssdp/SsdpLocator.cs` (+435 -0) ➕ `Emby.Dlna/Ssdp/SsdpServer.cs` (+624 -0) ➖ `Emby.Server.Implementations/Networking/NetworkManager.cs` (+0 -566) ➖ `Jellyfin.Networking/Manager/INetworkManager.cs` (+0 -234) 📝 `MediaBrowser.Common/Net/INetworkManager.cs` (+185 -49) ➕ `MediaBrowser.Common/Udp/StringExtensions.cs` (+67 -0) ➕ `MediaBrowser.Common/Udp/UdpHelper.cs` (+620 -0) ➕ `MediaBrowser.Common/Udp/UdpProcess.cs` (+145 -0) 📝 `MediaBrowser.sln` (+1 -1) 📝 `RSSDP/SsdpCommunicationsServer.cs` (+2 -2) 📝 `RSSDP/SsdpDevicePublisher.cs` (+4 -2) </details> ### 📄 Description **This will compile once PR2 is submitted** This PR does not integrated this functionality into JF. This will occur in the next PR. This PR is a set of new IPv6/Ipv4 UDP helper routines, based upon .NET call-back functionality, rather than using thread waiting techniques. Advantages: - The result is a much more responsive system, (i.e. network device detection is substantially faster than the current). - Code complexity is reduced. - Code quantity is reduced. These three helper classes provide UDP functionality and replace the current SocketFactory, UDPSocket, UDPServer classes (and more!), as well as enabling network listener objects to be created with a few lines of code. - Low level tracing functionality. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:13:20 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10057
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?