starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #4380] [CLOSED] Remove warnings #10046

New Issue
Closed
opened 2026-02-07 06:13:05 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:13:05 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4380
Author: @dcparga
Created: 10/27/2020
Status: ❌ Closed

Base: master ← Head: remove-warnings

📝 Commits (1)

📊 Changes

139 files changed (+4314 additions, -4884 deletions)

View changed files

📝 Emby.Server.Implementations/ApplicationHost.cs (+585 -605)
📝 Emby.Server.Implementations/Data/BaseSqliteRepository.cs (+1 -1)
📝 Emby.Server.Implementations/Data/SqliteItemRepository.cs (+5 -5)
📝 Emby.Server.Implementations/Data/SqliteUserDataRepository.cs (+1 -1)
📝 Emby.Server.Implementations/Devices/DeviceManager.cs (+38 -41)
📝 Emby.Server.Implementations/Dto/DtoService.cs (+100 -155)
📝 Emby.Server.Implementations/IO/LibraryMonitor.cs (+128 -128)
📝 Emby.Server.Implementations/IO/ManagedFileSystem.cs (+2 -2)
📝 Emby.Server.Implementations/Library/LibraryManager.cs (+2 -2)
📝 Emby.Server.Implementations/Library/ResolverHelper.cs (+1 -1)
📝 Emby.Server.Implementations/Library/Resolvers/TV/EpisodeResolver.cs (+11 -11)
📝 Emby.Server.Implementations/Library/Resolvers/TV/SeriesResolver.cs (+1 -1)
📝 Emby.Server.Implementations/Library/SearchEngine.cs (+1 -1)
📝 Emby.Server.Implementations/LiveTv/Listings/SchedulesDirect.cs (+163 -185)
📝 Emby.Server.Implementations/ScheduledTasks/ScheduledTaskWorker.cs (+1 -1)
📝 Emby.Server.Implementations/ScheduledTasks/Tasks/ChapterImagesTask.cs (+0 -3)
📝 Emby.Server.Implementations/ScheduledTasks/Tasks/RefreshMediaLibraryTask.cs (+0 -3)
📝 Emby.Server.Implementations/ScheduledTasks/Triggers/StartupTrigger.cs (+13 -13)
📝 Emby.Server.Implementations/Serialization/JsonSerializer.cs (+12 -12)
📝 MediaBrowser.Controller/Channels/ChannelItemInfo.cs (+14 -14)

...and 80 more files

📄 Description

Changes
Removed some basic warnings:

  • Constructor should not proceed a method/property.
  • Finishing comments properly.
  • Added some missing texts in comments

#2149

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4380 **Author:** [@dcparga](https://github.com/dcparga) **Created:** 10/27/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `remove-warnings` --- ### 📝 Commits (1) - [`9740582`](https://github.com/jellyfin/jellyfin/commit/974058261c7387a25382149d7eb30d3ce6e529c9) Remove warnings ### 📊 Changes **139 files changed** (+4314 additions, -4884 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/ApplicationHost.cs` (+585 -605) 📝 `Emby.Server.Implementations/Data/BaseSqliteRepository.cs` (+1 -1) 📝 `Emby.Server.Implementations/Data/SqliteItemRepository.cs` (+5 -5) 📝 `Emby.Server.Implementations/Data/SqliteUserDataRepository.cs` (+1 -1) 📝 `Emby.Server.Implementations/Devices/DeviceManager.cs` (+38 -41) 📝 `Emby.Server.Implementations/Dto/DtoService.cs` (+100 -155) 📝 `Emby.Server.Implementations/IO/LibraryMonitor.cs` (+128 -128) 📝 `Emby.Server.Implementations/IO/ManagedFileSystem.cs` (+2 -2) 📝 `Emby.Server.Implementations/Library/LibraryManager.cs` (+2 -2) 📝 `Emby.Server.Implementations/Library/ResolverHelper.cs` (+1 -1) 📝 `Emby.Server.Implementations/Library/Resolvers/TV/EpisodeResolver.cs` (+11 -11) 📝 `Emby.Server.Implementations/Library/Resolvers/TV/SeriesResolver.cs` (+1 -1) 📝 `Emby.Server.Implementations/Library/SearchEngine.cs` (+1 -1) 📝 `Emby.Server.Implementations/LiveTv/Listings/SchedulesDirect.cs` (+163 -185) 📝 `Emby.Server.Implementations/ScheduledTasks/ScheduledTaskWorker.cs` (+1 -1) 📝 `Emby.Server.Implementations/ScheduledTasks/Tasks/ChapterImagesTask.cs` (+0 -3) 📝 `Emby.Server.Implementations/ScheduledTasks/Tasks/RefreshMediaLibraryTask.cs` (+0 -3) 📝 `Emby.Server.Implementations/ScheduledTasks/Triggers/StartupTrigger.cs` (+13 -13) 📝 `Emby.Server.Implementations/Serialization/JsonSerializer.cs` (+12 -12) 📝 `MediaBrowser.Controller/Channels/ChannelItemInfo.cs` (+14 -14) _...and 80 more files_ </details> ### 📄 Description **Changes** Removed some basic warnings: - Constructor should not proceed a method/property. - Finishing comments properly. - Added some missing texts in comments #2149 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:13:05 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10046
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?