mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-07-16 05:43:54 +03:00
[PR #4359] [CLOSED] Add initial management interface support #10040
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/jellyfin/jellyfin/pull/4359
Author: @EraYaN
Created: 10/21/2020
Status: ❌ Closed
Base:
master← Head:EraYaN-add-management-interface📝 Commits (4)
c5d900bAdd initial management interface support.bc69aa2Merge branch 'master' into EraYaN-add-management-interface1bbe262Fix build7852f0bIgnore management controller when generating openapi spec📊 Changes
7 files changed (+269 additions, -0 deletions)
View changed files
➕
Jellyfin.Api/Attributes/ManagementAttribute.cs(+14 -0)➕
Jellyfin.Api/Controllers/ManagementController.cs(+73 -0)📝
Jellyfin.Server/Extensions/ApiServiceCollectionExtensions.cs(+3 -0)➕
Jellyfin.Server/Filters/ManagementInterfaceFilter.cs(+101 -0)📝
Jellyfin.Server/Program.cs(+34 -0)📝
MediaBrowser.Controller/Extensions/ConfigurationExtensions.cs(+39 -0)📝
MediaBrowser.Model/Configuration/ServerConfiguration.cs(+5 -0)📄 Description
Changes
This add a management interface on right now port 12000 (debate in the comments below!)
This can house all the endpoint that are deemed too insecure for the main API but are required for the tray applications for example. And might also be the right choice for stuff like prometheus metrics etc.
This probably house the shutdown/restart endpoint.
We might want to also add a
ManagementAlsoAttributethat puts an endpoint on both the public API and the local one.Right now this will be broken for socket based management ports. (No idea what
HttpContext.Connectionlooks like when connecting over a socket)The test endpoint right now is
/Management/Test.It now returns a 404 not found result (problem json) when it won't allow you in.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.