starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #4328] [MERGED] Remove CommaDelimitedArrayModelBinderProvider #10026

New Issue
Closed
opened 2026-02-07 06:12:47 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:12:47 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4328
Author: @crobibero
Created: 10/14/2020
Status: ✅ Merged
Merged: 11/2/2020
Merged by: @Bond-009

Base: master ← Head: trigger-warning

📝 Commits (1)

  • f2a86d9 Remove CommaDelimitedArrayModelBinderProvider

📊 Changes

12 files changed (+23 additions, -46 deletions)

View changed files

📝 Jellyfin.Api/Controllers/ArtistsController.cs (+3 -2)
📝 Jellyfin.Api/Controllers/ChannelsController.cs (+3 -2)
📝 Jellyfin.Api/Controllers/GenresController.cs (+2 -1)
📝 Jellyfin.Api/Controllers/ItemsController.cs (+3 -2)
📝 Jellyfin.Api/Controllers/LibraryStructureController.cs (+2 -1)
📝 Jellyfin.Api/Controllers/MusicGenresController.cs (+2 -1)
📝 Jellyfin.Api/Controllers/PersonsController.cs (+2 -1)
📝 Jellyfin.Api/Controllers/SessionController.cs (+1 -1)
📝 Jellyfin.Api/Controllers/StudiosController.cs (+2 -1)
📝 Jellyfin.Api/Controllers/TrailersController.cs (+3 -2)
➖ Jellyfin.Api/ModelBinders/CommaDelimitedArrayModelBinderProvider.cs (+0 -29)
📝 Jellyfin.Server/Extensions/ApiServiceCollectionExtensions.cs (+0 -3)

📄 Description

CommaDelimitedArrayModelBinderProvider was causing issues when the model body was an array, so I removed it and added the [ModelBinder(typeof(CommaDelimitedArrayModelBinder))] attribute to all query parameters that accept arrays.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4328 **Author:** [@crobibero](https://github.com/crobibero) **Created:** 10/14/2020 **Status:** ✅ Merged **Merged:** 11/2/2020 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `trigger-warning` --- ### 📝 Commits (1) - [`f2a86d9`](https://github.com/jellyfin/jellyfin/commit/f2a86d9c80748b39c4bd798882dea79b7f345302) Remove CommaDelimitedArrayModelBinderProvider ### 📊 Changes **12 files changed** (+23 additions, -46 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Api/Controllers/ArtistsController.cs` (+3 -2) 📝 `Jellyfin.Api/Controllers/ChannelsController.cs` (+3 -2) 📝 `Jellyfin.Api/Controllers/GenresController.cs` (+2 -1) 📝 `Jellyfin.Api/Controllers/ItemsController.cs` (+3 -2) 📝 `Jellyfin.Api/Controllers/LibraryStructureController.cs` (+2 -1) 📝 `Jellyfin.Api/Controllers/MusicGenresController.cs` (+2 -1) 📝 `Jellyfin.Api/Controllers/PersonsController.cs` (+2 -1) 📝 `Jellyfin.Api/Controllers/SessionController.cs` (+1 -1) 📝 `Jellyfin.Api/Controllers/StudiosController.cs` (+2 -1) 📝 `Jellyfin.Api/Controllers/TrailersController.cs` (+3 -2) ➖ `Jellyfin.Api/ModelBinders/CommaDelimitedArrayModelBinderProvider.cs` (+0 -29) 📝 `Jellyfin.Server/Extensions/ApiServiceCollectionExtensions.cs` (+0 -3) </details> ### 📄 Description CommaDelimitedArrayModelBinderProvider was causing issues when the model body was an array, so I removed it and added the `[ModelBinder(typeof(CommaDelimitedArrayModelBinder))]` attribute to all query parameters that accept arrays. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:12:47 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10026
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?