starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #4313] [CLOSED] Removing some warnings #10020

New Issue
Closed
opened 2026-02-07 06:12:40 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:12:40 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4313
Author: @dcparga
Created: 10/12/2020
Status: ❌ Closed

Base: master ← Head: removing-some-warnings

📝 Commits (1)

📊 Changes

24 files changed (+448 additions, -590 deletions)

View changed files

📝 MediaBrowser.Model/Channels/ChannelFeatures.cs (+13 -12)
📝 MediaBrowser.Model/Channels/ChannelFolderType.cs (+1 -0)
📝 MediaBrowser.Model/Channels/ChannelItemSortField.cs (+1 -0)
📝 MediaBrowser.Model/Channels/ChannelMediaContentType.cs (+1 -0)
📝 MediaBrowser.Model/Channels/ChannelMediaType.cs (+1 -0)
📝 MediaBrowser.Model/Channels/ChannelQuery.cs (+3 -2)
📝 MediaBrowser.Model/Configuration/EncodingOptions.cs (+36 -34)
📝 MediaBrowser.Model/Configuration/ImageOption.cs (+5 -5)
📝 MediaBrowser.Model/Configuration/ImageSavingConvention.cs (+1 -0)
📝 MediaBrowser.Model/Configuration/LibraryOptions.cs (+28 -392)
➕ MediaBrowser.Model/Configuration/MediaPathInfo.cs (+9 -0)
📝 MediaBrowser.Model/Configuration/MetadataConfiguration.cs (+2 -2)
📝 MediaBrowser.Model/Configuration/MetadataOptions.cs (+16 -15)
📝 MediaBrowser.Model/Configuration/MetadataPluginSummary.cs (+12 -11)
📝 MediaBrowser.Model/Configuration/MetadataPluginType.cs (+1 -0)
➕ MediaBrowser.Model/Configuration/PathSubstitution.cs (+9 -0)
📝 MediaBrowser.Model/Configuration/ServerConfiguration.cs (+12 -19)
➕ MediaBrowser.Model/Configuration/TypeOptions.cs (+213 -0)
📝 MediaBrowser.Model/Dlna/AudioOptions.cs (+7 -4)
📝 MediaBrowser.Model/Dlna/ContainerProfile.cs (+7 -6)

...and 4 more files

📄 Description

Some warnings being removed for issue #2149

I'm just wondering if the warning about "Property's description should start with Get or sets" shouldn't be disabled in the config file instead of changing descriptions/disabling warning file by file.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4313 **Author:** [@dcparga](https://github.com/dcparga) **Created:** 10/12/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `removing-some-warnings` --- ### 📝 Commits (1) - [`0974ec3`](https://github.com/jellyfin/jellyfin/commit/0974ec39551d8b66aa00bebe9a92a8e15d08f68c) Removing some warnings ### 📊 Changes **24 files changed** (+448 additions, -590 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.Model/Channels/ChannelFeatures.cs` (+13 -12) 📝 `MediaBrowser.Model/Channels/ChannelFolderType.cs` (+1 -0) 📝 `MediaBrowser.Model/Channels/ChannelItemSortField.cs` (+1 -0) 📝 `MediaBrowser.Model/Channels/ChannelMediaContentType.cs` (+1 -0) 📝 `MediaBrowser.Model/Channels/ChannelMediaType.cs` (+1 -0) 📝 `MediaBrowser.Model/Channels/ChannelQuery.cs` (+3 -2) 📝 `MediaBrowser.Model/Configuration/EncodingOptions.cs` (+36 -34) 📝 `MediaBrowser.Model/Configuration/ImageOption.cs` (+5 -5) 📝 `MediaBrowser.Model/Configuration/ImageSavingConvention.cs` (+1 -0) 📝 `MediaBrowser.Model/Configuration/LibraryOptions.cs` (+28 -392) ➕ `MediaBrowser.Model/Configuration/MediaPathInfo.cs` (+9 -0) 📝 `MediaBrowser.Model/Configuration/MetadataConfiguration.cs` (+2 -2) 📝 `MediaBrowser.Model/Configuration/MetadataOptions.cs` (+16 -15) 📝 `MediaBrowser.Model/Configuration/MetadataPluginSummary.cs` (+12 -11) 📝 `MediaBrowser.Model/Configuration/MetadataPluginType.cs` (+1 -0) ➕ `MediaBrowser.Model/Configuration/PathSubstitution.cs` (+9 -0) 📝 `MediaBrowser.Model/Configuration/ServerConfiguration.cs` (+12 -19) ➕ `MediaBrowser.Model/Configuration/TypeOptions.cs` (+213 -0) 📝 `MediaBrowser.Model/Dlna/AudioOptions.cs` (+7 -4) 📝 `MediaBrowser.Model/Dlna/ContainerProfile.cs` (+7 -6) _...and 4 more files_ </details> ### 📄 Description Some warnings being removed for issue #2149 I'm just wondering if the warning about "Property's description should start with Get or sets" shouldn't be disabled in the config file instead of changing descriptions/disabling warning file by file. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:12:40 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10020
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?