starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #4301] [MERGED] Fix comma delimited array model binder #10010

New Issue
Closed
opened 2026-02-07 06:12:29 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:12:29 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4301
Author: @crobibero
Created: 10/10/2020
Status: ✅ Merged
Merged: 10/11/2020
Merged by: @dkanada

Base: master ← Head: fix-array-binder

📝 Commits (2)

  • 17b20aa Fix comma delimited array model binder
  • 6a3a193 Fix and clean tests

📊 Changes

2 files changed (+17 additions, -26 deletions)

View changed files

📝 Jellyfin.Api/ModelBinders/CommaDelimitedArrayModelBinder.cs (+0 -5)
📝 tests/Jellyfin.Api.Tests/ModelBinders/CommaDelimitedArrayModelBinderTests.cs (+17 -21)

📄 Description

Default in aspnetcore is to return an array when no parameters are included.

Note- in both default aspnetcore and with this binder [Required] doesn't work on array parameters.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4301 **Author:** [@crobibero](https://github.com/crobibero) **Created:** 10/10/2020 **Status:** ✅ Merged **Merged:** 10/11/2020 **Merged by:** [@dkanada](https://github.com/dkanada) **Base:** `master` ← **Head:** `fix-array-binder` --- ### 📝 Commits (2) - [`17b20aa`](https://github.com/jellyfin/jellyfin/commit/17b20aa0c03b17cf41494983115127abc6f7ede1) Fix comma delimited array model binder - [`6a3a193`](https://github.com/jellyfin/jellyfin/commit/6a3a193dbbe856a22662f495af04aca729495d1f) Fix and clean tests ### 📊 Changes **2 files changed** (+17 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Api/ModelBinders/CommaDelimitedArrayModelBinder.cs` (+0 -5) 📝 `tests/Jellyfin.Api.Tests/ModelBinders/CommaDelimitedArrayModelBinderTests.cs` (+17 -21) </details> ### 📄 Description Default in aspnetcore is to return an array when no parameters are included. Note- in both default aspnetcore and with this binder `[Required]` doesn't work on array parameters. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:12:29 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10010
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?