Commit Graph

343 Commits

Author SHA1 Message Date
gnattu
8683253c6d Fix Library renaming
This handler should not just spawn a normal library validation task because our new logic will prevent the removal of library root folder unless explicitly required, which will cause the old lib still "ghosting" in the db.

Signed-off-by: gnattu <gnattuoc@me.com>
2024-06-05 08:49:33 +08:00
Shadowghost
8a5a93ee80 Allow removal of all people from an item 2024-05-21 21:14:30 +02:00
gnattu
3ae0fb90cb Validate Collection Folders on adding and removal (#11444) 2024-05-05 08:21:40 -06:00
Bond-009
3feb3f81bf More efficient array creation (#11468) 2024-04-30 13:32:59 -06:00
Bond-009
d29b85a134 Fix multiple intro providers and remove unneeded ToLists (#11431) 2024-04-25 07:02:01 -06:00
Bond-009
37d301ebd4 Merge pull request #11352 from jellyfin/fix-library-removal
fix: explicitly allow remove root when performing library removal
2024-04-18 12:16:04 +02:00
Bond-009
bb018c4adc Enable nullable for LibraryManager (#11191) 2024-04-17 10:44:50 -06:00
gnattu
e4d66f35fd chore: use proper way to override remove root
This is an alternate approach which is more proper, but changes all parts that uses/overrides the original ValidateChildren method

Signed-off-by: gnattu <gnattuoc@me.com>
2024-04-17 14:41:19 +08:00
Cody Robibero
6fb6b5f176 Validate item access (#11171) 2024-04-14 08:18:36 -06:00
gnattu
7befbda1a6 fix: code style
Signed-off-by: gnattu <gnattuoc@me.com>
2024-04-13 15:02:13 +08:00
gnattu
4fa6b8874f fix: typo
Signed-off-by: gnattu <gnattuoc@me.com>
2024-04-13 14:58:29 +08:00
gnattu
204146a3a5 fix: mark UserRoot as non-root when performing removal
Fixes #11269

Signed-off-by: gnattu <gnattuoc@me.com>
2024-04-13 14:48:40 +08:00
Bond-009
7d28d08e08 Enable more warnings as errors (#11288) 2024-04-12 17:45:01 -06:00
Tim Eisele
134bf7a6a5 Don't throw if file was already removed (#11286) 2024-04-12 17:44:45 -06:00
Niels van Velzen
d9fe900952 Fix FindExtras overwriting current extra type (#11260) 2024-03-31 14:48:56 -06:00
Cody Robibero
f7f3ad9eb7 Precache livetv program images (#11083)
* Precache livetv program images

* return if cache hit

* use EnsureSuccessStatusCode

* Read proper bytes
2024-03-03 13:32:55 -07:00
Cody Robibero
0bc41c015f Store lyrics in the database as media streams (#9951) 2024-02-26 05:09:40 -07:00
Patrick Barron
0960438065 Remove ActionableProgress 2024-02-06 09:58:25 -05:00
Patrick Barron
8698b90594 Remove SimpleProgress 2024-02-06 09:50:46 -05:00
Cody Robibero
e7b8d45bbb Use helper function to compare guid (#10825) 2024-01-17 08:51:39 -07:00
Cody Robibero
033cfa59c4 Convert CollectionType to use lowercase enum names 2023-12-08 15:45:36 -07:00
Cody Robibero
906f701fa8 Convert CollectionType, SpecialFolderType to enum (#9764)
* Convert CollectionType, SpecialFolderType to enum

* Hide internal enum CollectionType values

* Apply suggestions from code review

Co-authored-by: Shadowghost <Shadowghost@users.noreply.github.com>

* Fix recent change

* Update Jellyfin.Data/Attributes/OpenApiIgnoreEnumAttribute.cs

Co-authored-by: Patrick Barron <barronpm@gmail.com>

---------

Co-authored-by: Shadowghost <Shadowghost@users.noreply.github.com>
Co-authored-by: Patrick Barron <barronpm@gmail.com>
2023-11-09 14:00:29 -07:00
Cody Robibero
c7a94d48ae Convert ItemSortBy to enum (#9765)
* Convert ItemSortBy to enum

* Rename Unknown to Default
2023-11-09 14:00:13 -07:00
Stepan Goremykin
8d7e4229ca Merge branch 'master' into fix-resharper-warnings
# Conflicts:
#	Emby.Server.Implementations/Net/SocketFactory.cs
#	RSSDP/SsdpCommunicationsServer.cs
#	RSSDP/SsdpDeviceLocator.cs
#	RSSDP/SsdpDevicePublisher.cs
2023-10-12 20:11:16 +02:00
Bond-009
406c5df8a3 Merge pull request #10345 from Bond-009/getperson 2023-10-08 14:07:38 +02:00
Stepan Goremykin
f84469d500 Remove redundant using directives 2023-10-08 00:50:02 +02:00
Stepan Goremykin
a37dc3da96 Use async overload 2023-10-08 00:17:48 +02:00
Bond_009
b176beb88e Reduce string allocations
Some simple changes to reduce the number of allocated strings
2023-10-06 01:04:25 +02:00
Bond_009
852f1dc0c1 Don't create non existent persons in LibraryManager.GetPerson
return null instead.

GetStudio, GetGenre, GetMusicGenre, GetYear, GetArtist still create a new one
when the requested one doesn't exist

Fixes #3901
2023-10-05 23:16:17 +02:00
Bond_009
767a42fbdb Minor LibraryMonitor improvements
* Enable nullable
* Add a fast return to ReportFileSystemChanged when path should be ignored
* Use Span overloads of Path.* functions where possible
* IFileSystem: remove NormalizePath as Path.TrimEndingDirectorySeparator already checks if it's a root path
2023-09-13 17:30:50 +02:00
Stepan Goremykin
0ed2aa6f06 Fix a few multiple enumerations 2023-08-26 16:57:27 +02:00
cvium
2e32e335ac refactor: use ConcurrentDictionary when IMemoryCache isn't needed 2023-08-18 14:00:56 +02:00
Claus Vium
bfb7c60f72 Merge pull request #9447 from Bond-009/disablerealtimemonitor
Disable real time monitoring by default
2023-07-01 19:33:53 +02:00
Shadowghost
81746666de Fix TotalRecordCount calculation 2023-05-26 11:06:04 +02:00
JPVenson
3c22d5c970 #7626 Added handling for common FormatExceptions with Skia loading sv… (#9581)
Co-authored-by: Shadowghost <Shadowghost@users.noreply.github.com>
2023-04-10 21:38:07 +02:00
Stepan Goremykin
b6cfdb8b92 Simplify conditional expression 2023-04-06 19:30:17 +02:00
elmuffo
bb5bf0277a Implement check to hide all libraries when user has no access (#9536) 2023-04-01 15:01:05 -06:00
Bond_009
891e2495c9 Disable real time monitoring by default 2023-03-07 17:59:29 +01:00
Joe Rogers
1c3a97bf6a Inject IDirectoryService where needed instead of passing it through ItemResolveArgs 2023-03-06 23:00:55 -05:00
Joe Rogers
160baa02fd Remove some BaseItem references to make ItemResolveArgs more usable for testing. 2023-03-06 22:18:26 -05:00
Bond_009
4b01aaa0f7 Allocate less Lists 2023-03-01 00:44:57 +01:00
Bond-009
497d8c4957 Use Order() introduced in .NET 7 (#8923) 2022-12-19 09:30:00 -07:00
Joe Rogers
e4040ab812 Allow video extras to use owner library options 2022-12-08 01:00:27 -05:00
Bond_009
9bb1bc5a3e Remove dependency on OptimizedPriorityQueue 2022-12-07 18:02:12 +01:00
Bond_009
b366dc2e6e Use ArgumentException.ThrowIfNullOrEmpty 2022-12-07 16:43:59 +01:00
Bond_009
52194f56b5 Replace != null with is not null 2022-12-05 15:01:13 +01:00
Bond_009
c7d50d640e Replace == null with is null 2022-12-05 15:00:20 +01:00
Shadowghost
072651c4be Add xmldocs for TMDb provider, correct provider spelling 2022-11-17 11:16:20 +01:00
Joe Rogers
c38052a753 Skip missing symlink instead of breaking out of directory scan 2022-10-09 18:56:25 -04:00
Bond_009
a9a5fcde81 Use ArgumentNullException.ThrowIfNull helper method
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)

```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```

```
ArgumentNullException.ThrowIfNull($1);
```
2022-10-06 20:21:23 +02:00