starred/jellyfin-jellyfin-1
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2025-12-18 23:13:06 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix stack overflow while scanning (#15698)

Browse Source
This commit is contained in:
myzhysz
2025-12-04 10:02:04 +08:00
committed by GitHub
parent 98d1d0cb35
commit dde70fd8a2
1 changed files with 6 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
MediaBrowser.Controller/LibraryTaskScheduler/LimitedConcurrencyLibraryScheduler.cs
View File

@@ -242,7 +242,7 @@ public sealed class LimitedConcurrencyLibraryScheduler : ILimitedConcurrencyLibr
}; };
}).ToArray(); }).ToArray();
if (ShouldForceSequentialOperation()) if (ShouldForceSequentialOperation() || _deadlockDetector.Value is not null)
{ {
_logger.LogDebug("Process sequentially."); _logger.LogDebug("Process sequentially.");
try try
@@ -267,32 +267,11 @@ public sealed class LimitedConcurrencyLibraryScheduler : ILimitedConcurrencyLibr
_tasks.Add(item, CancellationToken.None); _tasks.Add(item, CancellationToken.None);
} }
if (_deadlockDetector.Value is not null) Worker();
{ _logger.LogDebug("Wait for {NoWorkers} to complete.", workItems.Length);
_logger.LogDebug("Nested invocation detected, process in-place."); await Task.WhenAll([.. workItems.Select(f => f.Done.Task)]).ConfigureAwait(false);
try _logger.LogDebug("{NoWorkers} completed.", workItems.Length);
{ ScheduleTaskCleanup();
// we are in a nested loop. There is no reason to spawn a task here as that would just lead to deadlocks and no additional concurrency is achieved
while (workItems.Any(e => !e.Done.Task.IsCompleted) && _tasks.TryTake(out var item, 200, _deadlockDetector.Value.Token))
{
await ProcessItem(item).ConfigureAwait(false);
}
}
catch (OperationCanceledException) when (_deadlockDetector.Value.IsCancellationRequested)
{
// operation is cancelled. Do nothing.
}
_logger.LogDebug("process in-place done.");
}
else
{
Worker();
_logger.LogDebug("Wait for {NoWorkers} to complete.", workItems.Length);
await Task.WhenAll([.. workItems.Select(f => f.Done.Task)]).ConfigureAwait(false);
_logger.LogDebug("{NoWorkers} completed.", workItems.Length);
ScheduleTaskCleanup();
}
} }
/// <inheritdoc/> /// <inheritdoc/>