starred/egg-hytale
1
0
Fork 0
mirror of https://github.com/NATroutter/egg-hytale.git synced 2026-03-01 11:21:13 +03:00
Code Issues Packages Projects Releases Wiki Activity

[PR #33] [MERGED] Shim dmidecode to allow for the usage of game's default encrypted auth #47

New Issue
Closed
opened 2026-02-05 16:40:33 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 16:40:33 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/NATroutter/egg-hytale/pull/33
Author: @IhToN
Created: 1/18/2026
Status: ✅ Merged
Merged: 1/22/2026
Merged by: @NATroutter

Base: dev ← Head: main

📝 Commits (10+)

  • 45ef225 feat: add a dmidecode shim and allow for disabling cleartext session tokens storage
  • c1adbaa Added missing options to readme
  • 782a614 Removed useless message
  • 37662db Updated readme and issue template
  • 4fa3d05 Fixed the updating instructions
  • 6f844b2 feat: add a dmidecode shim and allow for disabling cleartext session tokens storage
  • 68cc207 Merge remote-tracking branch 'origin/main'
  • 2c1cee8 feat: defaults to dmidecode shim
  • 034bd8a fix: remove unused options
  • 750bb97 fix: revert build-push-dev.sh script

📊 Changes

9 files changed (+72 additions, -35 deletions)

View changed files

📝 .github/ISSUE_TEMPLATE/bug_report.yml (+13 -0)
➕ .github/workflows/pr-build-check.yml (+27 -0)
📝 .github/workflows/publish.yml (+0 -0)
📝 Dockerfile (+5 -0)
📝 README.md (+21 -23)
📝 egg-hytale.pelican.json (+4 -4)
📝 egg-hytale.pterodactyl.json (+2 -2)
📝 entrypoint.sh (+0 -5)
📝 start.sh (+0 -1)

📄 Description

Storing authentication tokens in plain text is not the best of the security approach. This is a first intent to allow the usage of the default's game encryption to store the auth session internally.

I've made a small deployment of the forked egg and it is working:
imagen

Might be a good idea to check and possibly remove the authentication credentials storage for the downloader so it is not stored in plain sight either.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/NATroutter/egg-hytale/pull/33 **Author:** [@IhToN](https://github.com/IhToN) **Created:** 1/18/2026 **Status:** ✅ Merged **Merged:** 1/22/2026 **Merged by:** [@NATroutter](https://github.com/NATroutter) **Base:** `dev` ← **Head:** `main` --- ### 📝 Commits (10+) - [`45ef225`](https://github.com/NATroutter/egg-hytale/commit/45ef2258a617b3e3d118c75787b0c04e50cd795f) feat: add a dmidecode shim and allow for disabling cleartext session tokens storage - [`c1adbaa`](https://github.com/NATroutter/egg-hytale/commit/c1adbaa16c95c0a5e7b4563961a4853ae9afe70c) Added missing options to readme - [`782a614`](https://github.com/NATroutter/egg-hytale/commit/782a614beb20896175845b645bc8035d88590af8) Removed useless message - [`37662db`](https://github.com/NATroutter/egg-hytale/commit/37662db4a13dba6735d5f073d8394ed712809f51) Updated readme and issue template - [`4fa3d05`](https://github.com/NATroutter/egg-hytale/commit/4fa3d0554def34766973fdec2589d84f8705e8c4) Fixed the updating instructions - [`6f844b2`](https://github.com/NATroutter/egg-hytale/commit/6f844b2d86ce0e4e98e8f9f09669b85d40e7203f) feat: add a dmidecode shim and allow for disabling cleartext session tokens storage - [`68cc207`](https://github.com/NATroutter/egg-hytale/commit/68cc2071b759fa3fb0701684ddef54e7d9cfab44) Merge remote-tracking branch 'origin/main' - [`2c1cee8`](https://github.com/NATroutter/egg-hytale/commit/2c1cee8fc6c70c006d04ced7c556f5c0d9d717d5) feat: defaults to dmidecode shim - [`034bd8a`](https://github.com/NATroutter/egg-hytale/commit/034bd8ab469e705c83252b0aa60d728615cbb157) fix: remove unused options - [`750bb97`](https://github.com/NATroutter/egg-hytale/commit/750bb97242024ca0dda2ce4e971f3f3a55e2a76b) fix: revert build-push-dev.sh script ### 📊 Changes **9 files changed** (+72 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `.github/ISSUE_TEMPLATE/bug_report.yml` (+13 -0) ➕ `.github/workflows/pr-build-check.yml` (+27 -0) 📝 `.github/workflows/publish.yml` (+0 -0) 📝 `Dockerfile` (+5 -0) 📝 `README.md` (+21 -23) 📝 `egg-hytale.pelican.json` (+4 -4) 📝 `egg-hytale.pterodactyl.json` (+2 -2) 📝 `entrypoint.sh` (+0 -5) 📝 `start.sh` (+0 -1) </details> ### 📄 Description Storing authentication tokens in plain text is not the best of the security approach. This is a first intent to allow the usage of the default's game encryption to store the auth session internally. I've made a small deployment of the forked egg and it is working: <img width="1369" height="728" alt="imagen" src="https://github.com/user-attachments/assets/c86eb95e-15b4-4cf3-91d8-9aaed60319ae" /> Might be a good idea to check and possibly remove the authentication credentials storage for the downloader so it is not stored in plain sight either. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 16:40:33 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/egg-hytale#47
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?