starred/Samsung-Jellyfin-Installer
1
0
Fork 0
mirror of https://github.com/Jellyfin2Samsung/Samsung-Jellyfin-Installer.git synced 2026-03-01 11:21:12 +03:00
Code Issues 1 Packages Projects Releases 23 Wiki Activity

Add user settings to improve user experience and handling #5

New Issue
Closed
opened 2026-02-05 16:46:27 +03:00 by OVERLORD · 8 comments
OVERLORD commented 2026-02-05 16:46:27 +03:00
Owner
Copy Link

Originally created by @jeppevinkel on GitHub (May 18, 2025).

Originally assigned to: @PatrickSt1991 on GitHub.

Not all users have their windows set to the language they prefer to use in software, so it could help with a language switcher in the UI.

Originally created by @jeppevinkel on GitHub (May 18, 2025). Originally assigned to: @PatrickSt1991 on GitHub. Not all users have their windows set to the language they prefer to use in software, so it could help with a language switcher in the UI.
OVERLORD added the enhancementclosed labels 2026-02-05 16:46:27 +03:00
OVERLORD commented 2026-02-05 16:46:29 +03:00
Author
Owner
Copy Link

@PatrickSt1991 commented on GitHub (May 31, 2025):

  • Language selector
  • Certificate selector
  • Use selected certificate
    • Allow user to choose between certificate when default or non-existing create new certificate
  • Custom WGT file
  • Use selected WGT file, stip .wgt extension and add 4 random bytes + .wgt to enable side-by-side loading
    • Allow user to choose custom WGT file

    • Split DownloadReleaseAsync to allow custom WGT

  • Remember IP
    • Remebers the IP adres the user filled in and if valid will popup in the Select TV list
  • Remove old jellyfin
    • Remove previously installed jellyfin applications before installing new version
@PatrickSt1991 commented on GitHub (May 31, 2025): - [x] Language selector - [x] Certificate selector - [x] Use selected certificate - Allow user to choose between certificate when default or non-existing create new certificate - [x] Custom WGT file - [x] Use selected WGT file, stip .wgt extension and add 4 random bytes + .wgt to enable side-by-side loading - Allow user to choose custom WGT file - > Split DownloadReleaseAsync to allow custom WGT - [x] Remember IP - Remebers the IP adres the user filled in and if valid will popup in the Select TV list - [x] Remove old jellyfin - Remove previously installed jellyfin applications before installing new version
OVERLORD commented 2026-02-05 16:46:31 +03:00
Author
Owner
Copy Link

@PatrickSt1991 commented on GitHub (Jun 3, 2025):

@jeppevinkel the branch feature/language-selector contains significant changes to the application, giving user more options and choices.

Maybe you can check if the responsiveness is inline with your PR?

Also I could use some help with merging this one cause last time I tried to merge it, I broke it :( unfortunately GIT isn't my expertise

@PatrickSt1991 commented on GitHub (Jun 3, 2025): @jeppevinkel the branch feature/language-selector contains significant changes to the application, giving user more options and choices. Maybe you can check if the responsiveness is inline with your PR? Also I could use some help with merging this one cause last time I tried to merge it, I broke it :( unfortunately GIT isn't my expertise
OVERLORD commented 2026-02-05 16:46:32 +03:00
Author
Owner
Copy Link

@jeppevinkel commented on GitHub (Jun 3, 2025):

The state with the branching looks a bit weird since it claims it has no commits ahead of master. Based on the commit history on master I assume it's because you merged it already and then reverted the commits in a separate commit? That might need a little git-fu to unwind again.

@jeppevinkel commented on GitHub (Jun 3, 2025): The state with the branching looks a bit weird since it claims it has no commits ahead of master. Based on the commit history on master I assume it's because you merged it already and then reverted the commits in a separate commit? That might need a little git-fu to unwind again.
OVERLORD commented 2026-02-05 16:46:33 +03:00
Author
Owner
Copy Link

@jeppevinkel commented on GitHub (Jun 3, 2025):

I'll see if I get some time to check it out tomorrow. It's too late for me to start today.

@jeppevinkel commented on GitHub (Jun 3, 2025): I'll see if I get some time to check it out tomorrow. It's too late for me to start today.
OVERLORD commented 2026-02-05 16:46:34 +03:00
Author
Owner
Copy Link

@PatrickSt1991 commented on GitHub (Jun 3, 2025):

Yeah I fucked it up a bit, i merged master into the feature branch apparently but don't know when or how I did that 😅

This commit was the last correct one for master 38dfe0b, but ofcourse thats missing your PR

And this commit was the latest correct one for the feature branch 37c7691

@PatrickSt1991 commented on GitHub (Jun 3, 2025): Yeah I fucked it up a bit, i merged master into the feature branch apparently but don't know when or how I did that 😅 This commit was the last correct one for master 38dfe0b, but ofcourse thats missing your PR And this commit was the latest correct one for the feature branch 37c7691
OVERLORD commented 2026-02-05 16:46:35 +03:00
Author
Owner
Copy Link

@jeppevinkel commented on GitHub (Jun 3, 2025):

I tried to see if I could edit the commit history last night, but that is a bit difficult. The easiest solution might be to merge everything into the feature branch and then do a revert of the revert and try to fix it on the feature branch after that.

@jeppevinkel commented on GitHub (Jun 3, 2025): I tried to see if I could edit the commit history last night, but that is a bit difficult. The easiest solution might be to merge everything into the feature branch and then do a revert of the revert and try to fix it on the feature branch after that.
OVERLORD commented 2026-02-05 16:46:36 +03:00
Author
Owner
Copy Link

@PatrickSt1991 commented on GitHub (Jun 3, 2025):

Okay thanks for trying, I'll give it a go

@PatrickSt1991 commented on GitHub (Jun 3, 2025): Okay thanks for trying, I'll give it a go
OVERLORD commented 2026-02-05 16:46:36 +03:00
Author
Owner
Copy Link

@PatrickSt1991 commented on GitHub (Jun 3, 2025):

@jeppevinkel managed to merge all the features, I had to do it all in a new branch, so the master branch is a new different master branch.

previous master is now master-old

Not ideal but at least all of the new code and improvements are merged in to master

@PatrickSt1991 commented on GitHub (Jun 3, 2025): @jeppevinkel managed to merge all the features, I had to do it all in a new branch, so the master branch is a new different master branch. previous master is now master-old Not ideal but at least all of the new code and improvements are merged in to master
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
active
bug
bug
bug
closed
closed
closed
documentation
duplicate
enhancement
enhancement
enhancement
help wanted
keep-alive
linux-x64
missing log files
not an issue
osx-x64
pull-request
Mirrored from GitHub Pull Request
 question
stale
testing
tizen 7+
tizen 7+
tizen 7-
win-x64
wontfix
No Label closed enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/Samsung-Jellyfin-Installer#5
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?