starred/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-02-05 00:29:55 +03:00
Code Issues 11 Packages Projects Releases 10 Wiki Activity

[misc/post-pve-install.sh] Nag screen not disabled on Proxmox-VE 8.3.0 #89

New Issue
Closed
opened 2026-02-04 16:33:42 +03:00 by OVERLORD · 17 comments
OVERLORD commented 2026-02-04 16:33:42 +03:00
Owner
Copy Link

Originally created by @Fclem on GitHub (Nov 21, 2024).

Please verify that you have read and understood the guidelines.

yes

A clear and concise description of the issue.

After running the script misc/post-pve-install.sh and selecting "disable nag screen",
the nag screen is still appearing on a fresh node Proxmox-VE 8.3.0 install when refreshing the packages list in the "Updates" tab.
This issue does not happen on my other proxmox nodes (albeit those have not been rebooted after the update) that had run this script before updating to 8.3.0

What settings are you currently utilizing?

  • Default Settings
  • Advanced Settings

Which Linux distribution are you employing?

Debian 12

If relevant, including screenshots or a code block can be helpful in clarifying the issue.

No response

Please provide detailed steps to reproduce the issue.

  1. Install Proxmox-VE 8.2.2 on a new node.
  2. Add pve-no-subscription repository
  3. Upgrade all packages, and thus update to 8.3
  4. Run bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/misc/post-pve-install.sh)"
  5. Answer yes to all questions (select all the options)
  6. After the reboot, the nag screen is still showing when refreshing the updatable package list in the "Updates" tab of the node.
Originally created by @Fclem on GitHub (Nov 21, 2024). ### Please verify that you have read and understood the guidelines. yes ### A clear and concise description of the issue. After running the script `misc/post-pve-install.sh` and selecting "disable nag screen", the nag screen is still appearing on a fresh node Proxmox-VE 8.3.0 install when refreshing the packages list in the "Updates" tab. This issue does not happen on my other proxmox nodes (albeit those have not been rebooted after the update) that had run this script before updating to 8.3.0 ### What settings are you currently utilizing? - [X] Default Settings - [ ] Advanced Settings ### Which Linux distribution are you employing? Debian 12 ### If relevant, including screenshots or a code block can be helpful in clarifying the issue. _No response_ ### Please provide detailed steps to reproduce the issue. 1. Install Proxmox-VE 8.2.2 on a new node. 2. Add `pve-no-subscription` repository 4. Upgrade all packages, and thus update to 8.3 5. Run `bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/misc/post-pve-install.sh)"` 6. Answer yes to all questions (select all the options) 7. After the reboot, the nag screen is still showing when refreshing the updatable package list in the "Updates" tab of the node.
OVERLORD added the bug label 2026-02-04 16:33:42 +03:00
OVERLORD commented 2026-02-04 16:33:57 +03:00
Author
Owner
Copy Link

@hautamik commented on GitHub (Nov 21, 2024):

#At the scripts end:

if ! pveversion | grep -Eq "pve-manager/8.[0-2]"; then msg_error "This version of Proxmox Virtual Environment is not supported" echo -e "Requires Proxmox Virtual Environment Version 8.0 or later." echo -e "Exiting..." sleep 2 exit fi

So 8.3 does not qualify, but gives an error. Until that is fixed (and perhaps verified that it really works with 8.3) I downloaded the script, changed [0-2] to [0-3], gave execute permissions and ran it.

Otherwise everything seems to be ok, but the nag is still there.

@hautamik commented on GitHub (Nov 21, 2024): #At the scripts end: `if ! pveversion | grep -Eq "pve-manager/8.[0-2]"; then msg_error "This version of Proxmox Virtual Environment is not supported" echo -e "Requires Proxmox Virtual Environment Version 8.0 or later." echo -e "Exiting..." sleep 2 exit fi` So 8.3 does not qualify, but gives an error. Until that is fixed (and perhaps verified that it _really_ works with 8.3) I downloaded the script, changed [0-2] to [0-3], gave execute permissions and ran it. Otherwise everything seems to be ok, but the nag is still there.
OVERLORD commented 2026-02-04 16:34:01 +03:00
Author
Owner
Copy Link

@hautamik commented on GitHub (Nov 21, 2024):

Apparently proxmox-widget-toolkit has been updated so the current script isn't able to make the changes that were effective earlier. I can live with the reminder (nag, some might call) and wait.

@hautamik commented on GitHub (Nov 21, 2024): Apparently proxmox-widget-toolkit has been updated so the current script isn't able to make the changes that were effective earlier. I can live with the reminder (nag, some might call) and wait.
OVERLORD commented 2026-02-04 16:34:05 +03:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Nov 21, 2024):

8.3 is accessible since today, it takes time to improve such scripts for the new version. ASAP

@MickLesk commented on GitHub (Nov 21, 2024): 8.3 is accessible since today, it takes time to improve such scripts for the new version. ASAP
OVERLORD commented 2026-02-04 16:34:10 +03:00
Author
Owner
Copy Link

@Ajvdhoff commented on GitHub (Nov 22, 2024):

You can disable the nag by commenting out the Ext.Msg.show in the proxmoxlib.js file located in the /usr/share/javascript/proxmox-widget-toolkit/proxmoxlib.js, like i did here (line 566 for me): check @derolli1976 comment for correct code
checked_command: function (orig_cmd) { Proxmox.Utils.API2Request( { url: '/nodes/localhost/subscription', method: 'GET', failure: function (response, opts) { Ext.Msg.alert(gettext('Error'), response.htmlStatus); }, success: function (response, opts) { let res = response.result; if (res === null || res === undefined || !res || res .data.status.toLowerCase() !== 'active') { // Ext.Msg.show({ // title: gettext('No valid subscription'), // icon: Ext.Msg.WARNING, // message: Proxmox.Utils.getNoSubKeyHtml(res.data.url), // buttons: Ext.Msg.OK, // callback: function(btn) { // if (btn !== 'ok') { // return; // } // orig_cmd(); // }, // }); } else { orig_cmd(); } }, }, ); },

@Ajvdhoff commented on GitHub (Nov 22, 2024): You can disable the nag by commenting out the Ext.Msg.show in the proxmoxlib.js file located in the /usr/share/javascript/proxmox-widget-toolkit/proxmoxlib.js, like i did here (line 566 for me): check @derolli1976 comment for correct code ~~```checked_command: function (orig_cmd) { Proxmox.Utils.API2Request( { url: '/nodes/localhost/subscription', method: 'GET', failure: function (response, opts) { Ext.Msg.alert(gettext('Error'), response.htmlStatus); }, success: function (response, opts) { let res = response.result; if (res === null || res === undefined || !res || res .data.status.toLowerCase() !== 'active') { // Ext.Msg.show({ // title: gettext('No valid subscription'), // icon: Ext.Msg.WARNING, // message: Proxmox.Utils.getNoSubKeyHtml(res.data.url), // buttons: Ext.Msg.OK, // callback: function(btn) { // if (btn !== 'ok') { // return; // } // orig_cmd(); // }, // }); } else { orig_cmd(); } }, }, ); },```~~
OVERLORD commented 2026-02-04 16:34:16 +03:00
Author
Owner
Copy Link

@newzealandpaul commented on GitHub (Nov 22, 2024):

@Ajvdhoff can you post or link to the original function without comments. I am trying to figure out why the existing script is not working.

Would also be helpful to post the output of this command:

dpkg -V proxmox-widget-toolkit
@newzealandpaul commented on GitHub (Nov 22, 2024): @Ajvdhoff can you post or link to the original function without comments. I am trying to figure out why the existing script is not working. Would also be helpful to post the output of this command: ``` dpkg -V proxmox-widget-toolkit ```
OVERLORD commented 2026-02-04 16:34:20 +03:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Nov 22, 2024):

i fix the script at the moment. @hautamik can you share me the output of:

cat /usr/share/javascript/proxmox-widget-toolkit/proxmoxlib.js | grep 'data.status'

@MickLesk commented on GitHub (Nov 22, 2024): i fix the script at the moment. @hautamik can you share me the output of: cat /usr/share/javascript/proxmox-widget-toolkit/proxmoxlib.js | grep 'data.status'
OVERLORD commented 2026-02-04 16:34:24 +03:00
Author
Owner
Copy Link

@cbrunnkvist commented on GitHub (Nov 22, 2024):

I just installed a fresh-off-the shelf 8.3 Proxmox VE ISO. Now I'm getting the following error the first time I ran post-pve-install.sh

Start the Proxmox VE Post Install Script (y/n)?y
 ✗ This version of Proxmox Virtual Environment is not supported
Requires Proxmox Virtual Environment Version 8.0 or later.
Exiting...
root@lemox:~# pveversion 
pve-manager/8.3.0/c1689ccb1065a83b (running kernel: 6.8.12-4-pve)
@cbrunnkvist commented on GitHub (Nov 22, 2024): I just installed a fresh-off-the shelf 8.3 Proxmox VE ISO. Now I'm getting the following error the first time I ran [post-pve-install.sh](https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/post-pve-install.sh) ``` Start the Proxmox VE Post Install Script (y/n)?y ✗ This version of Proxmox Virtual Environment is not supported Requires Proxmox Virtual Environment Version 8.0 or later. Exiting... root@lemox:~# pveversion pve-manager/8.3.0/c1689ccb1065a83b (running kernel: 6.8.12-4-pve) ```
OVERLORD commented 2026-02-04 16:34:29 +03:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Nov 22, 2024):

thats already in PR state and need approved by 2 @community-scripts/contributor

@MickLesk commented on GitHub (Nov 22, 2024): thats already in PR state and need approved by 2 @community-scripts/contributor
OVERLORD commented 2026-02-04 16:34:35 +03:00
Author
Owner
Copy Link

@derolli1976 commented on GitHub (Nov 22, 2024):

@Ajvdhoff

			Proxmox.Utils.API2Request(
				{
					url: '/nodes/localhost/subscription',
					method: 'GET',
					failure: function (response, opts) {
						Ext.Msg.alert(gettext('Error'), response.htmlStatus);
					},
					success: function (response, opts) {
						let res = response.result;
						if (res === null || res === undefined || !res || res
							.data.status.toLowerCase() !== 'active') {

  					 	orig_cmd();
  				} else {
  					orig_cmd();
  				}
  			},
  		},
  	);
  },```

You actually commented out a line too much. You need to leave to "orig_cmd();" in the if clause. Otherwise no commands (like "refresh" on the "Updates" page will actually do anything.

@derolli1976 commented on GitHub (Nov 22, 2024): @Ajvdhoff > ``` > Proxmox.Utils.API2Request( > { > url: '/nodes/localhost/subscription', > method: 'GET', > failure: function (response, opts) { > Ext.Msg.alert(gettext('Error'), response.htmlStatus); > }, > success: function (response, opts) { > let res = response.result; > if (res === null || res === undefined || !res || res > .data.status.toLowerCase() !== 'active') { > orig_cmd(); > } else { > orig_cmd(); > } > }, > }, > ); > },``` > ``` You actually commented out a line too much. You need to leave to "orig_cmd();" in the if clause. Otherwise no commands (like "refresh" on the "Updates" page will actually do anything.
OVERLORD commented 2026-02-04 16:34:39 +03:00
Author
Owner
Copy Link

@Coffee0297 commented on GitHub (Nov 22, 2024):

I assume im bumping in to the same issue?
image

@Coffee0297 commented on GitHub (Nov 22, 2024): I assume im bumping in to the same issue? ![image](https://github.com/user-attachments/assets/0d41e5aa-13d3-4d31-9b8c-5743d0ae64da)
OVERLORD commented 2026-02-04 16:34:48 +03:00
Author
Owner
Copy Link

@sammyke007 commented on GitHub (Jan 10, 2025):

It's still showing up, is this normal?

@sammyke007 commented on GitHub (Jan 10, 2025): It's still showing up, is this normal?
OVERLORD commented 2026-02-04 16:34:51 +03:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Jan 10, 2025):

Which Script ?

@MickLesk commented on GitHub (Jan 10, 2025): Which Script ?
OVERLORD commented 2026-02-04 16:34:53 +03:00
Author
Owner
Copy Link

@sammyke007 commented on GitHub (Jan 10, 2025):

Which Script ?

This script:
bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/misc/post-pve-install.sh)"

From:
https://community-scripts.github.io/ProxmoxVE/scripts?id=post-pve-install

I've said YES on every question while running the script.
The script confirms that he nag removal has been run, but the nag kept showing up.
Orrrrr could it have been a browser cache issue?
I've fixed it eventualy with

sed -Ezi.bak "s/(function\(orig_cmd\) \{)/\1\n\torig_cmd\(\);\n\treturn;/g" /usr/share/javascript/proxmox-widget-toolkit/proxmoxlib.js && systemctl restart pveproxy.service

Brand new Proxmox v8.3.0 install.

@sammyke007 commented on GitHub (Jan 10, 2025): > Which Script ? This script: `bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/misc/post-pve-install.sh)"` From: [https://community-scripts.github.io/ProxmoxVE/scripts?id=post-pve-install](https://community-scripts.github.io/ProxmoxVE/scripts?id=post-pve-install) I've said YES on every question while running the script. The script confirms that he nag removal has been run, but the nag kept showing up. Orrrrr could it have been a browser cache issue? I've fixed it eventualy with ` sed -Ezi.bak "s/(function\(orig_cmd\) \{)/\1\n\torig_cmd\(\);\n\treturn;/g" /usr/share/javascript/proxmox-widget-toolkit/proxmoxlib.js && systemctl restart pveproxy.service ` Brand new Proxmox v8.3.0 install.
OVERLORD commented 2026-02-04 16:34:58 +03:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Jan 10, 2025):

Works fine for me and hundert Others ^^ Do you have more nodes

@MickLesk commented on GitHub (Jan 10, 2025): Works fine for me and hundert Others ^^ Do you have more nodes
OVERLORD commented 2026-02-04 16:35:00 +03:00
Author
Owner
Copy Link

@sammyke007 commented on GitHub (Jan 11, 2025):

Works fine for me and hundert Others ^^ Do you have more nodes

I'll be installing a new one in 3 days. I'll report back!

@sammyke007 commented on GitHub (Jan 11, 2025): > Works fine for me and hundert Others ^^ Do you have more nodes I'll be installing a new one in 3 days. I'll report back!
OVERLORD commented 2026-02-04 16:35:05 +03:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Jan 11, 2025):

Please then do an new issue. Because i get 100-200 notifications per day

@MickLesk commented on GitHub (Jan 11, 2025): Please then do an new issue. Because i get 100-200 notifications per day
OVERLORD commented 2026-02-04 16:35:10 +03:00
Author
Owner
Copy Link

@sammyke007 commented on GitHub (Jan 14, 2025):

Please then do an new issue. Because i get 100-200 notifications per day

Was my mistake (cache). Tried it on a new install and it worked 100% OK. Tnx!

@sammyke007 commented on GitHub (Jan 14, 2025): > Please then do an new issue. Because i get 100-200 notifications per day Was my mistake (cache). Tried it on a new install and it worked 100% OK. Tnx!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Implemented in VED waiting push to Main
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
in project pipeline
invalid
investigation
json
maintenance
needs triage
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
🛑 Failure to comply with the guidelines
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ProxmoxVE#89
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?