starred/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-02-05 08:40:11 +03:00
Code Issues 23 Packages Projects Releases 10 Wiki Activity

[PR #4780] [MERGED] Refactor: Remove redundant dependencies & unify unzip usage #4975

New Issue
Closed
opened 2026-02-05 06:37:47 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 06:37:47 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/4780
Author: @MickLesk
Created: 5/28/2025
Status: ✅ Merged
Merged: 5/28/2025
Merged by: @tremor021

Base: main ← Head: remove_deps

📝 Commits (4)

📊 Changes

121 files changed (+276 additions, -368 deletions)

View changed files

📝 ct/2fauth.sh (+71 -71)
📝 ct/adventurelog.sh (+2 -2)
📝 ct/alpine-it-tools.sh (+1 -1)
📝 ct/baikal.sh (+1 -1)
📝 ct/barcode-buddy.sh (+1 -1)
📝 ct/bookstack.sh (+1 -1)
📝 ct/commafeed.sh (+1 -1)
📝 ct/crafty-controller.sh (+1 -1)
📝 ct/documenso.sh (+1 -1)
📝 ct/fileflows.sh (+1 -1)
📝 ct/fluid-calendar.sh (+3 -3)
📝 ct/gotify.sh (+1 -1)
📝 ct/grist.sh (+1 -1)
📝 ct/hoarder.sh (+1 -1)
📝 ct/homeassistant-core.sh (+0 -1)
📝 ct/homeassistant.sh (+0 -1)
📝 ct/karakeep.sh (+1 -1)
📝 ct/kimai.sh (+1 -1)
📝 ct/koillection.sh (+1 -1)
📝 ct/lubelogger.sh (+1 -1)

...and 80 more files

📄 Description

✍️ Description

PR: Remove redundant dependencies & standardize unzip usage

This PR performs a cleanup and unification across multiple install and update scripts:

  • Removed unnecessary packages (gnupg, gpg, unzip) from Alpine- and Debian-based scripts
    → These are already provided via alpine-install.func or install.func
  • Standardized all unzip calls to use: $STD unzip ... for consistent output/logging
  • Cleaned up several install/update scripts to reduce duplication and streamline logic

No behavioral changes; just better consistency and smaller footprints.

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • [] Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/4780 **Author:** [@MickLesk](https://github.com/MickLesk) **Created:** 5/28/2025 **Status:** ✅ Merged **Merged:** 5/28/2025 **Merged by:** [@tremor021](https://github.com/tremor021) **Base:** `main` ← **Head:** `remove_deps` --- ### 📝 Commits (4) - [`e3ac14d`](https://github.com/community-scripts/ProxmoxVE/commit/e3ac14d6b2ae1488e4ab3e85db8acd1971a1ea28) refactor unzip / remove dep - [`8fe1c4c`](https://github.com/community-scripts/ProxmoxVE/commit/8fe1c4c9d2489462bb35403ea6cb7f3e93c9d51d) remove deps from alpine packages - [`ae3f185`](https://github.com/community-scripts/ProxmoxVE/commit/ae3f1850c707b5bce12a700ab4e6a53aaca5e692) remove gnupg - [`7354eaf`](https://github.com/community-scripts/ProxmoxVE/commit/7354eaff05f5e5900c22aaf6fe500bbeaef64b32) remove gnupg ### 📊 Changes **121 files changed** (+276 additions, -368 deletions) <details> <summary>View changed files</summary> 📝 `ct/2fauth.sh` (+71 -71) 📝 `ct/adventurelog.sh` (+2 -2) 📝 `ct/alpine-it-tools.sh` (+1 -1) 📝 `ct/baikal.sh` (+1 -1) 📝 `ct/barcode-buddy.sh` (+1 -1) 📝 `ct/bookstack.sh` (+1 -1) 📝 `ct/commafeed.sh` (+1 -1) 📝 `ct/crafty-controller.sh` (+1 -1) 📝 `ct/documenso.sh` (+1 -1) 📝 `ct/fileflows.sh` (+1 -1) 📝 `ct/fluid-calendar.sh` (+3 -3) 📝 `ct/gotify.sh` (+1 -1) 📝 `ct/grist.sh` (+1 -1) 📝 `ct/hoarder.sh` (+1 -1) 📝 `ct/homeassistant-core.sh` (+0 -1) 📝 `ct/homeassistant.sh` (+0 -1) 📝 `ct/karakeep.sh` (+1 -1) 📝 `ct/kimai.sh` (+1 -1) 📝 `ct/koillection.sh` (+1 -1) 📝 `ct/lubelogger.sh` (+1 -1) _...and 80 more files_ </details> ### 📄 Description ## ✍️ Description ### PR: Remove redundant dependencies & standardize unzip usage This PR performs a cleanup and unification across multiple install and update scripts: - Removed unnecessary packages (`gnupg`, `gpg`, `unzip`) from Alpine- and Debian-based scripts → These are already provided via `alpine-install.func` or `install.func` - Standardized all `unzip` calls to use: `$STD unzip ...` for consistent output/logging - Cleaned up several install/update scripts to reduce duplication and streamline logic No behavioral changes; just better consistency and smaller footprints. ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [] **Tested thoroughly** – Changes work as expected. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [ ] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [x] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 06:37:47 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Implemented in VED waiting push to Main
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
in project pipeline
invalid
investigation
json
maintenance
needs triage
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
🛑 Failure to comply with the guidelines
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ProxmoxVE#4975
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?