starred/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-02-25 11:19:46 +03:00
Code Issues 23 Packages Projects Releases 30 Wiki Activity

[PR #4632] [MERGED] refactor: use binary and randomize credentials in tinyauth #4875

New Issue
Closed
opened 2026-02-05 06:34:50 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 06:34:50 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/4632
Author: @steveiliop56
Created: 5/21/2025
Status: ✅ Merged
Merged: 5/28/2025
Merged by: @michelroegl-brunner

Base: main ← Head: main

📝 Commits (10+)

  • e4194da refactor: use tinyauth binary instead of building
  • 75dd7b6 refactor: refactor header
  • 5ef9509 fix: use v prefix in download
  • e2cf12b refactor: change required ram
  • b02d748 fix: get tinyauth subdomain before spinner
  • 554ea41 fix: download cli in correct path
  • ccd29b3 feat: use secure password
  • 39a8499 chore: use community scripts username
  • 8276eeb fix: fix disk space var
  • 49aacc3 chore: revert name change

📊 Changes

3 files changed (+57 additions, -68 deletions)

View changed files

📝 ct/alpine-tinyauth.sh (+15 -26)
📝 frontend/public/json/alpine-tinyauth.json (+9 -9)
📝 install/alpine-tinyauth-install.sh (+33 -33)

📄 Description

✍️ Description

I just noticed that tinyauth exists here which is amazing. But I noticed that some improvements could be made like using the prebuilt binary I ship and making the default credentials random. Additionally I decided to remove the alpine- prefix from the app and just name it tinyauth.

🔗 Related PR / Issue

None

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

Side note: I noticed that the current implementation with the alpine LXC doesn't autologin. I am not sure if this is related to any changes I made (since the script successfully completes and tinyauth is running) or if there is an issue somewhere else.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/4632 **Author:** [@steveiliop56](https://github.com/steveiliop56) **Created:** 5/21/2025 **Status:** ✅ Merged **Merged:** 5/28/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (10+) - [`e4194da`](https://github.com/community-scripts/ProxmoxVE/commit/e4194da3161600a2e60211239bab41f24026794f) refactor: use tinyauth binary instead of building - [`75dd7b6`](https://github.com/community-scripts/ProxmoxVE/commit/75dd7b6fb9c321366e03f9ba3c641075a342ef4d) refactor: refactor header - [`5ef9509`](https://github.com/community-scripts/ProxmoxVE/commit/5ef95099ef787decd1cdb0e65dbae6371d414412) fix: use v prefix in download - [`e2cf12b`](https://github.com/community-scripts/ProxmoxVE/commit/e2cf12b8b0ca5917cfd8f2b310f38081779221ed) refactor: change required ram - [`b02d748`](https://github.com/community-scripts/ProxmoxVE/commit/b02d748e37b7ab47ac45b43a62c465d676af59b8) fix: get tinyauth subdomain before spinner - [`554ea41`](https://github.com/community-scripts/ProxmoxVE/commit/554ea415fcb7f94f3ff2d7c9a890d7e34499a788) fix: download cli in correct path - [`ccd29b3`](https://github.com/community-scripts/ProxmoxVE/commit/ccd29b329229448b575713e739f880cd5365360a) feat: use secure password - [`39a8499`](https://github.com/community-scripts/ProxmoxVE/commit/39a8499ff7c1725dfe751f703fe92a0542cd87aa) chore: use community scripts username - [`8276eeb`](https://github.com/community-scripts/ProxmoxVE/commit/8276eebf363381b2d2e3192dade304d694403c97) fix: fix disk space var - [`49aacc3`](https://github.com/community-scripts/ProxmoxVE/commit/49aacc32dd7c470923ed8195670011cdd5558964) chore: revert name change ### 📊 Changes **3 files changed** (+57 additions, -68 deletions) <details> <summary>View changed files</summary> 📝 `ct/alpine-tinyauth.sh` (+15 -26) 📝 `frontend/public/json/alpine-tinyauth.json` (+9 -9) 📝 `install/alpine-tinyauth-install.sh` (+33 -33) </details> ### 📄 Description <!--🛑 New scripts must be submitted to [ProxmoxVED](https://github.com/community-scripts/ProxmoxVED) for testing. PRs without prior testing will be closed. --> ## ✍️ Description I just noticed that tinyauth exists here which is amazing. But I noticed that some improvements could be made like using the prebuilt binary I ship and making the default credentials random. Additionally I decided to remove the `alpine-` prefix from the app and just name it `tinyauth`. ## 🔗 Related PR / Issue None ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Changes work as expected. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. *Side note: I noticed that the current implementation with the alpine LXC doesn't autologin. I am not sure if this is related to any changes I made (since the script successfully completes and tinyauth is running) or if there is an issue somewhere else.* --- ## 🛠️ Type of Change (**X** in brackets) - [ ] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [x] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 06:34:50 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Implemented in VED waiting push to Main
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
in project pipeline
invalid
investigation
json
maintenance
needs triage
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
🛑 Failure to comply with the guidelines
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ProxmoxVE#4875
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?