starred/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-02-05 08:40:11 +03:00
Code Issues 23 Packages Projects Releases 10 Wiki Activity

[PR #4102] [MERGED] clean-lxc.sh: cancel/no whiptail support #4559

New Issue
Closed
opened 2026-02-05 06:24:17 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 06:24:17 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/4102
Author: @ManuelDrescher
Created: 4/28/2025
Status: ✅ Merged
Merged: 4/28/2025
Merged by: @michelroegl-brunner

Base: main ← Head: patch-2

📝 Commits (1)

📊 Changes

1 file changed (+5 additions, -0 deletions)

View changed files

📝 tools/pve/clean-lxcs.sh (+5 -0)

📄 Description

Shell option missing, needed to be able to NO/CANCEL the whiptail dialog box. Without it NO/CANCEL is without function and the script will proceed.

This shell option is used in the other scripts, but here it is missing.

Also the needed if-statement is missing.

✍️ Description

🔗 Related PR / Issue

Link: #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/4102 **Author:** [@ManuelDrescher](https://github.com/ManuelDrescher) **Created:** 4/28/2025 **Status:** ✅ Merged **Merged:** 4/28/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `patch-2` --- ### 📝 Commits (1) - [`b0cc6aa`](https://github.com/community-scripts/ProxmoxVE/commit/b0cc6aa7af9d2f36313e9da72b28c3dc162ca31f) Update clean-lxcs.sh ### 📊 Changes **1 file changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `tools/pve/clean-lxcs.sh` (+5 -0) </details> ### 📄 Description Shell option missing, needed to be able to NO/CANCEL the whiptail dialog box. Without it NO/CANCEL is without function and the script will proceed. This shell option is used in the other scripts, but here it is missing. Also the needed if-statement is missing. <!--🛑 New scripts must be submitted to [ProxmoxVED](https://github.com/community-scripts/ProxmoxVED) for testing. PRs without prior testing will be closed. --> ## ✍️ Description ## 🔗 Related PR / Issue Link: # ## ✅ Prerequisites (**X** in brackets) - [X] **Self-review completed** – Code follows project standards. - [X] **Tested thoroughly** – Changes work as expected. - [X] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [X] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 06:24:17 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Implemented in VED waiting push to Main
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
in project pipeline
invalid
investigation
json
maintenance
needs triage
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
🛑 Failure to comply with the guidelines
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ProxmoxVE#4559
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?