starred/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-02-05 00:29:55 +03:00
Code Issues 14 Packages Projects Releases 10 Wiki Activity

Fix Default Logo & also backoff if logo does not load #39

New Issue
Closed
opened 2026-02-04 16:21:11 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 16:21:11 +03:00
Owner
Copy Link

Originally created by @newzealandpaul on GitHub (Nov 13, 2024).

Originally assigned to: @BramSuurdje on GitHub.

Please verify that you have read and understood the guidelines.

yes

A clear and concise description of the issue.

If a logo link breaks in the JSON (either the link is outdated, or there is a typo in the link), the website will continue to to request a logo from this URL:

https://community-scripts.github.io/logo.png

The script will continually pull until the user is rate blocked by github and cannot access the website.

Please provide a description of the expected behavior.

A default logo is shown, no logo will be requested more than once. If it doesn't load, show a placeholder.

If relevant, including screenshots or a code block can be helpful in clarifying the issue.

Screenshot 2024-11-13 at 1 33 31 PM

Please provide detailed steps to reproduce the issue.

Visit a script page, such as:

https://community-scripts.github.io/ProxmoxVE/scripts?id=bookstack

Then using dev tools change the logo address to a url that will 404, then watch in the console as requests are made to https://community-scripts.github.io/logo.png

Originally created by @newzealandpaul on GitHub (Nov 13, 2024). Originally assigned to: @BramSuurdje on GitHub. ### Please verify that you have read and understood the guidelines. yes ### A clear and concise description of the issue. If a logo link breaks in the JSON (either the link is outdated, or there is a typo in the link), the website will continue to to request a logo from this URL: https://community-scripts.github.io/logo.png The script will continually pull until the user is rate blocked by github and cannot access the website. ### Please provide a description of the expected behavior. A default logo is shown, no logo will be requested more than once. If it doesn't load, show a placeholder. ### If relevant, including screenshots or a code block can be helpful in clarifying the issue. <img width="518" alt="Screenshot 2024-11-13 at 1 33 31 PM" src="https://github.com/user-attachments/assets/406ad5c1-b761-4fd5-a0e0-f43c4496fec3"> ### Please provide detailed steps to reproduce the issue. Visit a script page, such as: https://community-scripts.github.io/ProxmoxVE/scripts?id=bookstack Then using dev tools change the logo address to a url that will 404, then watch in the console as requests are made to https://community-scripts.github.io/logo.png
OVERLORD added the website label 2026-02-04 16:21:11 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Implemented in VED waiting push to Main
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
in project pipeline
invalid
investigation
json
maintenance
needs triage
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
🛑 Failure to comply with the guidelines
No Label website
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ProxmoxVE#39
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?