starred/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-02-05 08:40:11 +03:00
Code Issues 23 Packages Projects Releases 10 Wiki Activity

[PR #2286] [MERGED] Fix: CraftyControler fix java default #3539

New Issue
Closed
opened 2026-02-05 05:48:39 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 05:48:39 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/2286
Author: @CrazyWolf13
Created: 2/12/2025
Status: ✅ Merged
Merged: 2/12/2025
Merged by: @michelroegl-brunner

Base: main ← Head: CrazyWolf13-fix-java-default-crafty-controller

📝 Commits (2)

  • 142fe92 fix: fix default java version
  • 5f1643e Merge branch 'community-scripts:main' into CrazyWolf13-fix-java-default-crafty-controller

📊 Changes

1 file changed (+4 additions, -10 deletions)

View changed files

📝 install/crafty-controller-install.sh (+4 -10)

📄 Description

✍️ Description

This PR should finally fix an issue with crafty not correctly picking up the java path, as it runs within it's own user and own env.

🔗 Related PR / Discussion / Issue

Link: #2237

✅ Prerequisites

Before this PR can be reviewed, the following must be completed:

  • Self-review performed – Code follows established patterns and conventions.
  • Testing performed – Changes have been thoroughly tested and verified.

🛠️ Type of Change

Select all that apply:

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • [] ✨ New feature – Adds new, non-breaking functionality.
  • [] 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • [] 🆕 New script – A fully functional and tested script or script set.

📋 Additional Information (optional)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/2286 **Author:** [@CrazyWolf13](https://github.com/CrazyWolf13) **Created:** 2/12/2025 **Status:** ✅ Merged **Merged:** 2/12/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `CrazyWolf13-fix-java-default-crafty-controller` --- ### 📝 Commits (2) - [`142fe92`](https://github.com/community-scripts/ProxmoxVE/commit/142fe9212f8f74bff25a9ae1132f2bf9a240f67d) fix: fix default java version - [`5f1643e`](https://github.com/community-scripts/ProxmoxVE/commit/5f1643e80ca5b2647981014d685d6f211b9c1e0e) Merge branch 'community-scripts:main' into CrazyWolf13-fix-java-default-crafty-controller ### 📊 Changes **1 file changed** (+4 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `install/crafty-controller-install.sh` (+4 -10) </details> ### 📄 Description ## ✍️ Description <!-- Provide a clear and concise description of your changes. --> This PR should finally fix an issue with crafty not correctly picking up the java path, as it runs within it's own user and own env. ## 🔗 Related PR / Discussion / Issue Link: #2237 ## ✅ Prerequisites Before this PR can be reviewed, the following must be completed: - [X] **Self-review performed** – Code follows established patterns and conventions. - [X] **Testing performed** – Changes have been thoroughly tested and verified. ## 🛠️ Type of Change Select all that apply: - [X] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [] ✨ **New feature** – Adds new, non-breaking functionality. - [] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [] 🆕 **New script** – A fully functional and tested script or script set. ## 📋 Additional Information (optional) <!-- Provide extra context, screenshots, or references if needed. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 05:48:39 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Implemented in VED waiting push to Main
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
in project pipeline
invalid
investigation
json
maintenance
needs triage
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
🛑 Failure to comply with the guidelines
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ProxmoxVE#3539
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?