starred/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-02-05 00:29:55 +03:00
Code Issues 11 Packages Projects Releases 10 Wiki Activity

Proxmox VE CPU Scaling Governor overwrites Crontab Comment Header #349

New Issue
Closed
opened 2026-02-04 18:08:35 +03:00 by OVERLORD · 3 comments
OVERLORD commented 2026-02-04 18:08:35 +03:00
Owner
Copy Link

Originally created by @jarvisca on GitHub (Jan 19, 2025).

✅ Have you read and understood the above guidelines?

yes

📜 What is the name of the script you are using?

Proxmox VE CPU Scaling Governor

📂 What was the exact command used to execute the script?

bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/misc/scaling-governor.sh)"

📝 Provide a clear and concise description of the issue.

The Proxmox VE CPU Scaling Governor overwrites the existing crontab comment header on install on Proxmox 8.32.

Prior to running the script, the contents of crontab are:

# Edit this file to introduce tasks to be run by cron.
# 
# Each task to run has to be defined through a single line
# indicating with different fields when the task will be run
# and what command to run for the task
# 
# To define the time you can provide concrete values for
# minute (m), hour (h), day of month (dom), month (mon),
# and day of week (dow) or use '*' in these fields (for 'any').
# 
# Notice that tasks will be started based on the cron's system
# daemon's notion of time and timezones.
# 
# Output of the crontab jobs (including errors) is sent through
# email to the user the crontab file belongs to (unless redirected).
# 
# For example, you can run a backup of all your user accounts
# at 5 a.m every week with:
# 0 5 * * 1 tar -zcf /var/backups/home.tgz /home/
# 
# For more information see the manual pages of crontab(5) and cron(8)
# 
# m h  dom mon dow   command

After running the script, crontab -e shows:

@reboot (sleep 60 && echo "powersave" | tee /sys/devices/system/cpu/cpu*/cpufreq/scaling_governor)

Suggested that crontab -e should show:

# Edit this file to introduce tasks to be run by cron.
# 
# Each task to run has to be defined through a single line
# indicating with different fields when the task will be run
# and what command to run for the task
# 
# To define the time you can provide concrete values for
# minute (m), hour (h), day of month (dom), month (mon),
# and day of week (dow) or use '*' in these fields (for 'any').
# 
# Notice that tasks will be started based on the cron's system
# daemon's notion of time and timezones.
# 
# Output of the crontab jobs (including errors) is sent through
# email to the user the crontab file belongs to (unless redirected).
# 
# For example, you can run a backup of all your user accounts
# at 5 a.m every week with:
# 0 5 * * 1 tar -zcf /var/backups/home.tgz /home/
# 
# For more information see the manual pages of crontab(5) and cron(8)
# 
# m h  dom mon dow   command
@reboot (sleep 60 && echo "powersave" | tee /sys/devices/system/cpu/cpu*/cpufreq/scaling_governor)

⚙️ What settings are you using?

  • Default Settings
  • Advanced Settings

🖥️ Which Linux distribution are you using?

Debian 12

🔄 Steps to reproduce the issue.

  1. View crontab.
    crontab -e
  2. Run command at Proxmox PVE prompt.bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/misc/scaling-governor.sh)"
  3. View changes to crontab.
    crontab -e

❌ Paste the full error output (if available).

Not applicable

🖼️ Additional context (optional).

No response

Originally created by @jarvisca on GitHub (Jan 19, 2025). ### ✅ Have you read and understood the above guidelines? yes ### 📜 What is the name of the script you are using? Proxmox VE CPU Scaling Governor ### 📂 What was the exact command used to execute the script? bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/misc/scaling-governor.sh)" ### 📝 Provide a clear and concise description of the issue. The Proxmox VE CPU Scaling Governor overwrites the existing crontab comment header on install on Proxmox 8.32. Prior to running the script, the contents of crontab are: ``` # Edit this file to introduce tasks to be run by cron. # # Each task to run has to be defined through a single line # indicating with different fields when the task will be run # and what command to run for the task # # To define the time you can provide concrete values for # minute (m), hour (h), day of month (dom), month (mon), # and day of week (dow) or use '*' in these fields (for 'any'). # # Notice that tasks will be started based on the cron's system # daemon's notion of time and timezones. # # Output of the crontab jobs (including errors) is sent through # email to the user the crontab file belongs to (unless redirected). # # For example, you can run a backup of all your user accounts # at 5 a.m every week with: # 0 5 * * 1 tar -zcf /var/backups/home.tgz /home/ # # For more information see the manual pages of crontab(5) and cron(8) # # m h dom mon dow command ``` After running the script, crontab -e shows: `@reboot (sleep 60 && echo "powersave" | tee /sys/devices/system/cpu/cpu*/cpufreq/scaling_governor)` Suggested that crontab -e should show: ``` # Edit this file to introduce tasks to be run by cron. # # Each task to run has to be defined through a single line # indicating with different fields when the task will be run # and what command to run for the task # # To define the time you can provide concrete values for # minute (m), hour (h), day of month (dom), month (mon), # and day of week (dow) or use '*' in these fields (for 'any'). # # Notice that tasks will be started based on the cron's system # daemon's notion of time and timezones. # # Output of the crontab jobs (including errors) is sent through # email to the user the crontab file belongs to (unless redirected). # # For example, you can run a backup of all your user accounts # at 5 a.m every week with: # 0 5 * * 1 tar -zcf /var/backups/home.tgz /home/ # # For more information see the manual pages of crontab(5) and cron(8) # # m h dom mon dow command @reboot (sleep 60 && echo "powersave" | tee /sys/devices/system/cpu/cpu*/cpufreq/scaling_governor) ``` ### ⚙️ What settings are you using? - [x] Default Settings - [ ] Advanced Settings ### 🖥️ Which Linux distribution are you using? Debian 12 ### 🔄 Steps to reproduce the issue. 1. View crontab. `crontab -e` 3. Run command at Proxmox PVE prompt.`bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/misc/scaling-governor.sh)"` 4. View changes to crontab. `crontab -e` ### ❌ Paste the full error output (if available). Not applicable ### 🖼️ Additional context (optional). _No response_
OVERLORD added the not a script issue label 2026-02-04 18:08:35 +03:00
OVERLORD commented 2026-02-04 18:08:57 +03:00
Author
Owner
Copy Link

@michelroegl-brunner commented on GitHub (Jan 19, 2025):

you mean, the comments get deleted?

@michelroegl-brunner commented on GitHub (Jan 19, 2025): you mean, the comments get deleted?
OVERLORD commented 2026-02-04 18:09:11 +03:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Jan 19, 2025):

And what is the problem here? This is a universal tool, i.e. Debian 11, 12, Ubuntu 22.04/24.04/24.10

In the case of other different cron comments, this would lead to breaks in the script. Why does that bother you? After all, it has been running like this for 4 years.

@MickLesk commented on GitHub (Jan 19, 2025): And what is the problem here? This is a universal tool, i.e. Debian 11, 12, Ubuntu 22.04/24.04/24.10 In the case of other different cron comments, this would lead to breaks in the script. Why does that bother you? After all, it has been running like this for 4 years.
OVERLORD commented 2026-02-04 18:09:22 +03:00
Author
Owner
Copy Link

@jarvisca commented on GitHub (Jan 19, 2025):

I guess I expect to see comments in system configuration files. I know it doesn't matter to the system but there is value to the administrator in reading the comments.

In this case an admin will return to this file to add additional tasks and the examples and particularly the order of the minute (m), hour (h), day of month (dom), month (mon), and day of week (dow) are valuable information to double check their commands.

If it's not there, they will need to refer to the man pages or look it up elsewhere. It just adds another step if the comments are removed before the administrator has decided they no longer need them.

@jarvisca commented on GitHub (Jan 19, 2025): I guess I expect to see comments in system configuration files. I know it doesn't matter to the system but there is value to the administrator in reading the comments. In this case an admin will return to this file to add additional tasks and the examples and particularly the order of the minute (m), hour (h), day of month (dom), month (mon), and day of week (dow) are valuable information to double check their commands. If it's not there, they will need to refer to the man pages or look it up elsewhere. It just adds another step if the comments are removed before the administrator has decided they no longer need them.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Implemented in VED waiting push to Main
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
in project pipeline
invalid
investigation
json
maintenance
needs triage
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
🛑 Failure to comply with the guidelines
No Label not a script issue
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ProxmoxVE#349
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?