starred/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-02-25 03:10:58 +03:00
Code Issues 23 Packages Projects Releases 30 Wiki Activity

[BUG] AdventureLog update does not update #299

New Issue
Closed
opened 2026-02-04 17:50:44 +03:00 by OVERLORD · 6 comments
OVERLORD commented 2026-02-04 17:50:44 +03:00
Owner
Copy Link

Originally created by @JesperDramsch on GitHub (Jan 8, 2025).

✅ Have you read and understood the above guidelines?

yes

📜 What is the name of the script you are using?

AdventureLog

📂 What was the exact command used to execute the script?

update

📝 Provide a clear and concise description of the issue.

The adventurelog update script does not correctly update the script on the LXC.

Issue in Update script

I have identified the issue to be in the update script.
This line: e1daaa6409/ct/adventurelog.sh (L47)

moves the folder AdventureLog-v.0.8.0 into the folder, but the intention is to update the files.

Comparison to other scripts

Other scripts either use tar to directly or unzip and then rm -rf the existing installation:
e1daaa6409/ct/wallos.sh (L44)

or move the app to a backup location:
e1daaa6409/ct/part-db.sh (L43)

Caveats with AdentureLog

AdventureLog has user-generated data in /opt/adventurelog which needs to be migrated. I only found the media folder in the backend but there could be more. So these additional files have to be handled correctly.

⚙️ What settings are you using?

  • Default Settings
  • Advanced Settings

🖥️ Which Linux distribution are you using?

Debian 12

🔄 Steps to reproduce the issue.

  1. Install version 0.7.1.
  2. Type update

❌ Paste the full error output (if available).

No error, just a non-updated app.

🖼️ Additional context (optional).

I technically used an advanced installation for a different number and I have changed the IP by hand as per the guide. This does not show in the fancy Proxmox information unfortunately.

But everything else is default.

Originally created by @JesperDramsch on GitHub (Jan 8, 2025). ### ✅ Have you read and understood the above guidelines? yes ### 📜 What is the name of the script you are using? AdventureLog ### 📂 What was the exact command used to execute the script? update ### 📝 Provide a clear and concise description of the issue. The adventurelog update script does not correctly update the script on the LXC. ### Issue in Update script I have identified the issue to be in the update script. This line: https://github.com/community-scripts/ProxmoxVE/blob/e1daaa6409d257314b29833bef1206da2f45aded/ct/adventurelog.sh#L47 moves the folder AdventureLog-v.0.8.0 into the folder, but the intention is to update the files. ### Comparison to other scripts Other scripts either use tar to directly or unzip and then `rm -rf` the existing installation: https://github.com/community-scripts/ProxmoxVE/blob/e1daaa6409d257314b29833bef1206da2f45aded/ct/wallos.sh#L44 or move the app to a backup location: https://github.com/community-scripts/ProxmoxVE/blob/e1daaa6409d257314b29833bef1206da2f45aded/ct/part-db.sh#L43 ### Caveats with AdentureLog AdventureLog has user-generated data in `/opt/adventurelog` which needs to be migrated. I only found the `media` folder in the backend but there could be more. So these additional files have to be handled correctly. ### ⚙️ What settings are you using? - [X] Default Settings - [X] Advanced Settings ### 🖥️ Which Linux distribution are you using? Debian 12 ### 🔄 Steps to reproduce the issue. 1. Install version 0.7.1. 2. Type `update` ### ❌ Paste the full error output (if available). No error, just a non-updated app. ### 🖼️ Additional context (optional). I technically used an advanced installation for a different number and I have changed the IP by hand as per the guide. This does not show in the fancy Proxmox information unfortunately. But everything else is default.
OVERLORD commented 2026-02-04 17:50:55 +03:00
Author
Owner
Copy Link

@oOStroudyOo commented on GitHub (Jan 8, 2025):

So

    unzip -q v${RELEASE}.zip
    mv AdventureLog-${RELEASE} /opt/adventurelog

Becomes

    unzip -q v${RELEASE}.zip
    rm -rf /opt/adventurelog
    mv AdventureLog-${RELEASE} /opt/adventurelog
@oOStroudyOo commented on GitHub (Jan 8, 2025): So ``` unzip -q v${RELEASE}.zip mv AdventureLog-${RELEASE} /opt/adventurelog ``` Becomes ``` unzip -q v${RELEASE}.zip rm -rf /opt/adventurelog mv AdventureLog-${RELEASE} /opt/adventurelog ```
OVERLORD commented 2026-02-04 17:51:00 +03:00
Author
Owner
Copy Link

@JesperDramsch commented on GitHub (Jan 8, 2025):

Only if you want to delete all your media for adventures.

@JesperDramsch commented on GitHub (Jan 8, 2025): Only if you want to delete all your media for adventures.
OVERLORD commented 2026-02-04 17:51:07 +03:00
Author
Owner
Copy Link

@JesperDramsch commented on GitHub (Jan 8, 2025):

I have written a backup script for myself that is specific to the Proxmox LXC configuration. Not sure if this would be useful, and it of course also doesn't include any future updates to save locations:

#!/bin/bash

# Load environment variables
source /opt/adventurelog/backend/server/.env

# Configuration
BACKUP_DIR="$PWD"
MEDIA_DIR="/opt/adventurelog/backend/server/media"
DATE=$(date +%Y-%m-%d_%H-%M-%S)
TEMP_DIR=$(mktemp -d)

# Backup PostgreSQL database
echo "Backing up PostgreSQL database..."
PGPASSWORD="$PGPASSWORD" pg_dump -h "$PGHOST" -U "$PGUSER" -Fc "$PGDATABASE" > "$TEMP_DIR/db_backup.dump"

# Backup media files
echo "Backing up media files..."
tar -czf "$TEMP_DIR/media_backup.tar.gz" "$MEDIA_DIR"

# Backup .env files
echo "Backing up environment configurations..."
cp /opt/adventurelog/backend/server/.env "$TEMP_DIR/server.env"
cp /opt/adventurelog/frontend/.env "$TEMP_DIR/frontend.env"

# Create final tar archive
echo "Creating final backup archive..."
tar -czf "$BACKUP_DIR/adventurelog_backup_$DATE.tar.gz" -C "$TEMP_DIR" .

# Cleanup temporary directory
rm -rf "$TEMP_DIR"

echo "Backup completed successfully! Created: adventurelog_backup_$DATE.tar.gz"
@JesperDramsch commented on GitHub (Jan 8, 2025): I have written a backup script for myself that is specific to the Proxmox LXC configuration. Not sure if this would be useful, and it of course also doesn't include any future updates to save locations: ```bash #!/bin/bash # Load environment variables source /opt/adventurelog/backend/server/.env # Configuration BACKUP_DIR="$PWD" MEDIA_DIR="/opt/adventurelog/backend/server/media" DATE=$(date +%Y-%m-%d_%H-%M-%S) TEMP_DIR=$(mktemp -d) # Backup PostgreSQL database echo "Backing up PostgreSQL database..." PGPASSWORD="$PGPASSWORD" pg_dump -h "$PGHOST" -U "$PGUSER" -Fc "$PGDATABASE" > "$TEMP_DIR/db_backup.dump" # Backup media files echo "Backing up media files..." tar -czf "$TEMP_DIR/media_backup.tar.gz" "$MEDIA_DIR" # Backup .env files echo "Backing up environment configurations..." cp /opt/adventurelog/backend/server/.env "$TEMP_DIR/server.env" cp /opt/adventurelog/frontend/.env "$TEMP_DIR/frontend.env" # Create final tar archive echo "Creating final backup archive..." tar -czf "$BACKUP_DIR/adventurelog_backup_$DATE.tar.gz" -C "$TEMP_DIR" . # Cleanup temporary directory rm -rf "$TEMP_DIR" echo "Backup completed successfully! Created: adventurelog_backup_$DATE.tar.gz" ```
OVERLORD commented 2026-02-04 17:51:08 +03:00
Author
Owner
Copy Link

@Aloe-recite commented on GitHub (Jan 8, 2025):

same issue here

@Aloe-recite commented on GitHub (Jan 8, 2025): same issue here
OVERLORD commented 2026-02-04 17:51:23 +03:00
Author
Owner
Copy Link

@JesperDramsch commented on GitHub (Jan 8, 2025):

I have submitted a PR to fix the update script.

If this gets accepted, that means that you have to go into your Proxmox LXC and before updating, change the version number in /opt/AdventureLogs_version.txt, which will incorrectly show 0.8.0 now. Then you should be able to run update as expected.

@JesperDramsch commented on GitHub (Jan 8, 2025): I have submitted a PR to fix the update script. If this gets accepted, that means that you have to go into your Proxmox LXC and before updating, change the version number in `/opt/AdventureLogs_version.txt`, which will incorrectly show `0.8.0` now. Then you should be able to run `update` as expected.
OVERLORD commented 2026-02-04 17:51:30 +03:00
Author
Owner
Copy Link

@Aloe-recite commented on GitHub (Jan 8, 2025):

great, much appreciated!

@Aloe-recite commented on GitHub (Jan 8, 2025): great, much appreciated!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Implemented in VED waiting push to Main
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
in project pipeline
invalid
investigation
json
maintenance
needs triage
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
🛑 Failure to comply with the guidelines
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ProxmoxVE#299
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?