starred/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-01 11:19:48 +03:00
Code Issues 23 Packages Projects Releases 34 Wiki Activity

[PR #1107] [MERGED] fix: add homepage version during build step #2885

New Issue
Closed
opened 2026-02-05 05:18:43 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 05:18:43 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/1107
Author: @se-bastiaan
Created: 12/30/2024
Status: ✅ Merged
Merged: 12/30/2024
Merged by: @MickLesk

Base: main ← Head: fix/homepage-version

📝 Commits (4)

  • 638783e Set homepage version during build in ct script
  • 702f837 Change install script
  • 9d57f13 Split commands to multiple lines for ct script as well
  • 0078b94 Make sure shellcheck is happy

📊 Changes

2 files changed (+3 additions, -3 deletions)

View changed files

📝 ct/homepage.sh (+2 -2)
📝 install/homepage-install.sh (+1 -1)

📄 Description

✍️ Description

Closes #1062

This pull request includes updates to the build process for the homepage application. The changes ensure that environment variables are set during the build process to include version and revision information.

Build process updates:

  • ct/homepage.sh: Modified the update_script function to include NEXT_PUBLIC_VERSION and NEXT_PUBLIC_REVISION environment variables during the pnpm build step.
  • install/homepage-install.sh: Updated the install script to set NEXT_PUBLIC_VERSION and NEXT_PUBLIC_REVISION environment variables during the pnpm build step.

🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)
  • Documentation updated (I have updated any relevant documentation)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/1107 **Author:** [@se-bastiaan](https://github.com/se-bastiaan) **Created:** 12/30/2024 **Status:** ✅ Merged **Merged:** 12/30/2024 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `fix/homepage-version` --- ### 📝 Commits (4) - [`638783e`](https://github.com/community-scripts/ProxmoxVE/commit/638783edae7159018abf7ceb6f011058cf05a345) Set homepage version during build in ct script - [`702f837`](https://github.com/community-scripts/ProxmoxVE/commit/702f83781214fc9fa2e3e737d205addc0c999f8c) Change install script - [`9d57f13`](https://github.com/community-scripts/ProxmoxVE/commit/9d57f13c0888d0ba78d96b1a20311866731c1f28) Split commands to multiple lines for ct script as well - [`0078b94`](https://github.com/community-scripts/ProxmoxVE/commit/0078b94c404f9bcc9aefc24c5641554ddae5a633) Make sure shellcheck is happy ### 📊 Changes **2 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `ct/homepage.sh` (+2 -2) 📝 `install/homepage-install.sh` (+1 -1) </details> ### 📄 Description ## ✍️ Description Closes #1062 This pull request includes updates to the build process for the homepage application. The changes ensure that environment variables are set during the build process to include version and revision information. Build process updates: * [`ct/homepage.sh`](diffhunk://#diff-5e706703158f4b406e5cb906477e30a8eae0a623969866bf7d1f46fdcea69201L55-R55): Modified the `update_script` function to include `NEXT_PUBLIC_VERSION` and `NEXT_PUBLIC_REVISION` environment variables during the `pnpm build` step. * [`install/homepage-install.sh`](diffhunk://#diff-c29df5fa995f8f78893b692af5fbd9ef3b3b531741df232aecb876f98194e583L46-R46): Updated the install script to set `NEXT_PUBLIC_VERSION` and `NEXT_PUBLIC_REVISION` environment variables during the `pnpm build` step. - - - - Related Issue: #1062 --- ## 🛠️ Type of Change Please check the relevant options: - [x] Bug fix (non-breaking change that resolves an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts) --- ## ✅ Prerequisites The following steps must be completed for the pull request to be considered: - [x] Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.) - [x] Testing performed (I have thoroughly tested my changes and verified expected functionality.) - [x] Documentation updated (I have updated any relevant documentation) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 05:18:43 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Implemented in VED waiting push to Main
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
in project pipeline
invalid
investigation
json
maintenance
needs triage
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
🛑 Failure to comply with the guidelines
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ProxmoxVE#2885
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?