starred/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-02-05 00:29:55 +03:00
Code Issues 14 Packages Projects Releases 10 Wiki Activity

[PR #906] [CLOSED] [DRAFT FOR DISCUSSION] Support for helper-scripts environment variables #2801

New Issue
Closed
opened 2026-02-05 05:14:10 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 05:14:10 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/906
Author: @remz1337
Created: 12/18/2024
Status: ❌ Closed

Base: main ← Head: phs-env-var

📝 Commits (2)

  • 0e3a648 Support for helper-scripts environment variables
  • 610eff3 Only read from the environment file. Users should manually edit the file.

📊 Changes

1 file changed (+25 additions, -6 deletions)

View changed files

📝 misc/build.func (+25 -6)

📄 Description

🛠️ Note:
We are meticulous about merging code into the main branch, so please understand that pull requests not meeting the project's standards may be rejected. It's never personal!
🎮 Note for game-related scripts: These have a lower likelihood of being merged.

✍️ Description

This is a draft PR, following some ideas we had discussed over Discord a few weeks ago. It was also requested by a few users (can't recall where)

Idea is to be able to save/reuse come configurations/parameters. I'm using a configuration file in /etc/pve-helper-scripts.conf to store the variables, and load them in memory when calling install_script function.

Variables are stored like this in the config file:

APT_CACHER_IP='192.168.1.123'
SSH_USER='admin'
SSH_PASSWORD='$1$PCdmJEPa$.YOlH8I4qBP15r7LV8Ho50'

🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)
  • Documentation updated (I have updated any relevant documentation)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/906 **Author:** [@remz1337](https://github.com/remz1337) **Created:** 12/18/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `phs-env-var` --- ### 📝 Commits (2) - [`0e3a648`](https://github.com/community-scripts/ProxmoxVE/commit/0e3a648f40255f9c085448f4144b77686947b4fe) Support for helper-scripts environment variables - [`610eff3`](https://github.com/community-scripts/ProxmoxVE/commit/610eff3d2adca299632466e2fb7efe961ff6002b) Only read from the environment file. Users should manually edit the file. ### 📊 Changes **1 file changed** (+25 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `misc/build.func` (+25 -6) </details> ### 📄 Description > **🛠️ Note:** > We are meticulous about merging code into the main branch, so please understand that pull requests not meeting the project's standards may be rejected. It's never personal! > 🎮 **Note for game-related scripts:** These have a lower likelihood of being merged. --- ## ✍️ Description This is a draft PR, following some ideas we had discussed over Discord a few weeks ago. It was also requested by a few users (can't recall where) Idea is to be able to save/reuse come configurations/parameters. I'm using a configuration file in `/etc/pve-helper-scripts.conf` to store the variables, and load them in memory when calling `install_script` function. Variables are stored like this in the config file: ``` APT_CACHER_IP='192.168.1.123' SSH_USER='admin' SSH_PASSWORD='$1$PCdmJEPa$.YOlH8I4qBP15r7LV8Ho50' ``` --- ## 🛠️ Type of Change Please check the relevant options: - [ ] Bug fix (non-breaking change that resolves an issue) - [X] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts) --- ## ✅ Prerequisites The following steps must be completed for the pull request to be considered: - [X] Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.) - [ ] Testing performed (I have thoroughly tested my changes and verified expected functionality.) - [ ] Documentation updated (I have updated any relevant documentation) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 05:14:10 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Implemented in VED waiting push to Main
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
in project pipeline
invalid
investigation
json
maintenance
needs triage
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
🛑 Failure to comply with the guidelines
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ProxmoxVE#2801
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?