starred/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-02-05 00:29:55 +03:00
Code Issues 13 Packages Projects Releases 10 Wiki Activity

[PR #643] [MERGED] Massive Update: build.func | install.func | create_lxc.sh (Part 1) #2689

New Issue
Closed
opened 2026-02-05 05:08:05 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 05:08:05 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/643
Author: @MickLesk
Created: 12/2/2024
Status: ✅ Merged
Merged: 12/16/2024
Merged by: @MickLesk

Base: main ← Head: rework_core

📝 Commits (10+)

📊 Changes

5 files changed (+436 additions, -174 deletions)

View changed files

📝 ct/alpine.sh (+1 -1)
📝 ct/create_lxc.sh (+34 -15)
📝 misc/alpine-install.func (+73 -15)
📝 misc/build.func (+248 -113)
📝 misc/install.func (+80 -30)

📄 Description

Description

Massive Update on the core dependencies.

It is probably the biggest update in a long time.

The following points are now implemented, I split it into features / changes and bugfixes

Features:

  • It is now possible to tag CT.sh files, these tags are then transferred to Proxmox.
  • Extended MOTD
  • Base-Default Settings on CT.sh (these can be overridden or changed, but not all values)
  • Ping against iPV4 and iPV6 Extended
  • Color UI and UX optimized and brought up to date (Default Settings/ Advanced Settings / Cross / Checkmark)
  • Spinner updated
  • Ubuntu 24.10 added
  • alpine-install improved
  • alpine switch to stable 3.20 pveam file

Changes:

  • Streamlined CT.sh (old ones still work!)
  • Query despite system resources (nevertheless update...?)
  • Whiptail dialog adapted
  • Preparation for Fedora, CentOS, RockLinux, AlmaLinux & openSUSE installations (these are possible via pvestream and should be possible as “simple LXC's”).

Bugfixes:

  • Generally better error handling
  • Variable declaration cleanly implemented
  • echo output optimized

What is currently still missing:

  • Implementation for Alpine (alpine-install.func) -> ASAP
  • Calling variables (e.g. bash -c LINK - VERBOSE) to start a script directly in verbose mode.
  • A clean template as script preparation. Much is made easier. My example script: koel_old.sh (old installation method) has a total of 109 lines and 2855 characters. The new method (koel_new.sh) has 75 lines and 2203 characters, which is about 23% code savings.
  • Adapt all CT.sh to the new version (I can do this for EVERYONE if you want)

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)
  • Documentation updated (I have updated any relevant documentation)

Related Pull Requests / Discussions

If there are other pull requests or discussions related to this change, please link them here:

koel_new.sh: (koel_old.sh same output)
image

koel_full.sh (other size, version, os, verbose)
image

MOTD:
image

TAGS:
image

You are welcome to test it on my DEV repo, please note that not all scripts are functional.
All my tests i do with this 5 Scripts:

  • koel_full
  • koel_new
  • koel_old
  • koel_without_base
  • nextpvr
bash -c "$(wget -qLO - https://raw.githubusercontent.com/MickLesk/Proxmox_DEV/refs/heads/main/ct/koel_new.sh)"
bash -c "$(wget -qLO - https://raw.githubusercontent.com/MickLesk/Proxmox_DEV/refs/heads/main/ct/koel_old.sh)"
bash -c "$(wget -qLO - https://raw.githubusercontent.com/MickLesk/Proxmox_DEV/refs/heads/main/ct/koel_full.sh)"
bash -c "$(wget -qLO - https://raw.githubusercontent.com/MickLesk/Proxmox_DEV/refs/heads/main/ct/koel_without_base.sh)"
bash -c "$(wget -qLO - https://raw.githubusercontent.com/MickLesk/Proxmox_DEV/refs/heads/main/ct/nextpvr.sh)"

=> koel_without_base should abort because there is not enough memory. This was an extra scenario for aborting.
=> PS: "update" for koel not working yet, its in active development

I have prepared 4 variants for koel. But the following should also work:

  • ampache
  • hoodik
  • nodebb (idk)
  • scrutiny
  • urbackup

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/643 **Author:** [@MickLesk](https://github.com/MickLesk) **Created:** 12/2/2024 **Status:** ✅ Merged **Merged:** 12/16/2024 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `rework_core` --- ### 📝 Commits (10+) - [`99fdc2f`](https://github.com/community-scripts/ProxmoxVE/commit/99fdc2f17ec824739ca7517598cfa4d77afa7da1) Big Update: Build.func Install.Func Create_LXC - [`4f521d4`](https://github.com/community-scripts/ProxmoxVE/commit/4f521d4b287ab921b64ec22a0c80d301d88ff1ae) Change Author - [`d07274c`](https://github.com/community-scripts/ProxmoxVE/commit/d07274ce7b786c7c99eb4adffaf31154e832d1a4) Fix indentation / naming / echos - [`81d5b16`](https://github.com/community-scripts/ProxmoxVE/commit/81d5b163a6ff70dad6f748130777a48f8c2499fb) Merge branch 'rework_core' of https://github.com/community-scripts/ProxmoxVE into rework_core - [`addb48b`](https://github.com/community-scripts/ProxmoxVE/commit/addb48bd52f43f04201df7071c7c3dd829712b57) Fix some Parts - [`852ab60`](https://github.com/community-scripts/ProxmoxVE/commit/852ab6065f5117d228a5a5b6cba63dff562735a8) Add alpine-install.func - [`11e1768`](https://github.com/community-scripts/ProxmoxVE/commit/11e1768e78e5b019640dd1babc80a70caaaa4d18) update alpine to 3.20 - [`30bf69c`](https://github.com/community-scripts/ProxmoxVE/commit/30bf69c5e569600192c20eeb02dbc6394edb3be1) fix spaces - [`945d55f`](https://github.com/community-scripts/ProxmoxVE/commit/945d55f4234b8d669a6f7170ceab6ef87d2a726b) Update build.func - [`7779b1e`](https://github.com/community-scripts/ProxmoxVE/commit/7779b1e0040e1b2de8559b05e9cb890b36df7d9e) Merge Create_LXC from DEV ### 📊 Changes **5 files changed** (+436 additions, -174 deletions) <details> <summary>View changed files</summary> 📝 `ct/alpine.sh` (+1 -1) 📝 `ct/create_lxc.sh` (+34 -15) 📝 `misc/alpine-install.func` (+73 -15) 📝 `misc/build.func` (+248 -113) 📝 `misc/install.func` (+80 -30) </details> ### 📄 Description ## Description Massive Update on the core dependencies. It is probably the biggest update in a long time. The following points are now implemented, I split it into features / changes and bugfixes ### **Features:** - It is now possible to tag CT.sh files, these tags are then transferred to Proxmox. - Extended MOTD - Base-Default Settings on CT.sh (these can be overridden or changed, but not all values) - Ping against iPV4 and iPV6 Extended - Color UI and UX optimized and brought up to date (Default Settings/ Advanced Settings / Cross / Checkmark) - Spinner updated - Ubuntu 24.10 added - alpine-install improved - alpine switch to stable 3.20 pveam file ### **Changes:** - Streamlined CT.sh (old ones still work!) - Query despite system resources (nevertheless update...?) - Whiptail dialog adapted - Preparation for Fedora, CentOS, RockLinux, AlmaLinux & openSUSE installations (these are possible via pvestream and should be possible as “simple LXC's”). ### **Bugfixes:** - Generally better error handling - Variable declaration cleanly implemented - echo output optimized ### **What is currently still missing:** - Implementation for Alpine (alpine-install.func) -> ASAP - Calling variables (e.g. bash -c LINK - VERBOSE) to start a script directly in verbose mode. - A clean template as script preparation. Much is made easier. My example script: koel_old.sh (old installation method) has a total of 109 lines and 2855 characters. The new method (koel_new.sh) has 75 lines and 2203 characters, which is about 23% code savings. - Adapt all CT.sh to the new version (I can do this for EVERYONE if you want) Fixes # (issue) ## Type of change - [x] Bug fix (non-breaking change that resolves an issue) - [x] New feature (non-breaking change that adds functionality) - [x] Breaking change (a fix or feature that would cause existing functionality to change unexpectedly) ## Prerequisites The following efforts must be made for the PR to be considered. Please check when completed: - [x] Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions) - [x] Testing performed (I have tested my changes, ensuring everything works as expected) - [x] Documentation updated (I have updated any relevant documentation) ## Related Pull Requests / Discussions If there are other pull requests or discussions related to this change, please link them here: - Related PR #487 #480 #322 #404 --- koel_new.sh: (koel_old.sh same output) ![image](https://github.com/user-attachments/assets/65f9f1dd-acdf-41e4-af0a-e634ed53be98) --- koel_full.sh (other size, version, os, verbose) ![image](https://github.com/user-attachments/assets/59404229-8adc-42ab-a0ff-a76fd4ef560f) --- MOTD: ![image](https://github.com/user-attachments/assets/6054c66e-5675-476f-8080-a72a7b3a410a) --- TAGS: ![image](https://github.com/user-attachments/assets/91fc11db-48cc-47a4-a53b-8c46901f52b3) --- You are welcome to test it on my DEV repo, please note that not all scripts are functional. All my tests i do with this 5 Scripts: - koel_full - koel_new - koel_old - koel_without_base - nextpvr ```bash bash -c "$(wget -qLO - https://raw.githubusercontent.com/MickLesk/Proxmox_DEV/refs/heads/main/ct/koel_new.sh)" bash -c "$(wget -qLO - https://raw.githubusercontent.com/MickLesk/Proxmox_DEV/refs/heads/main/ct/koel_old.sh)" bash -c "$(wget -qLO - https://raw.githubusercontent.com/MickLesk/Proxmox_DEV/refs/heads/main/ct/koel_full.sh)" bash -c "$(wget -qLO - https://raw.githubusercontent.com/MickLesk/Proxmox_DEV/refs/heads/main/ct/koel_without_base.sh)" bash -c "$(wget -qLO - https://raw.githubusercontent.com/MickLesk/Proxmox_DEV/refs/heads/main/ct/nextpvr.sh)" ``` => koel_without_base should abort because there is not enough memory. This was an extra scenario for aborting. => PS: "update" for koel not working yet, its in active development I have prepared 4 variants for koel. But the following should also work: - ampache - hoodik - nodebb (idk) - scrutiny - urbackup --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 05:08:05 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Implemented in VED waiting push to Main
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
in project pipeline
invalid
investigation
json
maintenance
needs triage
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
🛑 Failure to comply with the guidelines
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ProxmoxVE#2689
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?