starred/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-02-05 08:40:11 +03:00
Code Issues 23 Packages Projects Releases 10 Wiki Activity

[PR #143] [MERGED] Remove need for custom DNS in Nextcloud install script #2485

New Issue
Closed
opened 2026-02-05 04:58:26 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 04:58:26 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/143
Author: @remz1337
Created: 11/9/2024
Status: ✅ Merged
Merged: 11/9/2024
Merged by: @newzealandpaul

Base: main ← Head: fix-nextcloud

📝 Commits (1)

  • 424ecb9 Remove need for custom DNS

📊 Changes

1 file changed (+0 additions, -10 deletions)

View changed files

📝 install/nextcloudpi-install.sh (+0 -10)

📄 Description

Note

We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description

Fix in nextcloud script has been deployed, so we don't need anymore the custom DNS hack.

Tested and working on my side
https://github.com/nextcloud/nextcloudpi/pull/2004
https://github.com/nextcloud/nextcloudpi/issues/1926

Fixes # (issue)
https://github.com/community-scripts/ProxmoxVE/issues/94

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)
  • Documentation update required (this change requires an update to the documentation)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/143 **Author:** [@remz1337](https://github.com/remz1337) **Created:** 11/9/2024 **Status:** ✅ Merged **Merged:** 11/9/2024 **Merged by:** [@newzealandpaul](https://github.com/newzealandpaul) **Base:** `main` ← **Head:** `fix-nextcloud` --- ### 📝 Commits (1) - [`424ecb9`](https://github.com/community-scripts/ProxmoxVE/commit/424ecb9a4452bf8a089158fc8e321a3189061ad4) Remove need for custom DNS ### 📊 Changes **1 file changed** (+0 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `install/nextcloudpi-install.sh` (+0 -10) </details> ### 📄 Description > [!NOTE] > We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged. ## Description Fix in nextcloud script has been deployed, so we don't need anymore the custom DNS hack. Tested and working on my side https://github.com/nextcloud/nextcloudpi/pull/2004 https://github.com/nextcloud/nextcloudpi/issues/1926 Fixes # (issue) https://github.com/community-scripts/ProxmoxVE/issues/94 ## Type of change Please check the relevant option(s): - [X] Bug fix (non-breaking change that resolves an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (a fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts.) - [ ] Documentation update required (this change requires an update to the documentation) ## Prerequisites The following efforts must be made for the PR to be considered. Please check when completed: - [X] Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions) - [X] Testing performed (I have tested my changes, ensuring everything works as expected) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 04:58:26 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Implemented in VED waiting push to Main
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
in project pipeline
invalid
investigation
json
maintenance
needs triage
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
🛑 Failure to comply with the guidelines
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ProxmoxVE#2485
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?