starred/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-02-05 00:29:55 +03:00
Code Issues 13 Packages Projects Releases 10 Wiki Activity

[PR #95] [MERGED] Remove custom update script in Pi-Alert installation #2461

New Issue
Closed
opened 2026-02-05 04:57:08 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 04:57:08 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/95
Author: @remz1337
Created: 11/6/2024
Status: ✅ Merged
Merged: 11/6/2024
Merged by: @MickLesk

Base: main ← Head: fix-pialert

📝 Commits (1)

  • 1094f4f Remove custom update script. This is handled by the update script and the /usr/bin/update is created automatically by the customize function in install.func

📊 Changes

1 file changed (+0 additions, -2 deletions)

View changed files

📝 install/pialert-install.sh (+0 -2)

📄 Description

Description

Remove custom update script in Pi-Alert installation. The file /usr/bin/update is created automatically by the customize function in install.func and should not be overwritten (keep the update logic in the update script)

Type of change

  • Bug fix (non-breaking change that resolves an issue)
  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/95 **Author:** [@remz1337](https://github.com/remz1337) **Created:** 11/6/2024 **Status:** ✅ Merged **Merged:** 11/6/2024 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `fix-pialert` --- ### 📝 Commits (1) - [`1094f4f`](https://github.com/community-scripts/ProxmoxVE/commit/1094f4f5a305256601f8f47b59221493e0241313) Remove custom update script. This is handled by the update script and the /usr/bin/update is created automatically by the customize function in install.func ### 📊 Changes **1 file changed** (+0 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `install/pialert-install.sh` (+0 -2) </details> ### 📄 Description ## Description Remove custom update script in Pi-Alert installation. The file `/usr/bin/update` is created automatically by the customize function in install.func and should not be overwritten (keep the update logic in the update script) ## Type of change - [X] Bug fix (non-breaking change that resolves an issue) - [X] Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 04:57:08 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Implemented in VED waiting push to Main
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
in project pipeline
invalid
investigation
json
maintenance
needs triage
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
🛑 Failure to comply with the guidelines
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ProxmoxVE#2461
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?