starred/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-02-05 08:40:11 +03:00
Code Issues 23 Packages Projects Releases 10 Wiki Activity

Zipline installs without git breaking version validation #2275

New Issue
Closed
opened 2026-02-05 04:22:32 +03:00 by OVERLORD · 7 comments
OVERLORD commented 2026-02-05 04:22:32 +03:00
Owner
Copy Link

Originally created by @pyxfluff on GitHub (Jan 4, 2026).

✅ Have you read and understood the above guidelines?

yes

🔎 Did you run the script with verbose mode enabled?

Yes, verbose mode was enabled and the output is included below

📜 What is the name of the script you are using?

Zipline

📂 What was the exact command used to execute the script?

bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/zipline.sh)"

⚙️ What settings are you using?

  • Default Settings
  • Advanced Settings

🖥️ Which Linux distribution are you using?

Debian 13

📈 Which Proxmox version are you on?

pve 9.1.1

📝 Provide a clear and concise description of the issue.

When Zipline installs, git is not installed nor initialized in the repository, which breaks the core update function. Installing Git manually does not fix this when installed due to the missing git metadata in /opt/zipline

🔄 Steps to reproduce the issue.

Install zipline
Log in and check the devtools, the update endpoint returns a 500
Check the systemd unit

❌ Paste the full error output (if available).

Jan 03 20:25:56 zipline pnpm[67833]: /bin/sh: 1: git: not found
Jan 03 20:26:36 zipline pnpm[67833]: /bin/sh: 1: git: not found
Jan 03 20:26:36 zipline pnpm[67833]: [2026-01-03T20:26:36 WARN version] failed to get commit hash: Command failed: git rev-parse --short HEAD
Jan 03 20:26:36 zipline pnpm[67833]: /bin/sh: 1: git: not found
Jan 03 20:27:32 zipline pnpm[67833]: /bin/sh: 1: git: not found
Jan 03 20:27:32 zipline pnpm[67833]: [2026-01-03T20:27:32 WARN version] failed to get commit hash: Command failed: git rev-parse --short HEAD
Jan 03 20:27:32 zipline pnpm[67833]: /bin/sh: 1: git: not found
Jan 03 20:30:15 zipline pnpm[67833]: fatal: not a git repository (or any of the parent directories): .git
Jan 03 20:30:15 zipline pnpm[67833]: [2026-01-03T20:30:15 WARN version] failed to get commit hash: Command failed: git rev-parse --short HEAD
Jan 03 20:30:15 zipline pnpm[67833]: fatal: not a git repository (or any of the parent directories): .git

🖼️ Additional context (optional).

Image
Originally created by @pyxfluff on GitHub (Jan 4, 2026). ### ✅ Have you read and understood the above guidelines? yes ### 🔎 Did you run the script with verbose mode enabled? Yes, verbose mode was enabled and the output is included below ### 📜 What is the name of the script you are using? Zipline ### 📂 What was the exact command used to execute the script? bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/zipline.sh)" ### ⚙️ What settings are you using? - [ ] Default Settings - [x] Advanced Settings ### 🖥️ Which Linux distribution are you using? Debian 13 ### 📈 Which Proxmox version are you on? pve 9.1.1 ### 📝 Provide a clear and concise description of the issue. When Zipline installs, `git` is not installed nor initialized in the repository, which breaks the core update function. Installing Git manually does not fix this when installed due to the missing git metadata in /opt/zipline ### 🔄 Steps to reproduce the issue. Install zipline Log in and check the devtools, the update endpoint returns a 500 Check the systemd unit ### ❌ Paste the full error output (if available). Jan 03 20:25:56 zipline pnpm[67833]: /bin/sh: 1: git: not found Jan 03 20:26:36 zipline pnpm[67833]: /bin/sh: 1: git: not found Jan 03 20:26:36 zipline pnpm[67833]: [2026-01-03T20:26:36 WARN version] failed to get commit hash: Command failed: git rev-parse --short HEAD Jan 03 20:26:36 zipline pnpm[67833]: /bin/sh: 1: git: not found Jan 03 20:27:32 zipline pnpm[67833]: /bin/sh: 1: git: not found Jan 03 20:27:32 zipline pnpm[67833]: [2026-01-03T20:27:32 WARN version] failed to get commit hash: Command failed: git rev-parse --short HEAD Jan 03 20:27:32 zipline pnpm[67833]: /bin/sh: 1: git: not found Jan 03 20:30:15 zipline pnpm[67833]: fatal: not a git repository (or any of the parent directories): .git Jan 03 20:30:15 zipline pnpm[67833]: [2026-01-03T20:30:15 WARN version] failed to get commit hash: Command failed: git rev-parse --short HEAD Jan 03 20:30:15 zipline pnpm[67833]: fatal: not a git repository (or any of the parent directories): .git ### 🖼️ Additional context (optional). <img width="515" height="369" alt="Image" src="https://github.com/user-attachments/assets/8b927f28-7c12-456c-86e2-4168c7275345" />
OVERLORD added the not a script issuebugexternal labels 2026-02-05 04:22:32 +03:00
OVERLORD commented 2026-02-05 04:22:35 +03:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Jan 4, 2026):

https://github.com/diced/zipline/issues/new/choose

@MickLesk commented on GitHub (Jan 4, 2026): > https://github.com/diced/zipline/issues/new/choose
OVERLORD commented 2026-02-05 04:22:39 +03:00
Author
Owner
Copy Link

@pyxfluff commented on GitHub (Jan 4, 2026):

https://github.com/diced/zipline/issues/new/choose

The script is installing the container without Git and is not initializing the repository correctly, is this not a script issue?

I agree upstream could do a better job with knowing the current version but this does not seem like a them problem and I'm sure if I opened an issue on their end it would turn into "this is an installation problem and we can't do anything about it"

@pyxfluff commented on GitHub (Jan 4, 2026): > > https://github.com/diced/zipline/issues/new/choose The script is installing the container without Git and is not initializing the repository correctly, is this not a script issue? I agree upstream could do a better job with knowing the current version but this does not seem like a them problem and I'm sure if I opened an issue on their end it would turn into "this is an installation problem and we can't do anything about it"
OVERLORD commented 2026-02-05 04:22:42 +03:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Jan 4, 2026):

We Always Install without Git and use Release tarballs. That worked for ages in this Script. If it suddenly doesn't work anymore, it's because of the upstream. “git” is unnecessary. Pnpm requires a “.git” folder here, which is simply not delivered with the tarball. Basically, it's always nonsense to search for any “git” files anyway. Many projects have had this problem in the past and then switched back cleanly.

@MickLesk commented on GitHub (Jan 4, 2026): We Always Install without Git and use Release tarballs. That worked for ages in this Script. If it suddenly doesn't work anymore, it's because of the upstream. “git” is unnecessary. Pnpm requires a “.git” folder here, which is simply not delivered with the tarball. Basically, it's always nonsense to search for any “git” files anyway. Many projects have had this problem in the past and then switched back cleanly.
OVERLORD commented 2026-02-05 04:22:46 +03:00
Author
Owner
Copy Link

@tremor021 commented on GitHub (Jan 4, 2026):

@pyxfluff btw what is this "core update function" you speak of?

update command works just fine

@tremor021 commented on GitHub (Jan 4, 2026): @pyxfluff btw what is this "core update function" you speak of? `update` command works just fine
OVERLORD commented 2026-02-05 04:22:51 +03:00
Author
Owner
Copy Link

@pyxfluff commented on GitHub (Jan 4, 2026):

@tremor021

@pyxfluff btw what is this "core update function" you speak of?

update command works just fine

I meant the update widget in the app UI, usually it says the version of the server and if it's up to date or not but as stated it doesn't work due to the missing git metadata

@pyxfluff commented on GitHub (Jan 4, 2026): @tremor021 > @pyxfluff btw what is this "core update function" you speak of? > > `update` command works just fine I meant the update widget in the app UI, usually it says the version of the server and if it's up to date or not but as stated it doesn't work due to the missing git metadata
OVERLORD commented 2026-02-05 04:22:52 +03:00
Author
Owner
Copy Link

@tremor021 commented on GitHub (Jan 4, 2026):

Yes, but as we are deploying the app by means of release tarballs (which don't include .git metadata) you will rely on the update command that will check if new release tarballs are available.
The script itself is tracking the versions, so its safe to ignore the update widget inside the app itself

@tremor021 commented on GitHub (Jan 4, 2026): Yes, but as we are deploying the app by means of release tarballs (which don't include .git metadata) you will rely on the `update` command that will check if new release tarballs are available. The script itself is tracking the versions, so its safe to ignore the update widget inside the app itself
OVERLORD commented 2026-02-05 04:22:54 +03:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Jan 4, 2026):

Ah its an build in updater, okay this never can Work with tarballs in this Case. So you our update function, not the build-in

@MickLesk commented on GitHub (Jan 4, 2026): Ah its an build in updater, okay this never can Work with tarballs in this Case. So you our update function, not the build-in
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Implemented in VED waiting push to Main
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
in project pipeline
invalid
investigation
json
maintenance
needs triage
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
🛑 Failure to comply with the guidelines
No Label bug external not a script issue
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ProxmoxVE#2275
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?