starred/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-02-05 00:29:55 +03:00
Code Issues 11 Packages Projects Releases 10 Wiki Activity

CT Tags are not applied if Container is installed with "Advanced Settings" #216

New Issue
Closed
opened 2026-02-04 17:11:44 +03:00 by OVERLORD · 2 comments
OVERLORD commented 2026-02-04 17:11:44 +03:00
Owner
Copy Link

Originally created by @andygrunwald on GitHub (Dec 26, 2024).

Originally assigned to: @MickLesk on GitHub.

✅ Have you read and understood the above guidelines?

yes

📜 What is the name of the script you are using?

prometheus

📂 What was the exact command used to execute the script?

bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/ct/prometheus.sh)"

📝 Provide a clear and concise description of the issue.

If you install Prometheus with the "Default settings", the tag monitoring is getting applied, see 9b07fe4178/ct/prometheus.sh (L10C11-L10C21)
Like in Screenshot 2024-12-25 at 18 19 41

If you install with "Advances settings", only the community-scripts tag gets applied.
Screenshot 2024-12-26 at 10 25 34

⚙️ What settings are you using?

  • Default Settings
  • Advanced Settings

🖥️ Which Linux distribution are you using?

Debian 12

🔄 Steps to reproduce the issue.

Run installation of prometheus with default and advanced settings: bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/ct/prometheus.sh)"

❌ Paste the full error output (if available).

No error output available

🖼️ Additional context (optional).

No response

Originally created by @andygrunwald on GitHub (Dec 26, 2024). Originally assigned to: @MickLesk on GitHub. ### ✅ Have you read and understood the above guidelines? yes ### 📜 What is the name of the script you are using? prometheus ### 📂 What was the exact command used to execute the script? bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/ct/prometheus.sh)" ### 📝 Provide a clear and concise description of the issue. If you install Prometheus with the "Default settings", the tag `monitoring` is getting applied, see https://github.com/community-scripts/ProxmoxVE/blob/9b07fe41785e9fd11bb4f9245e1511ea1aab59c6/ct/prometheus.sh#L10C11-L10C21 Like in ![Screenshot 2024-12-25 at 18 19 41](https://github.com/user-attachments/assets/bcaac2c3-12f7-4935-b9a9-d6f82f9b1da7) If you install with "Advances settings", only the `community-scripts` tag gets applied. <img width="471" alt="Screenshot 2024-12-26 at 10 25 34" src="https://github.com/user-attachments/assets/cabe2d1a-e506-431a-b940-f6407816c2f6" /> ### ⚙️ What settings are you using? - [X] Default Settings - [X] Advanced Settings ### 🖥️ Which Linux distribution are you using? Debian 12 ### 🔄 Steps to reproduce the issue. Run installation of prometheus with default and advanced settings: bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/ct/prometheus.sh)" ### ❌ Paste the full error output (if available). No error output available ### 🖼️ Additional context (optional). _No response_
OVERLORD commented 2026-02-04 17:11:55 +03:00
Author
Owner
Copy Link

@dsiebel commented on GitHub (Dec 26, 2024):

Can confirm.
In advanced settings the tags are being set to community-script;, which overwrites the settings from base_settings:
https://github.com/community-scripts/ProxmoxVE/blob/main/misc/build.func#L320

@dsiebel commented on GitHub (Dec 26, 2024): Can confirm. In advanced settings the tags are being set to `community-script;`, which overwrites the settings from `base_settings`: https://github.com/community-scripts/ProxmoxVE/blob/main/misc/build.func#L320
OVERLORD commented 2026-02-04 17:12:05 +03:00
Author
Owner
Copy Link

@TheRealVira commented on GitHub (Dec 27, 2024):

If it helps any, I set up a PR to reverse tags to proxmox-helper-scripts and include var_tags for advanced setup: https://github.com/community-scripts/ProxmoxVE/pull/1038

@TheRealVira commented on GitHub (Dec 27, 2024): If it helps any, I set up a PR to reverse tags to `proxmox-helper-scripts` and include `var_tags` for advanced setup: https://github.com/community-scripts/ProxmoxVE/pull/1038
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Implemented in VED waiting push to Main
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
in project pipeline
invalid
investigation
json
maintenance
needs triage
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
🛑 Failure to comply with the guidelines
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ProxmoxVE#216
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?