starred/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-02-05 00:29:55 +03:00
Code Issues 13 Packages Projects Releases 10 Wiki Activity

Changedetectio.io - Request to fix Width And Height definition #188

New Issue
Closed
opened 2026-02-04 17:01:51 +03:00 by OVERLORD · 4 comments
OVERLORD commented 2026-02-04 17:01:51 +03:00
Owner
Copy Link

Originally created by @Lockie85 on GitHub (Dec 17, 2024).

✅ Have you read and understood the above guidelines?

yes

📜 What is the name of the script you are using?

Change Detection LXC

📂 What was the exact command used to execute the script?

bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/ct/changedetection.sh)"

📝 Provide a clear and concise description of the issue.

The script isn't up to date with latest guidance which enables the resolution to be set for playwright, see here for details:
https://github.com/dgtlmoon/changedetection.io/discussions/2739#discussioncomment-11591215

⚙️ What settings are you using?

  • Default Settings
  • Advanced Settings

🖥️ Which Linux distribution are you using?

Debian 12

🔄 Steps to reproduce the issue.

  1. Install the script with default settings.
  2. Within Changedetection.io "Add a new change detection watch" e.g. "https://store.steampowered.com/" and select "Edit > Watch"
  3. Select tab "Request"
  4. Select "Fetch Method" > "Playwright Chromium/Javascript via 'ws://localhost:3000/chrome?launch={defaultViewport:{height:720,width:1280},headless:false,stealth:true}&blockAds=true'"
  5. Select "Save"
  6. Wait for the site to process
  7. Select "Edit" on the site
  8. Select "Visual Filter Selector"
  9. Notice the issue, the resolution is to small for the site and adjusting the current settings within "changedetection.service" does not work.

❌ Paste the full error output (if available).

No error

🖼️ Additional context (optional).

No response

Originally created by @Lockie85 on GitHub (Dec 17, 2024). ### ✅ Have you read and understood the above guidelines? yes ### 📜 What is the name of the script you are using? Change Detection LXC ### 📂 What was the exact command used to execute the script? bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/ct/changedetection.sh)" ### 📝 Provide a clear and concise description of the issue. The script isn't up to date with latest guidance which enables the resolution to be set for playwright, see here for details: https://github.com/dgtlmoon/changedetection.io/discussions/2739#discussioncomment-11591215 ### ⚙️ What settings are you using? - [X] Default Settings - [ ] Advanced Settings ### 🖥️ Which Linux distribution are you using? Debian 12 ### 🔄 Steps to reproduce the issue. 1. Install the script with default settings. 2. Within Changedetection.io "Add a new change detection watch" e.g. "https://store.steampowered.com/" and select "Edit > Watch" 3. Select tab "Request" 4. Select "Fetch Method" > "Playwright Chromium/Javascript via 'ws://localhost:3000/chrome?launch={defaultViewport:{height:720,width:1280},headless:false,stealth:true}&blockAds=true'" 5. Select "Save" 6. Wait for the site to process 7. Select "Edit" on the site 8. Select "Visual Filter Selector" 9. Notice the issue, the resolution is to small for the site and adjusting the current settings within "changedetection.service" does not work. ### ❌ Paste the full error output (if available). No error ### 🖼️ Additional context (optional). _No response_
OVERLORD added the not a script issuewontdo labels 2026-02-04 17:01:51 +03:00
OVERLORD commented 2026-02-04 17:02:00 +03:00
Author
Owner
Copy Link

@michelroegl-brunner commented on GitHub (Dec 18, 2024):

Do you have the changes we can make on hand? In the linked disccusion i can see no solution for this problem.

@michelroegl-brunner commented on GitHub (Dec 18, 2024): Do you have the changes we can make on hand? In the linked disccusion i can see no solution for this problem.
OVERLORD commented 2026-02-04 17:02:11 +03:00
Author
Owner
Copy Link

@Lockie85 commented on GitHub (Dec 20, 2024):

Do you have the changes we can make on hand? In the linked discussion I can see no solution for this problem.

I don't have the exact changes required to be implemented to resolve the issue no. Only a direction which I don't understand how to execute.

Firstly I believe you can no longer use this:
PLAYWRIGHT_DRIVER_URL=ws://localhost:3000
Instead you need to use this:
PLAYWRIGHT_DRIVER_URL=ws://sockpuppetbrowser:3000

There might be more knock-ons from that, I don't know but this is what I understand so far.

Potentially this page provides the correct guidance...
https://github.com/dgtlmoon/changedetection.io/wiki/Playwright-content-fetcher

@Lockie85 commented on GitHub (Dec 20, 2024): > Do you have the changes we can make on hand? In the linked discussion I can see no solution for this problem. I don't have the exact changes required to be implemented to resolve the issue no. Only a direction which I don't understand how to execute. Firstly I believe you can no longer use this: `PLAYWRIGHT_DRIVER_URL=ws://localhost:3000` Instead you need to use this: `PLAYWRIGHT_DRIVER_URL=ws://sockpuppetbrowser:3000` There might be more knock-ons from that, I don't know but this is what I understand so far. Potentially this page provides the correct guidance... https://github.com/dgtlmoon/changedetection.io/wiki/Playwright-content-fetcher
OVERLORD commented 2026-02-04 17:02:18 +03:00
Author
Owner
Copy Link

@reikolydia commented on GitHub (Dec 24, 2024):

Instead you need to use this: PLAYWRIGHT_DRIVER_URL=ws://sockpuppetbrowser:3000

Where does it state that? what does sockpuppetbrowser actually resolve to? i'd prefer an ip address instead of a hostname

@reikolydia commented on GitHub (Dec 24, 2024): > Instead you need to use this: `PLAYWRIGHT_DRIVER_URL=ws://sockpuppetbrowser:3000` Where does it state that? what does `sockpuppetbrowser` actually resolve to? i'd prefer an ip address instead of a hostname
OVERLORD commented 2026-02-04 17:02:28 +03:00
Author
Owner
Copy Link

@michelroegl-brunner commented on GitHub (Jan 22, 2025):

I can not find a solution for this. This is not an initial problem from our script. We can not support each individual app. When you find a solution open a pr to fix it or a disscussion.

@michelroegl-brunner commented on GitHub (Jan 22, 2025): I can not find a solution for this. This is not an initial problem from our script. We can not support each individual app. When you find a solution open a pr to fix it or a disscussion.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Implemented in VED waiting push to Main
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
in project pipeline
invalid
investigation
json
maintenance
needs triage
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
🛑 Failure to comply with the guidelines
No Label not a script issue wontdo
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ProxmoxVE#188
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?