starred/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-02-05 00:29:55 +03:00
Code Issues 12 Packages Projects Releases 10 Wiki Activity

LXC installation hangs at 'Validating storage' spinner #1719

New Issue
Closed
opened 2026-02-05 02:03:36 +03:00 by OVERLORD · 1 comment
OVERLORD commented 2026-02-05 02:03:36 +03:00
Owner
Copy Link

Originally created by @rcourtman on GitHub (Oct 3, 2025).

LXC installation hangs at "Validating storage" spinner

Description

When running the Pulse installation script (and potentially other LXC installations), the process hangs showing a spinning animation with the text "⠸ Validating storage" when the storage pool selection dialog appears.

Image

Steps to Reproduce

bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/pulse.sh)"

The script displays the storage pool selection dialog, but the "Validating storage" spinner continues running in the background, making the whiptail UI difficult to interact with or appearing corrupted.

What I Found

Looking at the code history, I noticed that commit e46648ec removed the msg_ok "Valid Storage Found" line that was previously stopping the spinner started by msg_info "Validating storage" on line 203 of misc/create_lxc.sh.

Previous working code (commit 7bf69cbd):

msg_info "Validating Storage"
if ! check_storage_support "rootdir"; then
  msg_error "No valid storage found for 'rootdir' (Container)."
  exit 1
fi
if ! check_storage_support "vztmpl"; then
  msg_error "No valid storage found for 'vztmpl' (Template)."
  exit 1
fi
msg_ok "Valid Storage Found"  # ← This line was present and working

Current code (lines 203-213):

msg_info "Validating storage"
if ! check_storage_support "rootdir"; then
  msg_error "No valid storage found for 'rootdir' [Container]"
  exit 1
fi
if ! check_storage_support "vztmpl"; then
  msg_error "No valid storage found for 'vztmpl' [Template]"
  exit 1
fi
# Missing msg_ok here - spinner keeps running

#msg_info "Checking template storage"
while true; do
  if select_storage template; then

Analysis

The msg_info function starts a background spinner process that needs to be stopped with either msg_ok, msg_error, or msg_warn. When the spinner isn't stopped before the whiptail dialog appears (line 151 in select_storage), the two visual elements conflict, causing the display issue.

Potential Solution

Adding back a msg_ok call after the storage validation (around line 211) would stop the spinner before the whiptail dialog appears. Something like:

fi
msg_ok "Validated Storage"

#msg_info "Checking template storage"

I'm not 100% certain this is the root cause, but the pattern matches other spinner-related fixes in this repo (e.g., commit 41f4aebd which fixed a similar infinite spinner issue).

Environment

  • Proxmox VE version: 8.x
  • Installation method: Community scripts
  • Affected script: ct/pulse.sh (and potentially all LXC installation scripts since this is in the core create_lxc.sh)

Happy to provide more details, test any fixes, or submit a PR if you'd like! Thanks for maintaining these awesome scripts.

Originally created by @rcourtman on GitHub (Oct 3, 2025). # LXC installation hangs at "Validating storage" spinner ## Description When running the Pulse installation script (and potentially other LXC installations), the process hangs showing a spinning animation with the text "⠸ Validating storage" when the storage pool selection dialog appears. ![Image](https://github.com/user-attachments/assets/360fd4c3-c9e0-4957-9f0d-053816e639a4) ## Steps to Reproduce ```bash bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/pulse.sh)" ``` The script displays the storage pool selection dialog, but the "Validating storage" spinner continues running in the background, making the whiptail UI difficult to interact with or appearing corrupted. ## What I Found Looking at the code history, I noticed that commit `e46648ec` removed the `msg_ok "Valid Storage Found"` line that was previously stopping the spinner started by `msg_info "Validating storage"` on line 203 of `misc/create_lxc.sh`. **Previous working code (commit 7bf69cbd):** ```bash msg_info "Validating Storage" if ! check_storage_support "rootdir"; then msg_error "No valid storage found for 'rootdir' (Container)." exit 1 fi if ! check_storage_support "vztmpl"; then msg_error "No valid storage found for 'vztmpl' (Template)." exit 1 fi msg_ok "Valid Storage Found" # ← This line was present and working ``` **Current code (lines 203-213):** ```bash msg_info "Validating storage" if ! check_storage_support "rootdir"; then msg_error "No valid storage found for 'rootdir' [Container]" exit 1 fi if ! check_storage_support "vztmpl"; then msg_error "No valid storage found for 'vztmpl' [Template]" exit 1 fi # Missing msg_ok here - spinner keeps running #msg_info "Checking template storage" while true; do if select_storage template; then ``` ## Analysis The `msg_info` function starts a background spinner process that needs to be stopped with either `msg_ok`, `msg_error`, or `msg_warn`. When the spinner isn't stopped before the whiptail dialog appears (line 151 in `select_storage`), the two visual elements conflict, causing the display issue. ## Potential Solution Adding back a `msg_ok` call after the storage validation (around line 211) would stop the spinner before the whiptail dialog appears. Something like: ```bash fi msg_ok "Validated Storage" #msg_info "Checking template storage" ``` I'm not 100% certain this is the root cause, but the pattern matches other spinner-related fixes in this repo (e.g., commit 41f4aebd which fixed a similar infinite spinner issue). ## Environment - Proxmox VE version: 8.x - Installation method: Community scripts - Affected script: `ct/pulse.sh` (and potentially all LXC installation scripts since this is in the core `create_lxc.sh`) Happy to provide more details, test any fixes, or submit a PR if you'd like! Thanks for maintaining these awesome scripts.
OVERLORD commented 2026-02-05 02:03:43 +03:00
Author
Owner
Copy Link

@michelroegl-brunner commented on GitHub (Oct 3, 2025):

Duplicate of #7165 It is already fixed in Dev, we wait for Mick to push the changes to Main.

@michelroegl-brunner commented on GitHub (Oct 3, 2025): Duplicate of #7165 It is already fixed in Dev, we wait for Mick to push the changes to Main.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Implemented in VED waiting push to Main
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
in project pipeline
invalid
investigation
json
maintenance
needs triage
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
🛑 Failure to comply with the guidelines
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ProxmoxVE#1719
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?