mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-11 03:13:15 +03:00
LUA Language #993
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Etheroit on GitHub (Jan 17, 2019).
Describe the feature you'd like
I'd really appreciated if more code languages (such as Lua which is important for me) could be released.
Describe the benefits this feature would bring to BookStack users
I think that there are so much people using languages others than these already setupped.
Additional context
I think that it wont be hard adding more if framework already exists.
Thanks for help!
@Mant1kor commented on GitHub (Jan 17, 2019):
Does markdown-editor not support lua?
@Etheroit commented on GitHub (Jan 17, 2019):
Not for me at least. I've updated to the latest version anyways
@ssddanbrown commented on GitHub (Jan 18, 2019):
Codemirror supports lua, So support could easily be added, but it might be best to evaluate the cost of including loads of different languages, and perhaps look at different ways of loading them if required.
@Etheroit commented on GitHub (Jan 18, 2019):
I tried to add it on my own but it failed at the end so.
@Etheroit commented on GitHub (Jan 18, 2019):
@ssddanbrown Any tips about loading them manually or information if this can be worked on?
@ssddanbrown commented on GitHub (Mar 2, 2019):
This has now been added, Will be in the next patch release.
@Etheroit commented on GitHub (Mar 2, 2019):
@ssddanbrown Hey! Thanks. Any clue when the patch release will be on?
@ssddanbrown commented on GitHub (Mar 2, 2019):
@DevKurka I have a rough target of next weekend as a target for the patch release. No guarantees though.
@Etheroit commented on GitHub (Mar 2, 2019):
@ssddanbrown Is there any way to get it installed before it's released?
@Nico207 commented on GitHub (Mar 7, 2019):
I made the same changes as the commit
e471d0cAdding a block of Lua code does nothing more, the text remains blank.
Should I do something more.
I tried on other languages, with the same result (white text)
@Etheroit commented on GitHub (Mar 7, 2019):
@Nico207 Can reproduce. Had the same issue and that's the only one reason why I am waiting for the update.
@Etheroit commented on GitHub (Mar 7, 2019):
@ssddanbrown Any tip for that?
@ssddanbrown commented on GitHub (Mar 8, 2019):
@Nico207 @DevKurka Changes the JS files have to be built via node (Details in the readme).
If you don't want to do that but really need this, Here's a zip of the built JS from the current master branch. Can can try extracting the contained file out to
public/dist/app.js. Can't guarantee stability though since this is from a development branch.app.zip
Otherwise, Will just have to wait for the release.
Changing the files in the commit, or following the above, is not really supported and can cause conflicts on updating BookStack.
@Nico207 commented on GitHub (Mar 11, 2019):
Thanks for the zip file.
In my case, I don't really need the Lua language. My goal was mainly to understand how to activate other languages (in my case, VB and Pascal), and see if it was simple.